-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing emojis from Emoji Version 14.0, 15.0 & 15.1. #43815
Add missing emojis from Emoji Version 14.0, 15.0 & 15.1. #43815
Conversation
Signed-off-by: Krishna Gupta <[email protected]>
@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Changes seem fine to me, but how do we know that we've got all of the missing emoji? Do we have a way to compare our emoji list against the "official" list for the latest version? |
@shawnborton, I checked random emojis from version 13 and all of them are there but haven't found any from the versions mentioned below.
|
Well for this comment here:
Are we planning to add those 80 emojis then? |
@shawnborton, yes. |
@Krishna2323 What's the ETA on the PR? |
Signed-off-by: Krishna Gupta <[email protected]>
@mananjadhav, this requires a good amount of time and effort to complete. I will try to add all the emojis on the weekends. |
Signed-off-by: Krishna Gupta <[email protected]>
Signed-off-by: Krishna Gupta <[email protected]>
Signed-off-by: Krishna Gupta <[email protected]>
Signed-off-by: Krishna Gupta <[email protected]>
Signed-off-by: Krishna Gupta <[email protected]>
Signed-off-by: Krishna Gupta <[email protected]>
Signed-off-by: Krishna Gupta <[email protected]>
@mananjadhav, should we add recordings? |
What's the latest on this one? |
@Krishna2323 Please provide the update on this one. Added a comment on the issue also. |
Signed-off-by: krishna2323 <[email protected]>
Signed-off-by: krishna2323 <[email protected]>
@Krishna2323 thanks for raising the PR. The change is of adding emojis and I am just trying to figure out if I can validate. Can you link the source from where you picked the emojis and the keywords. |
@mananjadhav, the emojis are picked from here 14.0](https://emojipedia.org/emoji-14.0), 15.0, and 15.1 and I have used AI for keywords and also verified here. |
Reviewer Checklist
Screenshots/VideosMacOS: Chrome / Safariweb-new-emojis.movMacOS: Desktopdesktop-new-emojis.movdesktop-new-emojis-2.mov |
My Android emulator doesn't support the latest emojis but rest everything looks fine. |
We did not find an internal engineer to review this PR, trying to assign a random engineer to #42588 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works as intended 👍
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.0.14-1 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
🚀 Deployed to production by https://github.com/roryabraham in version: 9.0.14-6 🚀
|
Details
Fixed Issues
$ #42588
PROPOSAL: #42588 (comment)
Tests
:emojiName
from list below.Missing Emojis List
Offline tests
Same as Tests.
QA Steps
Same as Tests.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop