Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Web - Chat - Many emojis broken in emoji picker and chat history #46454

Open
1 of 6 tasks
lanitochka17 opened this issue Jul 29, 2024 · 29 comments
Open
1 of 6 tasks
Assignees
Labels
Engineering External Added to denote the issue can be worked on by a contributor Monthly KSv2 Needs Reproduction Reproducible steps needed

Comments

@lanitochka17
Copy link

lanitochka17 commented Jul 29, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.14-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4788750
Issue reported by: Applause - Internal Team

Action Performed:

  1. Log in to New Expensify
  2. Navigate to a conversation
  3. Open the emoji picker
  4. Scroll down the list verifying each emoji is rendered correctly
  5. Select any of the broken emojis and send it.
  6. Enter broken emoji code in compose box, e.g. 🧌

Expected Result:

All emojis in emoji picker, chat history and suggestion list should be correctly rendered

Actual Result:

Many emojis are broken in emoji picker, chat history, suggestions and their tooltips are blank
Example emoji codes: 🧌, 🩶, 🫄
Issue is probably Windows only

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6556738_1722289238118.2024-07-29_23-36-47.mp4

137!obraz

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~019dcbe6141bd82081
  • Upwork Job ID: 1823783189793369593
  • Last Price Increase: 2024-08-14
  • Automatic offers:
    • mkhutornyi | Contributor | 103605686
Issue OwnerCurrent Issue Owner: @paultsimura
@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API labels Jul 29, 2024
Copy link

melvin-bot bot commented Jul 29, 2024

Triggered auto assignment to @chiragsalian (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsp

Copy link

melvin-bot bot commented Jul 29, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@chiragsalian
Copy link
Contributor

Not related to web-e repo. Clearing deployblocker label.

@chiragsalian chiragsalian removed the DeployBlocker Indicates it should block deploying the API label Jul 29, 2024
@chiragsalian
Copy link
Contributor

Not sure if this is blocker worthy. I cannot reproduce it.
image

image

image

Maybe the issue is only on windows as mentioned in the title. @stitesExpensify do you have any insight about this issue? if not i was going to mark it as external.

@chiragsalian
Copy link
Contributor

Oh whoops i missed that it was already discussed here. Looks like we might be reverting the offending PR.

@mkhutornyi
Copy link
Contributor

#43815 is the culprit

@mananjadhav
Copy link
Collaborator

I can't reproduce this. These are new Emojis that we added, but I am not sure what's the best way to address this when it could be browser version specific. I am not sure if this should be a Deploy blocker.

image image

@chiragsalian
Copy link
Contributor

i cannot reproduce issue on windows machine, i've asked QA to retest here.

@chiragsalian chiragsalian added Weekly KSv2 Needs Reproduction Reproducible steps needed and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Jul 31, 2024
@chiragsalian
Copy link
Contributor

Demoting since we're unable to reproduce.

@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@m-natarajan
Copy link

Tester is still able to reproduce the issue.

VHTV9341.MP4
2024-07-31.14-19-50.mp4

@mananjadhav
Copy link
Collaborator

Can we get some more information on the system, OS , browser etc. version?

@m-natarajan
Copy link

Desktop: Windows 10 Pro/ Chrome Version 127.0.6533.89 (Official Build) (64-bit)
iOS: iPhone 7/iOS 15.8.2

Build - v9.0.14-5

@mkhutornyi
Copy link
Contributor

I also reproduced on my windows

windows.mp4

@melvin-bot melvin-bot bot added the Overdue label Aug 8, 2024
@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Aug 14, 2024
@paultsimura
Copy link
Contributor

I could not reproduce it either. @mkhutornyi since you could – would you like to take over as C+ here?

@mkhutornyi
Copy link
Contributor

Still reproduced on latest staging v9.0.21-3

I could not reproduce it either. @mkhutornyi since you could – would you like to take over as C+ here?

sure

@melvin-bot melvin-bot bot added the Overdue label Aug 19, 2024
@paultsimura
Copy link
Contributor

Cool. @chiragsalian please re-assign to @mkhutornyi 🙏

@melvin-bot melvin-bot bot removed the Overdue label Aug 19, 2024
Copy link

melvin-bot bot commented Aug 20, 2024

📣 @mkhutornyi 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@melvin-bot melvin-bot bot added the Overdue label Aug 21, 2024
@mkhutornyi
Copy link
Contributor

Waiting for proposals

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Aug 22, 2024
Copy link

melvin-bot bot commented Aug 27, 2024

@chiragsalian, @mkhutornyi Huh... This is 4 days overdue. Who can take care of this?

@chiragsalian
Copy link
Contributor

Waiting for proposals. Demoting to weekly.

@melvin-bot melvin-bot bot removed the Overdue label Aug 28, 2024
@chiragsalian chiragsalian added Weekly KSv2 Overdue and removed Daily KSv2 labels Aug 28, 2024
@melvin-bot melvin-bot bot removed the Overdue label Aug 28, 2024
@melvin-bot melvin-bot bot added the Overdue label Sep 12, 2024
@chiragsalian
Copy link
Contributor

Still waiting for proposals. Demoting to monthly because its only affecting windows users.

@melvin-bot melvin-bot bot removed the Overdue label Sep 18, 2024
@chiragsalian chiragsalian added Monthly KSv2 and removed Weekly KSv2 labels Sep 18, 2024
@melvin-bot melvin-bot bot added the Overdue label Oct 21, 2024
@chiragsalian
Copy link
Contributor

Still waiting for proposals.

@melvin-bot melvin-bot bot removed the Overdue label Oct 23, 2024
@mkhutornyi
Copy link
Contributor

I will be OOO from tomorrow so please reassign if C+ review is needed.
Status: no proposals yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering External Added to denote the issue can be worked on by a contributor Monthly KSv2 Needs Reproduction Reproducible steps needed
Projects
None yet
Development

No branches or pull requests

7 participants