Fix: IOU Request scan camera not displaying when permission first given #39854

chrispader · 2024-04-08T19:16:52Z

@neil-marcellini @deetergp @greg-schroeder

Details

This PR fixes a problem where the camera in IOURequestStepScan would not render, because the current position value provided by react-native-tab-view never updates when changing the tab.

This PR adds a patch for react-native-tab-view which forces a re-render when the tab/page changes.

Fixed Issues

$ #38796
$ #39285
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Test 1:

Create a non-scan money request to someone
Remove camera permissions
Kill and reopen app
Tap request money
Try to scan receipt
Permission prompt is shown
Choose 'Just this time'
Camera view should show

Test 2:

Prerequisite: Reset permission of the app

Go to FAB > Request Money > Scan
Verify that the camera request permission prompt doesn't appear
Click on the Continue button or capture icon
Verify that the camera request permission prompt appears
Accept the permission
Tap "Manual" tab
Close the app
Open the app
Go to FAB > Request Money
Tap Scan tab and verify the screen is NOT black
Tap Capture icon
Verify there is no error after capturing.

Offline tests

None needed.

QA Steps

Verify that no errors appear in the JS console

Same as in Tests.

PR Author Checklist

Screenshots/Videos

Android: Native

Screen_Recording_20240408_210933_New.Expensify.Dev.mp4

Screen_Recording_20240408_213428_New.Expensify.Dev.mp4

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-04-08T19:16:57Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chrispader · 2024-04-08T19:25:40Z

src/hooks/useTabNavigatorFocus/index.ts

@@ -54,12 +54,10 @@ function useTabNavigatorFocus({tabIndex}: UseTabNavigatorFocusParams): boolean {
        if (!tabPositionAnimation) {
            return;
        }
-        const index = Number(tabIndex);
-


These are just cleanup changes, since we don't need to do this cast here. Not related to the issue

neil-marcellini

Not quite sure why I was tagged here, but I'm happy to review. The changes look good and seem to test well.

chrispader · 2024-04-09T06:02:46Z

Not quite sure why I was tagged here, but I'm happy to review. The changes look good and seem to test well.

oh sorry @neil-marcellini, was meaning to tag @Julesssss, whopsii

DylanDylann · 2024-04-09T07:17:23Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

media_20240410_120521_1340472138264406746.mp4

media_20240410_141809_4181304766279209031.mp4

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

DylanDylann · 2024-04-09T07:18:17Z

@chrispader Does this PR still need a C+ review here?

Julesssss · 2024-04-09T07:34:33Z

@chrispader Does this PR still need a C+ review here?

@DylanDylann, yep please go ahead

Julesssss

Changes look good, just awaiting review - @DylanDylann I'll generate builds for you

github-actions · 2024-04-09T07:55:26Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/39854/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/39854/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/39854/NewExpensify.dmg	https://39854.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

DylanDylann

The change looks good

Julesssss

Tests well for me 👍

Julesssss · 2024-04-10T08:41:29Z

Hey @chrispader, is the tab-view changes something that we might be able to get merged upstream?

DylanDylann · 2024-04-10T08:43:52Z

@Julesssss Could you help to create an issue to handle the payment for C+ here?

Julesssss · 2024-04-10T08:51:02Z

Sure, lets handle it here

chrispader · 2024-04-10T09:15:03Z

Hey @chrispader, is the tab-view changes something that we might be able to get merged upstream?

yes, definitely. Should we ask someone from Callstack though, since they are the maintainers of the library? My solution seems more like a hot-fix tbh. Maybe that's also not what they intended to do with the position state of the component.

Julesssss · 2024-04-10T09:17:59Z

Thanks I'll see what they think.

OSBotify · 2024-04-10T17:48:03Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.4.62-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-04-10T17:56:56Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.4.62-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-04-10T19:36:09Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.4.62-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-18T04:33:54Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.62-17 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

chrispader added 2 commits April 8, 2024 21:08

remove logs

390a43f

fix: position never updated in react-native-tab-view

4019e3b

chrispader requested a review from a team as a code owner April 8, 2024 19:16

melvin-bot bot removed the request for review from a team April 8, 2024 19:16

melvin-bot bot requested a review from DylanDylann April 8, 2024 19:16

chrispader mentioned this pull request Apr 8, 2024

[HOLD for payment 2024-04-25] [$250] [HOLD for payment 2024-04-17] [Android] VisionCamera not displaying when permission first given #38796

Closed

chrispader commented Apr 8, 2024

View reviewed changes

chrispader mentioned this pull request Apr 8, 2024

[HOLD for payment 2024-04-25] [HOLD for payment 2024-04-15] [HOLD for payment 2024-04-09] Scan - Camera is seen as black screen and error occurs after tap capture icon #39285

Closed

6 tasks

neil-marcellini approved these changes Apr 8, 2024

View reviewed changes

Julesssss added the Ready To Build label Apr 9, 2024

Julesssss approved these changes Apr 9, 2024

View reviewed changes

DylanDylann approved these changes Apr 10, 2024

View reviewed changes

melvin-bot bot requested a review from deetergp April 10, 2024 06:40

Julesssss approved these changes Apr 10, 2024

View reviewed changes

Julesssss merged commit ac6581e into Expensify:main Apr 10, 2024
20 of 24 checks passed

github-actions bot mentioned this pull request Apr 10, 2024

Deploy Checklist: New Expensify 2024-04-10 #40026

Closed

lakchote mentioned this pull request Apr 11, 2024

[$250] WS - Profile - Share - Workspace QR code is not downloaded to the device #40080

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: IOU Request scan camera not displaying when permission first given #39854

Fix: IOU Request scan camera not displaying when permission first given #39854

chrispader commented Apr 8, 2024 •

edited

Loading

melvin-bot bot commented Apr 8, 2024

chrispader Apr 8, 2024

neil-marcellini left a comment

chrispader commented Apr 9, 2024

DylanDylann commented Apr 9, 2024 •

edited

Loading

DylanDylann commented Apr 9, 2024

Julesssss commented Apr 9, 2024

Julesssss left a comment

github-actions bot commented Apr 9, 2024

DylanDylann left a comment

Julesssss left a comment

Julesssss commented Apr 10, 2024 •

edited

Loading

DylanDylann commented Apr 10, 2024

Julesssss commented Apr 10, 2024

chrispader commented Apr 10, 2024

Julesssss commented Apr 10, 2024

OSBotify commented Apr 10, 2024

OSBotify commented Apr 10, 2024

OSBotify commented Apr 10, 2024

OSBotify commented Apr 18, 2024

Fix: IOU Request scan camera not displaying when permission first given #39854

Fix: IOU Request scan camera not displaying when permission first given #39854

Conversation

chrispader commented Apr 8, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Apr 8, 2024

chrispader Apr 8, 2024

Choose a reason for hiding this comment

neil-marcellini left a comment

Choose a reason for hiding this comment

chrispader commented Apr 9, 2024

DylanDylann commented Apr 9, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

DylanDylann commented Apr 9, 2024

Julesssss commented Apr 9, 2024

Julesssss left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 9, 2024

DylanDylann left a comment

Choose a reason for hiding this comment

Julesssss left a comment

Choose a reason for hiding this comment

Julesssss commented Apr 10, 2024 • edited Loading

DylanDylann commented Apr 10, 2024

Julesssss commented Apr 10, 2024

chrispader commented Apr 10, 2024

Julesssss commented Apr 10, 2024

OSBotify commented Apr 10, 2024

OSBotify commented Apr 10, 2024

OSBotify commented Apr 10, 2024

OSBotify commented Apr 18, 2024

chrispader commented Apr 8, 2024 •

edited

Loading

DylanDylann commented Apr 9, 2024 •

edited

Loading

Julesssss commented Apr 10, 2024 •

edited

Loading