Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Incorrect numpad horizontal padding on the native and mweb devices. #38542

Merged
merged 5 commits into from
Apr 4, 2024
Merged

fix: Incorrect numpad horizontal padding on the native and mweb devices. #38542

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d2c9def
fix: Incorrect numpad horizontal padding on the native and mweb devices.
Krishna2323 Mar 18, 2024
191766b
fix: padding bottom amount selector modal.
Krishna2323 Mar 22, 2024
f248cb6
Merge branch 'Expensify:main' into krishna2323/issue/38523
Krishna2323 Mar 23, 2024
a93aa42
Merge branch 'Expensify:main' into krishna2323/issue/38523
Krishna2323 Apr 2, 2024
f18cfd8
fix margin bottom.
Krishna2323 Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions src/components/AmountPicker/AmountSelectorModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,13 @@ function AmountSelectorModal({value, description = '', onValueSelected, isVisibl
includeSafeAreaPaddingBottom={false}
testID={AmountSelectorModal.displayName}
shouldEnableMaxHeight
style={[styles.pb0]}
>
<HeaderWithBackButton
title={description}
onBackButtonPress={onClose}
/>
<ScrollView contentContainerStyle={[styles.flex1, styles.mh5, styles.mb5]}>
<ScrollView contentContainerStyle={[styles.flexGrow1, styles.mb5]}>
<View style={styles.flex1}>
<AmountForm
// eslint-disable-next-line react/jsx-props-no-spreading
Expand All @@ -45,14 +46,15 @@ function AmountSelectorModal({value, description = '', onValueSelected, isVisibl
value={currentValue}
onInputChange={setValue}
/>
<Button
success
large
pressOnEnter
text={translate('common.save')}
onPress={() => onValueSelected?.(currentValue ?? '')}
style={styles.mh5}
/>
</View>
<Button
success
large
pressOnEnter
text={translate('common.save')}
onPress={() => onValueSelected?.(currentValue ?? '')}
/>
</ScrollView>
</ScreenWrapper>
</Modal>
Expand Down
Loading