fix: Incorrect numpad horizontal padding on the native and mweb devices. #38542

Krishna2323 · 2024-03-18T22:54:25Z

Details

Fixed Issues

$ #38523
PROPOSAL: #38523 (comment)

Tests

Have Collect workspace supported in NewDot
Go to Settings
More feature
Turn on Tax feature
Go to taxes
Add new tax rate
Add value
Verify that the number pad takes up the same width as the Save button.

Verify that no errors appear in the JS console

Offline tests

Have Collect workspace supported in NewDot
Go to Settings
More feature
Turn on Tax feature
Go to taxes
Add new tax rate
Add value
Verify that the number pad takes up the same width as the Save button.

QA Steps

Have Collect workspace supported in NewDot
Go to Settings
More feature
Turn on Tax feature
Go to taxes
Add new tax rate
Add value
Verify that the number pad takes up the same width as the Save button.

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Signed-off-by: Krishna Gupta <[email protected]>

melvin-bot · 2024-03-18T22:54:30Z

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mountiny · 2024-03-18T23:34:10Z

cc @Expensify/design can you please double check? I mean this PR should fix the tax value modal to mach request money

dubielzyk-expensify · 2024-03-19T00:04:49Z

They look identical to me, but is there a reason why the offline indicator is in a separate spot? Let's fix that by putting it in the same spot. I prefer the "tax numpad" placement, but given the "request money numpad" is likely canonical, I'd say use that as the guide.

(left: request money, right: tax)

mountiny · 2024-03-19T10:36:36Z

@Krishna2323 Can you look into that too?

Krishna2323 · 2024-03-19T10:44:22Z

updating in a hour.

shawnborton · 2024-03-19T12:35:05Z

Good catch @dubielzyk-expensify!

Krishna2323 · 2024-03-19T14:12:25Z

@mountiny, I need sometime to investigate the other issue, it seems like the modals (pickers) doesn't take the full height.

The empty space at the bottom shouldn't be there.

Krishna2323 · 2024-03-19T14:16:34Z

@shawnborton @dubielzyk-expensify, could you please confirm which of them is expected? It seems like the tax amount form isn't the expected one since we display the offline text at the very bottom of the page on almost every page.

shawnborton · 2024-03-19T14:18:20Z

Hmm, hard to say. Perhaps the version on tax is correct because it has the correct amount of space for the safe area above the iOS home bar? Or perhaps the request money flow has that gap there for form validation?

abdulrahuman5196 · 2024-03-19T15:21:47Z

Seems we need to confirm if the screenshots added are accepted from design. Will continue review once the same is done.

Signed-off-by: Krishna Gupta <[email protected]>

Krishna2323 · 2024-03-23T06:50:30Z

Hey @mountiny, @shawnborton @dubielzyk-expensify @abdulrahuman5196, I've been diving deep into the code and stumbled upon something interesting. So, there's this component called AvatarCropModal, kind of like AmountSelectorModal, which uses modals as well. What caught my attention is how it uses style={[styles.pb0]} to fill up the whole height. And when I applied the same style to AmountSelectorModal within the ScreenWrapper, the offline message ended up aligning at the bottom, just like in RequestMoneyForm.

While checking things out, I noticed that the submit buttons/forms within modals don't have enough bottom padding in offline mode. Took a closer look and found out that most forms, including RequestMoneyForm, make use of SafeAreaConsumer to set up that padding bottom. But these modal forms, like AmountSelectorModal, TextSelectorModal, & AvatarCropModal, don't use it. So, there's this inconsistency we gotta address. Thoughts?

Online/Offline	Request Money	Tax Amount Input	Avatar Crop Modal	Text Selector Modal
Online
Offline

dubielzyk-expensify · 2024-03-24T23:41:49Z

This is awesome investigation, @Krishna2323 👏 ! I definitely think we should apply SafeArea to the ones that don't have it, but the spacing here is still awkward to me:

Here's my take on what it should ideally look like:

Which gives us with some outlines:

I'm not sure what the spacing is on our offline component at the moment though?

Keen to hear what @Expensify/design thinks before we go and change anything

shawnborton · 2024-03-25T13:34:33Z

Yeah, I like Jon's mocks above as it reduces the extra space below the green button and above the offline indicator.

dannymcclain · 2024-03-25T13:37:15Z

Same here. I like what Jon has proposed.

Krishna2323 · 2024-03-28T19:48:26Z

@mountiny, I believe the above issue will require a lot of changes and testing. Can we create a new issue for the second design bug with a regular bounty? I've already spent a lot of time on investigation.

mountiny · 2024-03-29T22:38:13Z

@Krishna2323 Alright, can you prepare only the horizontal problem fix in this PR and we will look into the rest on separate issue for $250.

mountiny · 2024-03-29T22:38:23Z

@abdulrahuman5196 can you complete the review on this one please?

Krishna2323 · 2024-03-29T22:39:56Z

@mountiny sure, Thanks!
This PR is ready for C+ review.

abdulrahuman5196 · 2024-04-01T09:00:07Z

Checking now

abdulrahuman5196 · 2024-04-01T11:52:21Z

@Krishna2323 The horizontal padding is fixed. But I am now seeing more padding between numpad and the action button and with action button and bottom. The space is high compared to request money and as well as pre-existing padding.

Screen.Recording.2024-04-01.at.5.17.09.PM.mov

shawnborton · 2024-04-01T12:32:26Z

Good catch @abdulrahuman5196 - I agree with that

mountiny · 2024-04-02T22:29:49Z

@Krishna2323 can you please address this comment?

Signed-off-by: Krishna Gupta <[email protected]>

Krishna2323 · 2024-04-02T23:22:07Z

@abdulrahuman5196 thanks for the testing. I mistakenly added vertical margin while fixing the second issue. Pushed the updated code.

mountiny · 2024-04-03T11:19:00Z

@abdulrahuman5196 can you please complete the testing and checklist on this one?

abdulrahuman5196 · 2024-04-03T17:41:42Z

Hi, will check in an hour.

abdulrahuman5196 · 2024-04-03T19:02:35Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

abdulrahuman5196

Changes looks good and works well. Reviewers checklist is also complete.

All yours. @mountiny

🎀 👀 🎀
C+ Reviewed

mountiny · 2024-04-03T21:01:20Z

@dubielzyk-expensify @shawnborton do you want to give this a final approval before I merge it?

dubielzyk-expensify

Looks good on the design end. Good work!

mountiny

thanks everyone!

OSBotify · 2024-04-08T11:08:11Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.61-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-08T13:04:49Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.61-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-10T17:22:26Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.61-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: Incorrect numpad horizontal padding on the native and mweb devices.

d2c9def

Signed-off-by: Krishna Gupta <[email protected]>

Krishna2323 requested a review from a team as a code owner March 18, 2024 22:54

melvin-bot bot requested review from abdulrahuman5196 and removed request for a team March 18, 2024 22:54

mountiny assigned Krishna2323 Mar 18, 2024

shawnborton requested a review from dubielzyk-expensify March 19, 2024 12:35

Krishna2323 added 2 commits March 22, 2024 07:44

fix: padding bottom amount selector modal.

191766b

Signed-off-by: Krishna Gupta <[email protected]>

Merge branch 'Expensify:main' into krishna2323/issue/38523

f248cb6

Krishna2323 added 2 commits April 3, 2024 04:47

Merge branch 'Expensify:main' into krishna2323/issue/38523

a93aa42

fix margin bottom.

f18cfd8

Signed-off-by: Krishna Gupta <[email protected]>

abdulrahuman5196 approved these changes Apr 3, 2024

View reviewed changes

melvin-bot bot requested a review from mountiny April 3, 2024 19:03

dubielzyk-expensify approved these changes Apr 4, 2024

View reviewed changes

mountiny approved these changes Apr 4, 2024

View reviewed changes

mountiny merged commit 3644018 into Expensify:main Apr 4, 2024
17 checks passed

github-actions bot mentioned this pull request Apr 8, 2024

Deploy Checklist: New Expensify 2024-04-08 #39807

Closed

This was referenced Apr 12, 2024

Deploy Checklist: New Expensify 2024-04-08 #39807 Derevyaa/Expensify-App#1

Closed

Deploy Checklist: New Expensify 2024-04-09 #39808 Derevyaa/Expensify-App#2

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Incorrect numpad horizontal padding on the native and mweb devices. #38542

fix: Incorrect numpad horizontal padding on the native and mweb devices. #38542

Krishna2323 commented Mar 18, 2024

melvin-bot bot commented Mar 18, 2024

mountiny commented Mar 18, 2024

dubielzyk-expensify commented Mar 19, 2024

mountiny commented Mar 19, 2024

Krishna2323 commented Mar 19, 2024

shawnborton commented Mar 19, 2024

Krishna2323 commented Mar 19, 2024

Krishna2323 commented Mar 19, 2024

shawnborton commented Mar 19, 2024

abdulrahuman5196 commented Mar 19, 2024

Krishna2323 commented Mar 23, 2024 •

edited

Loading

dubielzyk-expensify commented Mar 24, 2024

shawnborton commented Mar 25, 2024

dannymcclain commented Mar 25, 2024

Krishna2323 commented Mar 28, 2024

mountiny commented Mar 29, 2024

mountiny commented Mar 29, 2024

Krishna2323 commented Mar 29, 2024 •

edited

Loading

abdulrahuman5196 commented Apr 1, 2024

abdulrahuman5196 commented Apr 1, 2024

shawnborton commented Apr 1, 2024

mountiny commented Apr 2, 2024

Krishna2323 commented Apr 2, 2024

mountiny commented Apr 3, 2024

abdulrahuman5196 commented Apr 3, 2024

abdulrahuman5196 commented Apr 3, 2024 •

edited

Loading

abdulrahuman5196 left a comment

mountiny commented Apr 3, 2024

dubielzyk-expensify left a comment

mountiny left a comment

OSBotify commented Apr 8, 2024

OSBotify commented Apr 8, 2024

OSBotify commented Apr 10, 2024

fix: Incorrect numpad horizontal padding on the native and mweb devices. #38542

fix: Incorrect numpad horizontal padding on the native and mweb devices. #38542

Conversation

Krishna2323 commented Mar 18, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Mar 18, 2024

mountiny commented Mar 18, 2024

dubielzyk-expensify commented Mar 19, 2024

mountiny commented Mar 19, 2024

Krishna2323 commented Mar 19, 2024

shawnborton commented Mar 19, 2024

Krishna2323 commented Mar 19, 2024

Krishna2323 commented Mar 19, 2024

shawnborton commented Mar 19, 2024

abdulrahuman5196 commented Mar 19, 2024

Krishna2323 commented Mar 23, 2024 • edited Loading

dubielzyk-expensify commented Mar 24, 2024

shawnborton commented Mar 25, 2024

dannymcclain commented Mar 25, 2024

Krishna2323 commented Mar 28, 2024

mountiny commented Mar 29, 2024

mountiny commented Mar 29, 2024

Krishna2323 commented Mar 29, 2024 • edited Loading

abdulrahuman5196 commented Apr 1, 2024

abdulrahuman5196 commented Apr 1, 2024

shawnborton commented Apr 1, 2024

mountiny commented Apr 2, 2024

Krishna2323 commented Apr 2, 2024

mountiny commented Apr 3, 2024

abdulrahuman5196 commented Apr 3, 2024

abdulrahuman5196 commented Apr 3, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

mountiny commented Apr 3, 2024

dubielzyk-expensify left a comment

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Apr 8, 2024

OSBotify commented Apr 8, 2024

OSBotify commented Apr 10, 2024

Krishna2323 commented Mar 23, 2024 •

edited

Loading

Krishna2323 commented Mar 29, 2024 •

edited

Loading

abdulrahuman5196 commented Apr 3, 2024 •

edited

Loading