fix/33797: Conversation - Back arrow leads to LHN instead of group lists after page refresh in a profile screen #34464

Tony-MK · 2024-01-12T22:57:35Z

Details

Fixed Issues

$ #33797
PROPOSAL: #33797 (comment)

Tests

Go to the application and log in.
Create a group chat, if none exists.
Go to the group chat.
Open the group details > members list.
Visit a member's profile page and refresh it.
Verify that the same member's profile page is displayed like in step 5.
Tap on the back button.
Verify the app navigated back to the member's list mentioned in step 4.

Verify that no errors appear in the JS console

Offline tests

Go to the application and log in.
Create a group chat, if none exists.
Go to the group chat.
Open the group details > members list.
Visit a member's profile page and refresh it.
Verify that the same member's profile page is displayed like in step 5.
Tap on the back button.
Verify the app navigated back to the member's list mentioned in step 4.

QA Steps

Go to the application and log in.
Create a group chat, if none exists.
Go to the group chat.
Open the group details > members list.
Visit a member's profile page and refresh it.
Verify that the same member's profile page is displayed like in step 5.
Tap on the back button.
Verify the app navigated back to the member's list mentioned in step 4.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android.-.Native.mov

Android: mWeb Chrome

Android.-.mWeb.mov

iOS: Native

iOS.-.Native.mp4

iOS: mWeb Safari

iOS.-.mWeb.mp4

MacOS: Chrome / Safari

macOS.-.Chrome.mov

MacOS: Desktop

macOS.-.Desktop.mov

melvin-bot · 2024-01-14T00:23:34Z

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Tony-MK · 2024-01-14T00:34:06Z

Hey @abdulrahuman5196, after reloading the ProfilePage and navigating back to the ReportParticipantsPage, is the app expected to navigate to the ReportDetailsPagedirectly to the report instead of?

I am ready to fix it if it is an issue.

Therefore, is the navigation supposed to flow like the demonstration below?

macOS.-.Chrome.mov

abdulrahuman5196 · 2024-01-16T14:57:57Z

@Tony-MK

Hey @abdulrahuman5196, after reloading the ProfilePage and navigating back to the ReportParticipantsPage, is the app expected to navigate to the ReportDetailsPagedirectly to the report instead of?

Yes. Would be good to fix the same.

And kindly fix other ingress for the profile screen as well as pointed out by other contributors in the GH.

Merge pull request #16 from Tony-MK/dev/33797

Tony-MK · 2024-01-20T23:56:08Z

src/pages/ReportParticipantsPage.js

@@ -121,7 +122,7 @@ function ReportParticipantsPage(props) {
                                    },
                                ]}
                                onSelectRow={(option) => {
-                                    Navigation.navigate(ROUTES.PROFILE.getRoute(option.accountID));
+                                    Navigation.navigate(ROUTES.PROFILE.getRoute(option.accountID, ROUTES.REPORT_PARTICIPANTS.getRoute(props.report.reportID)));


Should I add a comment? 🤔

abdulrahuman5196 · 2024-01-22T11:23:24Z

thank you for the changes. Will go through the PR today or tomorrow morning.

abdulrahuman5196 · 2024-01-29T16:37:12Z

@Tony-MK

Hey @abdulrahuman5196, after reloading the ProfilePage and navigating back to the ReportParticipantsPage, is the app expected to navigate to the ReportDetailsPagedirectly to the report instead of?

Yes. Would be good to fix the same.

And kindly fix other ingress for the profile screen as well as pointed out by other contributors in the GH.

@Tony-MK Did you check on this? There are other ingress for the same page right? That should also be affected by this issue right?

Tony-MK · 2024-01-31T16:48:20Z

@Tony-MK Did you check on this? There are other ingresses for the same page right? That should also be affected by this issue right?

@abdulrahuman5196 Yeah, I checked on the other ingress mentioned by the other contributors and made the changes respectively.

Tony-MK · 2024-02-11T20:17:18Z

Hi, @abdulrahuman5196, just a gentle reminder.

Could we get this PR merged this week?

Thank you.

abdulrahuman5196 · 2024-02-14T09:35:19Z

Sorry for the delay. Let me take a look into this today,

abdulrahuman5196 · 2024-02-19T11:58:37Z

Reviewing now

abdulrahuman5196 · 2024-02-19T15:02:37Z

Initial testing looks good. Working on filling the checklist.

abdulrahuman5196 · 2024-02-20T07:35:02Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-02-20.at.12.21.38.PM.mp4

Android: mWeb Chrome

Screen.Recording.2024-02-20.at.12.43.38.PM.mp4

iOS: Native

Screen.Recording.2024-02-20.at.12.31.24.PM.mp4

iOS: mWeb Safari

Screen.Recording.2024-02-20.at.12.55.02.PM.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-02-20.at.12.10.36.PM.mp4

MacOS: Desktop

Screen.Recording.2024-02-20.at.12.19.38.PM.mp4

abdulrahuman5196

Changes looks good and works well. Reviewers checklist is also complete.

All yours. @Gonals

🎀 👀 🎀
C+ Reviewed

OSBotify · 2024-02-21T12:44:24Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-26T21:04:44Z

🚀 Deployed to staging by https://github.com/Gonals in version: 1.4.44-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-02-28T23:53:20Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.44-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Tony-MK added 5 commits January 2, 2024 21:31

fix: adding backTo param to ReportParticipantsPage.js

b14c40d

Merge branch 'Expensify:main' into dev/33797

2801181

Merge branch 'Expensify:main' into dev/33797

bc803bb

fix: adding backTo param to ReportParticipantsPage.js

b7045ec

fmt: prettier

e7b8513

Tony-MK marked this pull request as ready for review January 14, 2024 00:23

Tony-MK requested a review from a team as a code owner January 14, 2024 00:23

melvin-bot bot requested review from abdulrahuman5196 and removed request for a team January 14, 2024 00:23

Tony-MK added 2 commits January 18, 2024 23:55

fix: added onBackButtonPress prop

d1b5b35

fix: added onBackButtonPress prop

5ce2f5e

Merge pull request #16 from Tony-MK/dev/33797

This comment was marked as resolved.

Sign in to view

Tony-MK commented Jan 20, 2024

View reviewed changes

Tony-MK added 3 commits January 31, 2024 17:52

Merge branch 'main' into fix/33797

e3f1959

fix

f4f1d63

Merge branch 'Expensify:main' into fix/33797

bcbd4e6

Merge branch 'Expensify:main' into fix/33797

62e03ba

abdulrahuman5196 approved these changes Feb 20, 2024

View reviewed changes

melvin-bot bot requested a review from Gonals February 20, 2024 07:37

Gonals approved these changes Feb 21, 2024

View reviewed changes

Gonals merged commit 9392d81 into Expensify:main Feb 21, 2024
16 checks passed

github-actions bot mentioned this pull request Feb 26, 2024

Deploy Checklist: New Expensify 2024-02-26 #37224

Closed

CortneyOfstad mentioned this pull request Feb 28, 2024

[Payment due 3/7][$500] Conversation - Back arrow leads to LHN instead of group lists after page refresh in a profile screen #33797

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix/33797: Conversation - Back arrow leads to LHN instead of group lists after page refresh in a profile screen #34464

fix/33797: Conversation - Back arrow leads to LHN instead of group lists after page refresh in a profile screen #34464

Tony-MK commented Jan 12, 2024 •

edited

Loading

melvin-bot bot commented Jan 14, 2024

Tony-MK commented Jan 14, 2024 •

edited

Loading

abdulrahuman5196 commented Jan 16, 2024

This comment was marked as resolved.

Tony-MK Jan 20, 2024

abdulrahuman5196 commented Jan 22, 2024

abdulrahuman5196 commented Jan 29, 2024

Tony-MK commented Jan 31, 2024

Tony-MK commented Feb 11, 2024

abdulrahuman5196 commented Feb 14, 2024

abdulrahuman5196 commented Feb 19, 2024

abdulrahuman5196 commented Feb 19, 2024

abdulrahuman5196 commented Feb 20, 2024 •

edited

Loading

abdulrahuman5196 left a comment

OSBotify commented Feb 21, 2024

OSBotify commented Feb 26, 2024

OSBotify commented Feb 28, 2024

fix/33797: Conversation - Back arrow leads to LHN instead of group lists after page refresh in a profile screen #34464

fix/33797: Conversation - Back arrow leads to LHN instead of group lists after page refresh in a profile screen #34464

Conversation

Tony-MK commented Jan 12, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 14, 2024

Tony-MK commented Jan 14, 2024 • edited Loading

abdulrahuman5196 commented Jan 16, 2024

This comment was marked as resolved.

Tony-MK Jan 20, 2024

Choose a reason for hiding this comment

abdulrahuman5196 commented Jan 22, 2024

abdulrahuman5196 commented Jan 29, 2024

Tony-MK commented Jan 31, 2024

Tony-MK commented Feb 11, 2024

abdulrahuman5196 commented Feb 14, 2024

abdulrahuman5196 commented Feb 19, 2024

abdulrahuman5196 commented Feb 19, 2024

abdulrahuman5196 commented Feb 20, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

OSBotify commented Feb 21, 2024

OSBotify commented Feb 26, 2024

OSBotify commented Feb 28, 2024

Tony-MK commented Jan 12, 2024 •

edited

Loading

Tony-MK commented Jan 14, 2024 •

edited

Loading

abdulrahuman5196 commented Feb 20, 2024 •

edited

Loading