[Payment due 3/7][$500] Conversation - Back arrow leads to LHN instead of group lists after page refresh in a profile screen

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Found when executing PR: #31424

Version Number: v1.4.20-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

1. Navigate to https://staging.expensify.com/
   and log in
2. Create a group conversation
3. Type something
4. Open group details > members
5. Open any profile
6. Refresh the page
7. Tap on the back button to navigate up to the top of the screen (left side)

Expected Result:

The user should be taken to the group members page instead of LHN.

Actual Result:

After a page refresh, the back button leads the user directly to LHN.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6328884_1703904047773.mWeb_-_back_button.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0110014b7fdb5c2a05
• Upwork Job ID: 1741169400678555648
• Last Price Increase: 2023-12-30
• Automatic offers:
• abdulrahuman5196 | Reviewer | 28096418
• Tony-MK | Contributor | 28096419

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0110014b7fdb5c2a05

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[Tony-MK]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The back arrow leads to LHN instead of group lists after the page refreshes in a profile screen.

What is the root cause of that problem?

We are not setting any backTo argument in the ReportParticipantsPage

App/src/pages/ReportParticipantsPage.js

Line 124 in 8cb48e4

Navigation.navigate(ROUTES.PROFILE.getRoute(option.accountID));

Therefore, in the ProfilePage navigateBackTo will take ROUTES.HOME because it is the default when backTo param is not available.

App/src/pages/ProfilePage.js

Line 134 in 8cb48e4

const navigateBackTo = lodashGet(props.route, 'params.backTo', ROUTES.HOME);

What changes do you think we should make in order to solve the problem?

Set backTo to the optional argument in the getRoute function to the current route to the ReportParticipantsPage.

Navigation.navigate(ROUTES.PROFILE.getRoute(option.accountID, backTo = ROUTES.REPORT_PARTICIPANTS.getRoute(props.report.reportID)));

[abzokhattab]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The back navigation behavior in the participants and profile pages is not working as expected

What is the root cause of that problem?

Two issues here:

1. When a user is on the r/:id/participants page and refreshes the page and clicks the back button, they are not redirected to the report details page. Instead, the modal closes.
   This happens because the HeaderWithBackButton component doesn't have a specified onBackButtonClick behavior, leading to the default behavior of returning the user to the home page.

2. If a user is on the profile page, and refreshes the page, and then hits back, the modal unexpectedly closes. This is due to the absence of the backTo parameter when routing from the participant's page to the profile page.
   

   App/src/pages/ReportParticipantsPage.js

   Line 124 in 9208c95

   Navigation.navigate(ROUTES.PROFILE.getRoute(option.accountID));

What changes do you think we should make in order to solve the problem?

1. Modify the HeaderWithBackButton component in the ReportParticipantsPage to include the onBackButtonClick prop. This change ensures that clicking the back button redirects users to the report details page, rather than closing the modal:

       <HeaderWithBackButton
                        onBackButtonPress={() => Navigation.goBack(ROUTES.REPORT_WITH_ID_DETAILS.getRoute(props.report.reportID))}
                        title={props.translate(
                            ReportUtils.isChatRoom(props.report) ||
                                ReportUtils.isPolicyExpenseChat(props.report) ||
                                ReportUtils.isChatThread(props.report) ||
                                ReportUtils.isTaskReport(props.report) ||
                                ReportUtils.isMoneyRequestReport(props.report)
                                ? 'common.members'
                                : 'common.details',
                        )}
                    />

2. To fix the second issue we need to add a BackTo parameter in the navigation from the participant's page to the profile page. This will ensure the back navigation works as expected after a page refresh:

Navigation.navigate(ROUTES.PROFILE.getRoute(option.accountID, ROUTES.REPORT_PARTICIPANTS.getRoute(props.report.reportID)));

POC

Screen.Recording.2023-12-31.at.4.45.45.PM.mov

[abzokhattab]

FYI the issue is reproducible on MacOS: Chrome / Safari as well

[abdulrahuman5196]

Reviewing now

[abdulrahuman5196]

@Tony-MK 's proposal here #33797 (comment) looks good and works well. There are also other ingresses leading to the Profile page wherein clicking the back is leading to LHN. So @Tony-MK's PR should aim to fix other ingresses as well. Other proposals here is like a extension of the approved proposal implementing similar fix at other places as well.

🎀 👀 🎀
C+ Reviewed

[melvin-bot]

Triggered auto assignment to @Gonals, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[Christinadobrzyn]

waiting for review @Gonals when you have time can you buddy check the decision here - #33797 (comment)

[Christinadobrzyn]

I'm going to be ooo next week so adding a buddy to monitor this while I'm gone.

status - #33797 (comment)

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

📣 @abdulrahuman5196 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @Tony-MK 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

@CortneyOfstad @Gonals @Tony-MK @abdulrahuman5196 @Christinadobrzyn this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[CortneyOfstad]

@Gonals bump again on the comment #33797 (comment). Thanks!

[Gonals]

@Gonals bump again on the comment #33797 (comment). Thanks!

I already reacted and assigned the developer a few days ago! 😁

[CortneyOfstad]

Sorry about that @Gonals!

@Tony-MK any update on the PR for this? Thanks!

[Tony-MK]

@CortneyOfstad, Waiting for the PR review.

[abdulrahuman5196]

Caught up in a priority issue yesterday and today. Will try to close out the PR by tomorrow.

[CortneyOfstad]

@abdulrahuman5196 any updates on the PR? Thanks!

[CortneyOfstad]

@abdulrahuman5196 bump ^^^

[abdulrahuman5196]

@CortneyOfstad hi, we had some comments on the PR. I need to review the latest version. Will work on reviewing latest version.

[CortneyOfstad]

Sounds good @abdulrahuman5196 — thanks!

[CortneyOfstad]

@abdulrahuman5196 just checking in to see where we're at with the comments on the PR — thank you!

[abdulrahuman5196]

Hi @CortneyOfstad . Will close the pending action items in my morning.

[CortneyOfstad]

@abdulrahuman5196 Any update on the PR? If the pending action has not been completed, do you think that is something that can be done by EOD? Thanks!

[abdulrahuman5196]

@CortneyOfstad The PR has been merged

[CortneyOfstad]

Thanks @abdulrahuman5196! It shows that is has not launched to staging yet due to on-going QA, so going to keep an eye on this 👍

[CortneyOfstad]

PR went into staging 2 days ago 👍

[CortneyOfstad]

@Christinadobrzyn I am going OoO until March 11th, so going to have you keep an eye on this while I am gone if that is okay? Thanks!

[abdulrahuman5196]

The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Doesn't seem to be a regression. Seems to be a bug for sometime.

Determine if we should create a regression test for this bug.

Yes.

If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

1. Go to the application and log in.
2. Create a group chat, if none exists.
3. Go to the group chat.
4. Open the group details > members list.
5. Visit a member's profile page and refresh it.
6. Verify that the same member's profile page is displayed like in step 5.
7. Tap on the back button.
8. Verify the app navigated back to the member's list mentioned in step 4.

@Christinadobrzyn Added bz checklist. This issue should be on payment due for March 7. It seems melvin didn't update automatically

[Christinadobrzyn]

Thanks @abdulrahuman5196!

Payouts due:

Contributor: $500 @Tony-MK (paid in Upwork - https://www.upwork.com/nx/wm/offer/28096419
Contributor+: $500 @abdulrahuman5196 (paid in Upwork - https://www.upwork.com/nx/wm/offer/28096418)

Upwork job is here.

Regression test - https://github.com/Expensify/Expensify/issues/376315

I think this is good to close - let me know otherwise!