[WAVE 7] Hold Requests: Individual Money Request Page, Reason Interstitial, Banner #33897

BartoszGrajdek · 2024-01-03T19:06:12Z

Details

Fixed Issues

$ #31300

Tests

Send a money request
Open this newly created money request page
In top right corner click three dots and "Hold request" button (in a workspace people able to put the request on hold are: admins, approvers that the request has been sent to, and owner of the money request, in personal IOU all members should be able to put the request on hold)
Check if the hold reason popup was opened
Make sure that an error is being displayed when submitting a hold reason without input being filled
Fill in the hold reason input and submit
Check if the Hold Banner on top has appeared and a system message with a comment has been sent
Log into another account that is a member of the money request and check if everything is displayed properly
On personal IOU requests only the person who has put the request on hold be able to see/use the "Unhold request" button in three dots menu
On workspace money request admin, the approver that the request has been sent to and the person that put the money request on hold should be able to see/use the "Unhold request" button
Click the "Unhold request" button and check if a system message has been sent saying that the request has been unheld
Check different accounts with different permissions, and make sure that the "Hold request" & "Unhold request" buttons are being displayed and working for proper accounts (according to the description above)

Offline tests

Send a money request (this and the second step can be both done in offline and online mode to check permissions)
Open this newly created money request page
In the top right corner click three dots and the "Hold request" button (in a workspace people able to put the request on hold are: admins, approvers that the request has been sent to, and owner of the money request, in personal IOU all members should be able to put the request on hold)
Check if the hold reason popup was opened
Make sure that an error is being displayed when submitting a hold reason without input being filled
Fill in the hold reason input and submit
Check if the Hold Banner on top has appeared and a system message with a comment has been sent
On personal IOU requests only the person who has put the request on hold be able to see/use the "Unhold request" button in three dots menu
On workspace money request admin, the approver that the request has been sent to and the person that put the money request on hold should be able to see/use the "Unhold request" button
Click the "Unhold request" button and check if a system message has been sent saying that the request has been unheld
Check different accounts with different permissions, and make sure that the "Hold request" & "Unhold request" buttons are being displayed and working for proper accounts (according to the description above)

QA Steps

Send a money request
Open this newly created money request page
In top right corner click three dots and "Hold request" button (in a workspace people able to put the request on hold are: admins, approvers that the request has been sent to, and owner of the money request, in personal IOU all members should be able to put the request on hold)
Check if the hold reason popup was opened
Make sure that an error is being displayed when submitting a hold reason without input being filled
Fill in the hold reason input and submit
Check if the Hold Banner on top has appeared and a system message with a comment has been sent
Log into another account that is a member of the money request and check if everything is displayed properly
On personal IOU requests only the person who has put the request on hold be able to see/use the "Unhold request" button in three dots menu
On workspace money request admin, the approver that the request has been sent to and the person that put the money request on hold should be able to see/use the "Unhold request" button
Click the "Unhold request" button and check if a system message has been sent saying that the request has been unheld
Check different accounts with different permissions, and make sure that the "Hold request" & "Unhold request" buttons are being displayed and working for proper accounts (according to the description above)

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

chrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

safari.mov

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

src/components/MoneyRequestHeader.js

src/languages/es.ts

robertjchen · 2024-02-16T18:07:48Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

OSBotify · 2024-02-16T18:15:17Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-19T23:46:37Z

🚀 Deployed to staging by https://github.com/robertjchen in version: 1.4.43-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

MonilBhavsar · 2024-02-20T09:00:46Z

src/pages/iou/HoldReasonPage.tsx

+                        valueType="string"
+                        name="comment"
+                        defaultValue={undefined}
+                        label="Reason"


@BartoszGrajdek We missed translate here and that created #36826
Do you please mind pushing a quick fix?

MonilBhavsar · 2024-02-20T09:10:01Z

We have this another issue where composer stays focussed when Hold Request RHP is open. If anyone is interested in taking it 🙏 #36829

MonilBhavsar · 2024-02-20T09:13:45Z

src/libs/ReportUtils.ts

+            {
+                type: CONST.REPORT.MESSAGE.TYPE.TEXT,
+                style: 'normal',
+                text: `held this money request with the comment: ${comment}`,


And we're also missing translate here and at L3548 below that caused #36836.

dragnoir · 2024-02-20T09:47:22Z

We have this another issue where composer stays focussed when Hold Request RHP is open. If anyone is interested in taking it 🙏 #36829

I created a proposal #36829 (comment)

BartoszGrajdek · 2024-02-20T16:32:45Z

@MonilBhavsar I can create a PR fixing all the regressions you've mentioned, just let me know if you treat this as a regression as well - I think it is one, but I can already see some proposals there, so I don't want to cause any confusion

BartoszGrajdek · 2024-02-20T17:14:35Z

Never mind, I can see that you started working on the translation fixes in your PR. I can work on the composer bug, so I am still waiting for info on that one @MonilBhavsar

OSBotify · 2024-02-26T20:52:41Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.43-20 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

s77rt · 2024-03-06T23:21:54Z

src/pages/iou/HoldReasonPage.tsx

+                validate={validate}
+                enabledWhenOffline
+            >
+                <Text style={[styles.textHeadline, styles.mb6]}>{translate('iou.explainHold')}</Text>


We shouldn't have set styles.textHeadline style for consistency with other pages.

alitoshmatov · 2024-03-20T18:17:43Z

src/pages/iou/HoldReasonPage.tsx

+    const validate = useCallback((values: FormOnyxValues<typeof ONYXKEYS.FORMS.MONEY_REQUEST_HOLD_FORM>) => {
+        const errors: FormInputErrors<typeof ONYXKEYS.FORMS.MONEY_REQUEST_HOLD_FORM> = ValidationUtils.getFieldRequiredErrors(values, [INPUT_IDS.COMMENT]);
+
+        if (!values.comment) {
+            errors.comment = 'common.error.fieldRequired';
+        }
+
+        return errors;
+    }, []);


Quite an edge case but when user A opens hold request reason and another user B settles the request in the same time, the user A presses the hold button but gets no feedback nor reason page closes. ref: #37014

sobitneupane · 2024-05-07T10:11:48Z

#37554 issue is probably a regression from this PR.

Santhosh-Sellavel · 2024-05-16T17:39:10Z

This PR causes a regression #37536. Hold Option should not be shown while report is in Scanning state (Not sure whether it was the case before). Also minor alignment issue.

dukenv0307 · 2024-11-21T03:54:23Z

src/libs/actions/IOU.ts

+            reportActionID: createdReportAction.reportActionID,
+        },
+        {optimisticData, successData, failureData},
+    );


We should call Report.notifyNewAction(currentReportID, userAccountID); here to trigger scroll to bottom. Ref: #49959

feat: add hold implementation

eb332d6

BartoszGrajdek changed the title ~~feat: add hold implementation~~ [WAVE 7] Hold Requests: Individual Money Request Page, Reason Interstitial, Banner Jan 3, 2024

BartoszGrajdek and others added 23 commits January 8, 2024 21:45

feat: add proper permissions & style system messages

62ee823

fix: remove console log

98c83da

chore: resolve merge conflicts

7701651

fix: typecheck

ba91d6e

Permissions check

1387e34

feat: add implementation for educational interstitial

f751808

fix: add correct spanish translations

e77b28d

chore: resolve merge conflicts

97b30f4

feat: migrate HoldReasonPage to ts

6ba0c01

feat: migrate ProcessMoneyRequestHoldPage to ts

e064395

fix: correct shownHoldUseExplaination saving in onyx

c8471e8

fix: update spanish translation to correct values

97dc65d

chore: resolve merge conflicts

9d107c1

fix: init with stored value for shownHoldUseExplaination

f165f6d

chore: resolve merge conflicts

3adca53

fix: typecheck

7b77145

fix: lint

ee77f76

refactor: form types

287a7a1

fix: lint

cb658e9

fix: FormActions typecheck

aad7399

refactor: change names & make remove unnecessary conditions

6a3b8da

fix: lint

f42c90d

chore: resolve merge conflicts

cc36caa

kowczarz reviewed Feb 5, 2024

View reviewed changes

src/components/MoneyRequestHeader.js Outdated Show resolved Hide resolved

src/languages/es.ts Show resolved Hide resolved

kowczarz approved these changes Feb 5, 2024

View reviewed changes

BartoszGrajdek added 3 commits February 5, 2024 12:29

fix: add prop comment

2cb572a

chore: resolve merge conflicts

aa36c86

fix: permissions & typecheck

fb9af0c

robertjchen merged commit 7fd529b into Expensify:main Feb 16, 2024
15 checks passed

github-actions bot mentioned this pull request Feb 19, 2024

Deploy Checklist: New Expensify 2024-02-19 #36820

Closed

MonilBhavsar reviewed Feb 20, 2024

View reviewed changes

MonilBhavsar mentioned this pull request Feb 20, 2024

[$500] Hold Request - Composer is focused while RHP is open #36829

Closed

6 tasks

MonilBhavsar reviewed Feb 20, 2024

View reviewed changes

johnmlee101 mentioned this pull request Feb 20, 2024

[$500] [Held requests] System message for hold/unhold request is not gray like other system messages #36894

Closed

6 tasks

shubham1206agra mentioned this pull request Feb 20, 2024

[$500] [Held requests] - Pressing 'Enter' key doesn't serve as clicking on 'Got it' button #36825

Closed

6 tasks

flodnv mentioned this pull request Feb 21, 2024

[$250] [Held requests] Markdown isn't applied to the "Hold" message #37015

Closed

6 tasks

eucool mentioned this pull request Feb 21, 2024

[Payment due 3/6][$500] Font in "Hold Request" reason heading text is looks wrong #37039

Closed

6 tasks

s77rt reviewed Mar 6, 2024

View reviewed changes

sobitneupane mentioned this pull request Mar 18, 2024

[HOLD for payment 2024-05-06] [$250] [Held requests] Hold request link for the requestee shows "undefined" #37554

Closed

6 tasks

brandonhenry mentioned this pull request Mar 19, 2024

[hold for payment 2024-04-29] [$500] [Held requests] System message for hold request shows a comma as reason #38583

Closed

6 tasks

alitoshmatov reviewed Mar 20, 2024

View reviewed changes

Santhosh-Sellavel mentioned this pull request May 16, 2024

[HOLD for payment 2024-05-09] [$500] Hold Request - "Hold" banner is aligned to the top when there is scan request message #37536

Closed

6 tasks

rojiphil mentioned this pull request Jun 21, 2024

[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] Expenses - Hold Expense option is displayed on expenses on a closed report #42202

Closed

6 tasks

dukenv0307 reviewed Nov 21, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WAVE 7] Hold Requests: Individual Money Request Page, Reason Interstitial, Banner #33897

[WAVE 7] Hold Requests: Individual Money Request Page, Reason Interstitial, Banner #33897

BartoszGrajdek commented Jan 3, 2024 •

edited

Loading

robertjchen commented Feb 16, 2024 •

edited

Loading

OSBotify commented Feb 16, 2024

OSBotify commented Feb 19, 2024

MonilBhavsar Feb 20, 2024

MonilBhavsar commented Feb 20, 2024

MonilBhavsar Feb 20, 2024

dragnoir commented Feb 20, 2024

BartoszGrajdek commented Feb 20, 2024

BartoszGrajdek commented Feb 20, 2024

OSBotify commented Feb 26, 2024

s77rt Mar 6, 2024

alitoshmatov Mar 20, 2024

sobitneupane commented May 7, 2024 •

edited

Loading

Santhosh-Sellavel commented May 16, 2024 •

edited

Loading

dukenv0307 Nov 21, 2024

[WAVE 7] Hold Requests: Individual Money Request Page, Reason Interstitial, Banner #33897

[WAVE 7] Hold Requests: Individual Money Request Page, Reason Interstitial, Banner #33897

Conversation

BartoszGrajdek commented Jan 3, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

robertjchen commented Feb 16, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

OSBotify commented Feb 16, 2024

OSBotify commented Feb 19, 2024

MonilBhavsar Feb 20, 2024

Choose a reason for hiding this comment

MonilBhavsar commented Feb 20, 2024

MonilBhavsar Feb 20, 2024

Choose a reason for hiding this comment

dragnoir commented Feb 20, 2024

BartoszGrajdek commented Feb 20, 2024

BartoszGrajdek commented Feb 20, 2024

OSBotify commented Feb 26, 2024

s77rt Mar 6, 2024

Choose a reason for hiding this comment

alitoshmatov Mar 20, 2024

Choose a reason for hiding this comment

sobitneupane commented May 7, 2024 • edited Loading

Santhosh-Sellavel commented May 16, 2024 • edited Loading

dukenv0307 Nov 21, 2024

Choose a reason for hiding this comment

BartoszGrajdek commented Jan 3, 2024 •

edited

Loading

robertjchen commented Feb 16, 2024 •

edited

Loading

sobitneupane commented May 7, 2024 •

edited

Loading

Santhosh-Sellavel commented May 16, 2024 •

edited

Loading