[$500] Hold Request - Composer is focused while RHP is open

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.43-0
Reproducible in staging?: y
Reproducible in production?: new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

1. Sign up with a new account
2. Create an IOU with a user
3. Navigate to IOU reports details page
4. Click on three dot › Hold request > enter reason › press enter

Expected Result:

Composer shouldn't be focused

Actual Result:

Composer is focused

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6385216_1708393531198.adfafaf.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d88b69191153c8ff
• Upwork Job ID: 1759792841964003328
• Last Price Increase: 2024-02-20

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d88b69191153c8ff

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @MonilBhavsar (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[kavimuru]

We think this bug might be related to #vip-bills
cc @davidcardoza

[rushatgabhane]

is this severe enough to be deploy blocker?

[MonilBhavsar]

Agree, we can remove deploy blocker as it is not critical.
Commented on the PR it is coming from #33897 (comment)

[dragnoir]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The Git it button is not focused

What is the root cause of that problem?

On the 1st screen, "Hold Request", when the button "Hold Request" is clicked, there's an actiopn to turn back to the main request report screen, wish bring back focus to the "Write anything..' input

App/src/pages/iou/HoldReasonPage.tsx

Lines 42 to 49 in 0f372c2

	const navigateBack = () => {
	Navigation.navigate(backTo);
	};
	const onSubmit = (values: FormOnyxValues<typeof ONYXKEYS.FORMS.MONEY_REQUEST_HOLD_FORM>) => {
	IOU.putOnHold(transactionID, values.comment, reportID);
	navigateBack();
	};

The navigate back function turn to the main report screen and does not open the next "This request is on Hold" screen.

What changes do you think we should make in order to solve the problem?

When the screen "This request is on Hold" is opened we need to set the focus on the "Got it" button on src/pages/ProcessMoneyRequestHoldPage.tsx

const  submitBtn  =  useRef<View>(null);

useFocusEffect(
  React.useCallback(() => {
    if (!submitBtn.current) {
      return;
    }
    submitBtn.current.focus();
  }, []),
);

<Button
  ref={submitBtn}

POC:

20240220_101333.mp4

[dylanexpensify]

@rushatgabhane to review proposal!

[MonilBhavsar]

Should this be handled as regression as it coming from #33897 that was deployed last night?

[BartoszGrajdek]

This issue is a duplicate of #36825 - after we fix the original issue this won't be a problem anymore

[robertjchen]

Closing, to be handled in #36825