-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Update how GBR is determined for IOU/expense reports #30655
Merged
+103
−94
Merged
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
cb3f3d0
add hasOutstandingChildRequest verification
waterim ddba0ec
adjusted and removed unused parts
waterim 4fca049
clean up show GBR
waterim 7523bd6
Merge remote-tracking branch 'upstream/main' into feat-29595-Update-G…
waterim b8b6752
Merge remote-tracking branch 'upstream/main' into feat-29595-Update-G…
waterim f6b79e6
tests
waterim f4cb009
fix lint
waterim 63f6bd8
tests fix
waterim 647efb8
updated text
waterim de9e121
fix GBR display
waterim 2bb9228
Merge remote-tracking branch 'upstream/main' into feat-29595-Update-G…
waterim bfb06ae
changes
waterim a9c9ef2
remove iou ordering
waterim 0ce0891
lint fix
waterim dd4a7bb
Merge remote-tracking branch 'upstream/main' into feat-29595-Update-G…
waterim c79c9f1
Add task logic to shouldShowGBR
puneetlath c497922
Use or instead of null coalescing in getOrderedReportIDs
puneetlath 8e1ad6d
Update pinned logic for linter
puneetlath 1195a83
Add tests for various shouldShowGBR cases
puneetlath 3e938c6
Remove unneeded import
puneetlath 056b7d5
Update comment about pinned/gbr reports
puneetlath 943bc80
Rename functions to separate UI from function logic
puneetlath d6eff10
Update src/libs/ReportUtils.js
puneetlath fb9b40d
Rename shouldShowGBR to requiresAttentionFromCurrentUser in tests
puneetlath cc74887
Rename shouldShowGBR in one more place
puneetlath b35d1da
Rename report to option in requiresAttentionFromCurrentUser
puneetlath efcefdb
Account for both options and reports in unread check
puneetlath File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
Account for both options and reports in unread check
- 9.1.7-1
- 9.1.7-0
- 9.1.6-1
- 9.1.6-0
- 9.1.5-5
- 9.1.5-4
- 9.1.5-3
- 9.1.5-2
- 9.1.5-1
- 9.1.5-0
- 9.1.4-4
- 9.1.4-3
- 9.1.4-2
- 9.1.4-1
- 9.1.4-0
- 9.1.3-4
- 9.1.3-3
- 9.1.3-2
- 9.1.3-1
- 9.1.3-0
- 9.1.2-1
- 9.1.2-0
- 9.1.1-6
- 9.1.1-4
- 9.1.1-3
- 9.1.1-2
- 9.1.1-1
- 9.1.1-0
- 9.1.0-2
- 9.1.0-1
- 9.1.0-0
- 9.0.99-2
- 9.0.99-1
- 9.0.99-0
- 9.0.98-8
- 9.0.98-7
- 9.0.98-6
- 9.0.98-5
- 9.0.98-4
- 9.0.98-3
- 9.0.98-2
- 9.0.98-1
- 9.0.98-0
- 9.0.97-1
- 9.0.97-0
- 9.0.96-1
- 9.0.96-0
- 9.0.95-6
- 9.0.95-5
- 9.0.95-3
- 9.0.95-1
- 9.0.95-0
- 9.0.94-25
- 9.0.94-24
- 9.0.94-23
- 9.0.94-17
- 9.0.94-16
- 9.0.94-10
- 9.0.94-8
- 9.0.94-7
- 9.0.94-5
- 9.0.94-4
- 9.0.94-2
- 9.0.94-1
- 9.0.94-0
- 9.0.93-3
- 9.0.93-2
- 9.0.93-1
- 9.0.93-0
- 9.0.92-6
- 9.0.92-5
- 9.0.92-4
- 9.0.92-2
- 9.0.92-1
- 9.0.92-0
- 9.0.91-2
- 9.0.91-1
- 9.0.91-0
- 9.0.90-6
- 9.0.90-5
- 9.0.90-3
- 9.0.90-2
- 9.0.90-1
- 9.0.90-0
- 9.0.89-8
- 9.0.89-7
- 9.0.89-6
- 9.0.89-5
- 9.0.89-4
- 9.0.89-3
- 9.0.89-2
- 9.0.89-1
- 9.0.89-0
- 9.0.88-7
- 9.0.88-6
- 9.0.88-5
- 9.0.88-4
- 9.0.88-3
- 9.0.88-2
- 9.0.88-1
- 9.0.88-0
- 9.0.87-3
- 9.0.87-2
- 9.0.87-1
- 9.0.87-0
- 9.0.86-3
- 9.0.86-2
- 9.0.86-1
- 9.0.86-0
- 9.0.85-4
- 9.0.85-3
- 9.0.85-1
- 9.0.85-0
- 9.0.84-7
- 9.0.84-6
- 9.0.84-5
- 9.0.84-4
- 9.0.84-3
- 9.0.84-2
- 9.0.84-1
- 9.0.84-0
- 9.0.83-5
- 9.0.83-4
- 9.0.83-3
- 9.0.83-2
- 9.0.83-1
- 9.0.83-0
- 9.0.82-12
- 9.0.82-11
- 9.0.82-9
- 9.0.82-8
- 9.0.82-7
- 9.0.82-6
- 9.0.82-5
- 9.0.82-4
- 9.0.82-3
- 9.0.82-2
- 9.0.82-1
- 9.0.82-0
- 9.0.81-6
- 9.0.81-5
- 9.0.81-4
- 9.0.81-3
- 9.0.81-2
- 9.0.81-1
- 9.0.81-0
- 9.0.80-6
- 9.0.80-4
- 9.0.80-3
- 9.0.80-2
- 9.0.80-1
- 9.0.79-5
- 9.0.79-4
- 9.0.79-3
- 9.0.79-2
- 9.0.79-1
- 9.0.79-0
- 9.0.78-6
- 9.0.78-5
- 9.0.78-4
- 9.0.78-3
- 9.0.78-2
- 9.0.78-1
- 9.0.78-0
- 9.0.77-6
- 9.0.77-5
- 9.0.77-4
- 9.0.77-3
- 9.0.77-2
- 9.0.77-1
- 9.0.77-0
- 9.0.76-12
- 9.0.76-11
- 9.0.76-10
- 9.0.76-9
- 9.0.76-8
- 9.0.76-7
- 9.0.76-6
- 9.0.76-3
- 9.0.76-2
- 9.0.76-1
- 9.0.76-0
- 9.0.75-6
- 9.0.75-5
- 9.0.75-4
- 9.0.75-3
- 9.0.75-2
- 9.0.75-1
- 9.0.75-0
- 9.0.74-8
- 9.0.74-7
- 9.0.74-6
- 9.0.74-5
- 9.0.74-4
- 9.0.74-3
- 9.0.74-2
- 9.0.74-0
- 9.0.73-8
- 9.0.73-7
- 9.0.73-6
- 9.0.73-5
- 9.0.73-4
- 9.0.73-3
- 9.0.73-1
- 9.0.73-0
- 9.0.72-1
- 9.0.72-0
- 9.0.71-2
- 9.0.71-1
- 9.0.71-0
- 9.0.70-9
- 9.0.70-8
- 9.0.70-6
- 9.0.70-3
- 9.0.70-2
- 9.0.70-1
- 9.0.70-0
- 9.0.69-4
- 9.0.69-3
- 9.0.69-2
- 9.0.69-1
- 9.0.69-0
- 9.0.68-7
- 9.0.68-6
- 9.0.68-5
- 9.0.68-4
- 9.0.68-3
- 9.0.68-2
- 9.0.68-1
- 9.0.68-0
- 9.0.67-9
- 9.0.67-8
- 9.0.67-7
- 9.0.67-6
- 9.0.67-5
- 9.0.67-4
- 9.0.67-3
- 9.0.67-2
- 9.0.67-1
- 9.0.67-0
- 9.0.66-8
- 9.0.66-7
- 9.0.66-6
- 9.0.66-5
- 9.0.66-4
- 9.0.66-3
- 9.0.66-2
- 9.0.66-1
- 9.0.66-0
- 9.0.65-5
- 9.0.65-4
- 9.0.65-3
- 9.0.65-2
- 9.0.65-1
- 9.0.65-0
- 9.0.64-4
- 9.0.64-3
- 9.0.64-2
- 9.0.64-1
- 9.0.64-0
- 9.0.63-3
- 9.0.63-2
- 9.0.63-1
- 9.0.63-0
- 9.0.62-4
- 9.0.62-3
- 9.0.62-2
- 9.0.62-1
- 9.0.62-0
- 9.0.61-3
- 9.0.61-2
- 9.0.61-1
- 9.0.61-0
- 9.0.60-3
- 9.0.60-2
- 9.0.60-1
- 9.0.60-0
- 9.0.59-3
- 9.0.59-2
- 9.0.59-1
- 9.0.59-0
- 9.0.58-2
- 9.0.58-1
- 9.0.58-0
- 9.0.57-10
- 9.0.57-9
- 9.0.57-8
- 9.0.57-7
- 9.0.57-4
- 9.0.57-3
- 9.0.57-2
- 9.0.57-1
- 9.0.57-0
- 9.0.56-9
- 9.0.56-8
- 9.0.56-7
- 9.0.56-6
- 9.0.56-5
- 9.0.56-4
- 9.0.56-3
- 9.0.56-2
- 9.0.56-0
- 9.0.55-10
- 9.0.55-9
- 9.0.55-8
- 9.0.55-7
- 9.0.55-6
- 9.0.55-5
- 9.0.55-4
- 9.0.55-3
- 9.0.55-2
- 9.0.55-1
- 9.0.55-0
- 9.0.54-11
- 9.0.54-10
- 9.0.54-9
- 9.0.54-8
- 9.0.54-7
- 9.0.54-6
- 9.0.54-2
- 9.0.54-1
- 9.0.54-0
- 9.0.53-1
- 9.0.53-0
- 9.0.52-5
- 9.0.52-4
- 9.0.52-3
- 9.0.52-2
- 9.0.52-1
- 9.0.52-0
- 9.0.51-4
- 9.0.51-3
- 9.0.51-2
- 9.0.51-1
- 9.0.51-0
- 9.0.50-8
- 9.0.50-7
- 9.0.50-6
- 9.0.50-5
- 9.0.50-4
- 9.0.50-3
- 9.0.50-2
- 9.0.50-1
- 9.0.50-0
- 9.0.49-2
- 9.0.49-1
- 9.0.49-0
- 9.0.48-2
- 9.0.48-1
- 9.0.48-0
- 9.0.47-4
- 9.0.47-3
- 9.0.47-2
- 9.0.47-1
- 9.0.47-0
- 9.0.46-5
- 9.0.46-4
- 9.0.46-3
- 9.0.46-2
- 9.0.46-1
- 9.0.46-0
- 9.0.45-4
- 9.0.45-3
- 9.0.45-2
- 9.0.45-1
- 9.0.45-0
- 9.0.44-12
- 9.0.44-11
- 9.0.44-10
- 9.0.44-9
- 9.0.44-8
- 9.0.44-7
- 9.0.44-6
- 9.0.44-5
- 9.0.44-4
- 9.0.44-3
- 9.0.44-2
- 9.0.44-1
- 9.0.44-0
- 9.0.43-6
- 9.0.43-5
- 9.0.43-4
- 9.0.43-3
- 9.0.43-2
- 9.0.43-1
- 9.0.43-0
- 9.0.42-3
- 9.0.42-2
- 9.0.42-1
- 9.0.42-0
- 9.0.41-10
- 9.0.41-9
- 9.0.41-8
- 9.0.41-7
- 9.0.41-6
- 9.0.41-5
- 9.0.41-4
- 9.0.41-3
- 9.0.41-2
- 9.0.41-1
- 9.0.41-0
- 9.0.40-6
- 9.0.40-5
- 9.0.40-4
- 9.0.40-3
- 9.0.40-2
- 9.0.40-1
- 9.0.40-0
- 9.0.39-5
- 9.0.39-4
- 9.0.39-3
- 9.0.39-2
- 9.0.39-1
- 9.0.39-0
- 9.0.38-4
- 9.0.38-3
- 9.0.38-2
- 9.0.38-1
- 9.0.38-0
- 9.0.37-4
- 9.0.37-3
- 9.0.37-1
- 9.0.37-0
- 9.0.36-2
- 9.0.36-1
- 9.0.36-0
- 9.0.35-7
- 9.0.35-6
- 9.0.35-5
- 9.0.35-4
- 9.0.35-3
- 9.0.35-2
- 9.0.35-1
- 9.0.35-0
- 9.0.34-3
- 9.0.34-2
- 9.0.34-1
- 9.0.34-0
- 9.0.33-4
- 9.0.33-3
- 9.0.33-2
- 9.0.33-1
- 9.0.33-0
- 9.0.32-4
- 9.0.32-3
- 9.0.32-1
- 9.0.32-0
- 9.0.31-26
- 9.0.31-25
- 9.0.31-24
- 9.0.31-23
- 9.0.31-22
- 9.0.31-21
- 9.0.31-20
- 9.0.31-19
- 9.0.31-18
- 9.0.31-17
- 9.0.31-16
- 9.0.31-15
- 9.0.31-14
- 9.0.31-13
- 9.0.31-12
- 9.0.31-11
- 9.0.31-8
- 9.0.31-7
- 9.0.31-6
- 9.0.31-5
- 9.0.31-4
- 9.0.31-3
- 9.0.31-2
- 9.0.31-1
- 9.0.31-0
- 9.0.30-19
- 9.0.30-18
- 9.0.30-17
- 9.0.30-15
- 9.0.30-14
- 9.0.30-13
- 9.0.30-12
- 9.0.30-11
- 9.0.30-10
- 9.0.30-9
- 9.0.30-7
- 9.0.30-6
- 9.0.30-4
- 9.0.30-3
- 9.0.30-2
- 9.0.30-1
- 9.0.30-0
- 9.0.29-12
- 9.0.29-11
- 9.0.29-10
- 9.0.29-9
- 9.0.29-8
- 9.0.29-7
- 9.0.29-6
- 9.0.29-5
- 9.0.29-4
- 9.0.29-3
- 9.0.29-2
- 9.0.29-1
- 9.0.29-0
- 9.0.28-3
- 9.0.28-2
- 9.0.28-1
- 9.0.28-0
- 9.0.27-1
- 9.0.27-0
- 9.0.26-6
- 9.0.26-5
- 9.0.26-4
- 9.0.26-3
- 9.0.26-2
- 9.0.26-1
- 9.0.26-0
- 9.0.25-15
- 9.0.25-14
- 9.0.25-13
- 9.0.25-12
- 9.0.25-11
- 9.0.25-10
- 9.0.25-9
- 9.0.25-8
- 9.0.25-7
- 9.0.25-6
- 9.0.25-5
- 9.0.25-4
- 9.0.25-3
- 9.0.25-2
- 9.0.25-1
- 9.0.25-0
- 9.0.24-5
- 9.0.24-4
- 9.0.24-2
- 9.0.24-1
- 9.0.24-0
- 9.0.23-0
- 9.0.22-9
- 9.0.22-8
- 9.0.22-7
- 9.0.22-6
- 9.0.22-5
- 9.0.22-4
- 9.0.22-3
- 9.0.22-2
- 9.0.22-1
- 9.0.22-0
- 9.0.21-4
- 9.0.21-3
- 9.0.21-2
- 9.0.21-1
- 9.0.21-0
- 9.0.20-6
- 9.0.20-5
- 9.0.20-4
- 9.0.20-3
- 9.0.20-2
- 9.0.20-1
- 9.0.20-0
- 9.0.19-11
- 9.0.19-10
- 9.0.19-9
- 9.0.19-8
- 9.0.19-7
- 9.0.19-6
- 9.0.19-5
- 9.0.19-4
- 9.0.19-3
- 9.0.19-2
- 9.0.19-0
- 9.0.18-10
- 9.0.18-9
- 9.0.18-8
- 9.0.18-7
- 9.0.18-6
- 9.0.18-4
- 9.0.18-3
- 9.0.18-2
- 9.0.18-1
- 9.0.18-0
- 9.0.17-2
- 9.0.17-1
- 9.0.17-0
- 9.0.16-8
- 9.0.16-7
- 9.0.16-6
- 9.0.16-5
- 9.0.16-4
- 9.0.16-3
- 9.0.16-2
- 9.0.16-1
- 9.0.16-0
- 9.0.15-9
- 9.0.15-8
- 9.0.15-7
- 9.0.15-6
- 9.0.15-5
- 9.0.15-4
- 9.0.15-2
- 9.0.15-1
- 9.0.15-0
- 9.0.14-6
- 9.0.14-5
- 9.0.14-4
- 9.0.14-3
- 9.0.14-2
- 9.0.14-1
- 9.0.14-0
- 9.0.13-4
- 9.0.13-3
- 9.0.13-2
- 9.0.13-1
- 9.0.13-0
- 9.0.12-0
- 9.0.11-5
- 9.0.11-4
- 9.0.11-3
- 9.0.11-2
- 9.0.11-1
- 9.0.11-0
- 9.0.10-7
- 9.0.10-6
- 9.0.10-5
- 9.0.10-4
- 9.0.10-3
- 9.0.10-2
- 9.0.10-1
- 9.0.9-5
- 9.0.9-4
- 9.0.9-3
- 9.0.9-2
- 9.0.9-1
- 9.0.9-0
- 9.0.8-6
- 9.0.8-5
- 9.0.8-4
- 9.0.8-3
- 9.0.8-1
- 9.0.8-0
- 9.0.7-8
- 9.0.7-7
- 9.0.7-6
- 9.0.7-5
- 9.0.7-4
- 9.0.7-3
- 9.0.7-2
- 9.0.7-1
- 9.0.7-0
- 9.0.6-8
- 9.0.6-7
- 9.0.6-6
- 9.0.6-5
- 9.0.6-4
- 9.0.6-3
- 9.0.6-2
- 9.0.6-1
- 9.0.6-0
- 9.0.5-13
- 9.0.5-12
- 9.0.5-10
- 9.0.5-9
- 9.0.5-8
- 9.0.5-7
- 9.0.5-6
- 9.0.5-5
- 9.0.5-4
- 9.0.5-3
- 9.0.5-2
- 9.0.5-1
- 9.0.5-0
- 9.0.4-7
- 9.0.4-6
- 9.0.4-5
- 9.0.4-4
- 9.0.4-3
- 9.0.4-2
- 9.0.4-1
- 9.0.4-0
- 9.0.3-7
- 9.0.3-6
- 9.0.3-5
- 9.0.3-4
- 9.0.3-3
- 9.0.3-2
- 9.0.3-1
- 9.0.3-0
- 9.0.2-8
- 9.0.2-7
- 9.0.2-6
- 9.0.2-5
- 9.0.2-4
- 9.0.2-3
- 9.0.2-2
- 9.0.2-1
- 9.0.2-0
- 9.0.1-19
- 9.0.1-18
- 9.0.1-17
- 9.0.1-16
- 9.0.1-15
- 9.0.1-14
- 9.0.1-13
- 9.0.1-12
- 9.0.1-11
- 9.0.1-10
- 9.0.1-9
- 9.0.1-8
- 9.0.1-7
- 9.0.1-6
- 9.0.1-4
- 9.0.1-3
- 9.0.1-2
- 9.0.1-1
- 9.0.1-0
- 9.0.0-9
- 9.0.0-8
- 9.0.0-7
- 9.0.0-0
- 8.0.0-0
- 1.4.86-0
- 1.4.85-7
- 1.4.85-6
- 1.4.85-5
- 1.4.85-4
- 1.4.85-3
- 1.4.85-2
- 1.4.85-1
- 1.4.85-0
- 1.4.84-3
- 1.4.84-2
- 1.4.84-0
- 1.4.83-3
- 1.4.83-2
- 1.4.83-1
- 1.4.83-0
- 1.4.82-4
- 1.4.82-3
- 1.4.82-1
- 1.4.82-0
- 1.4.81-11
- 1.4.81-10
- 1.4.81-9
- 1.4.81-8
- 1.4.81-7
- 1.4.81-6
- 1.4.81-5
- 1.4.81-4
- 1.4.81-3
- 1.4.81-2
- 1.4.81-1
- 1.4.81-0
- 1.4.80-17
- 1.4.80-16
- 1.4.80-15
- 1.4.80-14
- 1.4.80-13
- 1.4.80-12
- 1.4.80-11
- 1.4.80-9
- 1.4.80-8
- 1.4.80-7
- 1.4.80-6
- 1.4.80-5
- 1.4.80-4
- 1.4.80-3
- 1.4.80-2
- 1.4.80-1
- 1.4.80-0
- 1.4.79-11
- 1.4.79-10
- 1.4.79-9
- 1.4.79-8
- 1.4.79-7
- 1.4.79-6
- 1.4.79-5
- 1.4.79-4
- 1.4.79-3
- 1.4.79-2
- 1.4.79-1
- 1.4.79-0
- 1.4.78-5
- 1.4.78-4
- 1.4.78-3
- 1.4.78-2
- 1.4.78-0
- 1.4.77-11
- 1.4.77-9
- 1.4.77-8
- 1.4.77-5
- 1.4.77-4
- 1.4.77-3
- 1.4.77-1
- 1.4.77-0
- 1.4.76-7
- 1.4.76-6
- 1.4.76-5
- 1.4.76-4
- 1.4.76-3
- 1.4.76-2
- 1.4.76-1
- 1.4.76-0
- 1.4.75-1
- 1.4.75-0
- 1.4.74-6
- 1.4.74-5
- 1.4.74-4
- 1.4.74-3
- 1.4.74-2
- 1.4.74-1
- 1.4.74-0
- 1.4.73-7
- 1.4.73-6
- 1.4.73-5
- 1.4.73-4
- 1.4.73-3
- 1.4.73-2
- 1.4.73-1
- 1.4.73-0
- 1.4.72-1
- 1.4.72-0
- 1.4.71-6
- 1.4.71-5
- 1.4.71-4
- 1.4.71-3
- 1.4.71-2
- 1.4.71-1
- 1.4.71-0
- 1.4.70-5
- 1.4.70-4
- 1.4.70-3
- 1.4.70-2
- 1.4.70-1
- 1.4.70-0
- 1.4.69-2
- 1.4.69-1
- 1.4.69-0
- 1.4.68-3
- 1.4.68-2
- 1.4.68-1
- 1.4.68-0
- 1.4.67-7
- 1.4.67-5
- 1.4.67-4
- 1.4.67-3
- 1.4.67-2
- 1.4.67-1
- 1.4.67-0
- 1.4.66-5
- 1.4.66-4
- 1.4.66-3
- 1.4.66-2
- 1.4.66-1
- 1.4.66-0
- 1.4.65-5
- 1.4.65-4
- 1.4.65-3
- 1.4.65-2
- 1.4.65-1
- 1.4.65-0
- 1.4.64-6
- 1.4.64-4
- 1.4.64-3
- 1.4.64-2
- 1.4.64-1
- 1.4.64-0
- 1.4.63-21
- 1.4.63-20
- 1.4.63-19
- 1.4.63-18
- 1.4.63-17
- 1.4.63-16
- 1.4.63-15
- 1.4.63-14
- 1.4.63-13
- 1.4.63-12
- 1.4.63-11
- 1.4.63-10
- 1.4.63-9
- 1.4.63-8
- 1.4.63-7
- 1.4.63-6
- 1.4.63-5
- 1.4.63-4
- 1.4.63-3
- 1.4.63-1
- 1.4.63-0
- 1.4.62-17
- 1.4.62-16
- 1.4.62-15
- 1.4.62-14
- 1.4.62-13
- 1.4.62-12
- 1.4.62-11
- 1.4.62-10
- 1.4.62-9
- 1.4.62-8
- 1.4.62-7
- 1.4.62-6
- 1.4.62-5
- 1.4.62-4
- 1.4.62-3
- 1.4.62-2
- 1.4.62-1
- 1.4.62-0
- 1.4.61-8
- 1.4.61-7
- 1.4.61-6
- 1.4.61-5
- 1.4.61-4
- 1.4.61-2
- 1.4.61-1
- 1.4.61-0
- 1.4.60-13
- 1.4.60-12
- 1.4.60-11
- 1.4.60-10
- 1.4.60-9
- 1.4.60-8
- 1.4.60-7
- 1.4.60-6
- 1.4.60-5
- 1.4.60-4
- 1.4.60-3
- 1.4.60-2
- 1.4.60-1
- 1.4.60-0
- 1.4.59-9
- 1.4.59-8
- 1.4.59-7
- 1.4.59-6
- 1.4.59-5
- 1.4.59-4
- 1.4.59-3
- 1.4.59-2
- 1.4.59-1
- 1.4.59-0
- 1.4.58-8
- 1.4.58-7
- 1.4.58-6
- 1.4.58-5
- 1.4.58-4
- 1.4.58-3
- 1.4.58-2
- 1.4.58-1
- 1.4.58-0
- 1.4.57-5
- 1.4.57-4
- 1.4.57-3
- 1.4.57-2
- 1.4.57-1
- 1.4.57-0
- 1.4.56-8
- 1.4.56-7
- 1.4.56-6
- 1.4.56-5
- 1.4.56-4
- 1.4.56-3
- 1.4.56-2
- 1.4.56-1
- 1.4.56-0
- 1.4.55-3
- 1.4.55-2
- 1.4.55-1
- 1.4.55-0
- 1.4.54-4
- 1.4.54-3
- 1.4.54-2
- 1.4.54-1
- 1.4.54-0
- 1.4.53-2
- 1.4.53-1
- 1.4.53-0
- 1.4.52-6
- 1.4.52-5
- 1.4.52-4
- 1.4.52-3
- 1.4.52-2
- 1.4.52-1
- 1.4.52-0
- 1.4.51-3
- 1.4.51-2
- 1.4.51-1
- 1.4.51-0
- 1.4.50-5
- 1.4.50-4
- 1.4.50-3
- 1.4.50-2
- 1.4.50-1
- 1.4.50-0
- 1.4.49-4
- 1.4.49-3
- 1.4.49-2
- 1.4.49-1
- 1.4.49-0
- 1.4.48-0
- 1.4.47-10
- 1.4.47-9
- 1.4.47-8
- 1.4.47-7
- 1.4.47-6
- 1.4.47-5
- 1.4.47-3
- 1.4.47-2
- 1.4.47-1
- 1.4.47-0
- 1.4.46-2
- 1.4.46-1
- 1.4.46-0
- 1.4.45-6
- 1.4.45-5
- 1.4.45-4
- 1.4.45-3
- 1.4.45-2
- 1.4.45-1
- 1.4.45-0
- 1.4.44-13
- 1.4.44-12
- 1.4.44-11
- 1.4.44-10
- 1.4.44-9
- 1.4.44-8
- 1.4.44-7
- 1.4.44-6
- 1.4.44-5
- 1.4.44-4
- 1.4.44-3
- 1.4.44-2
- 1.4.44-1
- 1.4.44-0
- 1.4.43-20
- 1.4.43-19
- 1.4.43-18
- 1.4.43-17
- 1.4.43-16
- 1.4.43-15
- 1.4.43-14
- 1.4.43-13
- 1.4.43-12
- 1.4.43-11
- 1.4.43-10
- 1.4.43-9
- 1.4.43-8
- 1.4.43-7
- 1.4.43-6
- 1.4.43-5
- 1.4.43-4
- 1.4.43-3
- 1.4.43-2
- 1.4.43-1
- 1.4.43-0
- 1.4.42-5
- 1.4.42-4
- 1.4.42-3
- 1.4.42-2
- 1.4.42-1
- 1.4.42-0
- 1.4.41-12
- 1.4.41-9
- 1.4.41-8
- 1.4.41-7
- 1.4.41-6
- 1.4.41-5
- 1.4.41-4
- 1.4.41-3
- 1.4.41-2
- 1.4.41-1
- 1.4.41-0
- 1.4.40-5
- 1.4.40-4
- 1.4.40-3
- 1.4.40-2
- 1.4.40-1
- 1.4.40-0
- 1.4.39-8
- 1.4.39-7
- 1.4.39-5
- 1.4.39-4
- 1.4.39-3
- 1.4.39-2
- 1.4.39-1
- 1.4.39-0
- 1.4.38-6
- 1.4.38-5
- 1.4.38-4
- 1.4.38-3
- 1.4.38-2
- 1.4.38-1
- 1.4.38-0
- 1.4.37-7
- 1.4.37-6
- 1.4.37-5
- 1.4.37-4
- 1.4.37-3
- 1.4.37-2
- 1.4.37-1
- 1.4.37-0
- 1.4.36-5
- 1.4.36-4
- 1.4.36-3
- 1.4.36-2
- 1.4.36-1
- 1.4.36-0
- 1.4.35-7
- 1.4.35-6
- 1.4.35-5
- 1.4.35-4
- 1.4.35-3
- 1.4.35-2
- 1.4.35-1
- 1.4.35-0
- 1.4.34-1
- 1.4.34-0
- 1.4.33-5
- 1.4.33-4
- 1.4.33-3
- 1.4.33-2
- 1.4.33-1
- 1.4.33-0
- 1.4.32-5
- 1.4.32-4
- 1.4.32-3
- 1.4.32-2
- 1.4.32-1
- 1.4.32-0
- 1.4.31-7
- 1.4.31-6
- 1.4.31-5
- 1.4.31-4
- 1.4.31-3
- 1.4.31-2
- 1.4.31-1
- 1.4.31-0
- 1.4.30-1
- 1.4.30-0
- 1.4.29-1
- 1.4.29-0
- 1.4.28-0
- 1.4.27-1
- 1.4.27-0
- 1.4.26-2
- 1.4.26-1
- 1.4.26-0
- 1.4.25-10
- 1.4.25-9
- 1.4.25-8
- 1.4.25-7
- 1.4.25-6
- 1.4.25-5
- 1.4.25-4
- 1.4.25-3
- 1.4.25-2
- 1.4.25-1
- 1.4.25-0
- 1.4.24-8
- 1.4.24-7
- 1.4.24-6
- 1.4.24-5
- 1.4.24-4
- 1.4.24-3
- 1.4.24-2
- 1.4.24-1
- 1.4.24-0
- 1.4.23-4
- 1.4.23-3
- 1.4.23-2
- 1.4.23-1
- 1.4.23-0
- 1.4.22-6
- 1.4.22-5
- 1.4.22-4
- 1.4.22-3
- 1.4.22-2
- 1.4.22-1
- 1.4.22-0
- 1.4.21-4
- 1.4.21-3
- 1.4.21-2
- 1.4.21-1
- 1.4.21-0
- 1.4.20-3
- 1.4.20-2
- 1.4.20-1
- 1.4.20-0
- 1.4.19-2
- 1.4.19-1
- 1.4.19-0
- 1.4.18-8
- 1.4.18-6
- 1.4.18-5
- 1.4.18-4
- 1.4.18-3
- 1.4.18-2
- 1.4.18-1
- 1.4.18-0
- 1.4.17-8
- 1.4.17-7
- 1.4.17-6
- 1.4.17-5
- 1.4.17-4
- 1.4.17-3
- 1.4.17-2
- 1.4.17-1
- 1.4.17-0
- 1.4.16-5
- 1.4.16-4
- 1.4.16-3
- 1.4.16-2
- 1.4.16-1
- 1.4.16-0
- 1.4.15-5
- 1.4.15-4
- 1.4.15-1
- 1.4.15-0
- 1.4.14-6
- 1.4.14-5
- 1.4.14-4
- 1.4.14-3
- 1.4.14-2
- 1.4.14-1
- 1.4.14-0
- 1.4.13-8
- 1.4.13-7
- 1.4.13-6
- 1.4.13-5
- 1.4.13-4
- 1.4.13-3
- 1.4.13-2
- 1.4.13-1
- 1.4.13-0
- 1.4.12-2
- 1.4.12-1
- 1.4.12-0
- 1.4.11-25
- 1.4.11-24
- 1.4.11-23
- 1.4.11-22
- 1.4.11-21
- 1.4.11-20
- 1.4.11-19
- 1.4.11-18
- 1.4.11-17
- 1.4.11-16
- 1.4.11-15
- 1.4.11-13
- 1.4.11-12
- 1.4.11-10
- 1.4.11-9
- 1.4.11-8
- 1.4.11-7
- 1.4.11-6
- 1.4.11-5
- 1.4.11-4
- 1.4.11-3
- 1.4.11-2
- 1.4.11-1
- 1.4.11-0
- 1.4.10-1
- 1.4.10-0
- 1.4.9-5
- 1.4.9-4
- 1.4.9-3
- 1.4.9-2
- 1.4.9-1
- 1.4.9-0
- 1.4.8-3
- 1.4.8-2
- 1.4.8-1
- 1.4.8-0
- 1.4.7-4
- 1.4.7-3
- 1.4.7-2
- 1.4.7-1
- 1.4.7-0
- 1.4.6-2
- 1.4.6-1
- 1.4.6-0
- 1.4.5-7
- 1.4.5-6
- 1.4.5-5
- 1.4.5-4
- 1.4.5-3
- 1.4.5-2
- 1.4.5-1
- 1.4.5-0
- 1.4.4-3
- 1.4.4-2
- 1.4.4-1
- 1.4.4-0
- 1.4.3-11
- 1.4.3-10
- 1.4.3-9
- 1.4.3-8
- 1.4.3-7
- 1.4.3-6
- 1.4.3-5
- 1.4.3-4
- 1.4.3-3
- 1.4.3-2
- 1.4.3-1
- 1.4.3-0
- 1.4.2-3
- 1.4.2-2
- 1.4.2-1
- 1.4.2-0
- 1.4.1-13
- 1.4.1-12
- 1.4.1-11
- 1.4.1-10
- 1.4.1-9
- 1.4.1-7
- 1.4.1-6
- 1.4.1-5
- 1.4.1-4
- 1.4.1-3
- 1.4.1-2
- 1.4.1-1
- 1.4.1-0
- 1.4.0-3
- 1.4.0-2
- 1.4.0-1
- 1.4.0-0
- 1.3.99-0
- 1.3.98-5
- 1.3.98-4
- 1.3.98-3
- 1.3.98-2
- 1.3.98-1
- 1.3.98-0
- 1.3.97-7
- 1.3.97-6
- 1.3.97-5
- 1.3.97-4
- 1.3.97-3
- 1.3.97-2
- 1.3.97-1
- 1.3.97-0
- 1.3.96-15
- 1.3.96-14
- 1.3.96-10
- 1.3.96-8
- 1.3.96-7
- 1.3.96-6
- 1.3.96-5
- 1.3.96-4
- 1.3.96-3
- 1.3.96-2
- 1.3.96-1
- 1.3.96-0
- 1.3.95-9
- 1.3.95-8
- 1.3.95-7
- 1.3.95-6
- 1.3.95-5
- 1.3.95-4
- 1.3.95-3
- 1.3.95-2
- 1.3.95-1
- 1.3.95-0
commit efcefdbec52e9a8e2a5b25e49791da2f44352e90
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine. Though - someone could possibly do something silly like add just one of the
option.lastReadTime
oroption.lastMentionedTime
. Can protect against this by only callingisUnreadWithMention()
with option whenoption.isUnreadWithMention
isundefined
.Not gonna block on that, but I think this review has kind of highlighted that the code needs reworking or something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created this follow up to try and find a way to make this better: #30668