-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix LHN is disappeared when leaving thread #28702
Conversation
@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@@ -314,7 +314,15 @@ function ReportScreen({ | |||
// optimistic case | |||
(prevOnyxReportID && prevOnyxReportID === routeReportID && !onyxReportID && prevReport.statusNum === CONST.REPORT.STATUS.OPEN && report.statusNum === CONST.REPORT.STATUS.CLOSED) | |||
) { | |||
Navigation.goBack(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eVoloshchak We added the logic to go to concierge chat in ReportScreen
recently. So I move all the navigate logic from leaveRoom
function into ReportScreen
.
Navigation.dismissModal(); | ||
if (Navigation.getTopmostReportId() === prevOnyxReportID) { | ||
Navigation.setShouldPopAllStateOnUP(); | ||
Navigation.goBack(ROUTES.HOME, false, true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally, if we only move the logic to go back to parent report as I mentioned in my proposal, on native when we go to thread report from parent, leave room, and click on back button, the parent report will appear again. So I added the logic to push Home
screen to the top first and after that navigate to the parent report.
Reviewer Checklist
Screenshots/VideosWebScreen.Recording.2023-10-04.at.12.48.50.movMobile Web - Chromescreen-20231004-131414.mp4Mobile Web - SafariScreen.Recording.2023-10-04.at.13.02.56.movDesktopScreen.Recording.2023-10-04.at.13.18.21.moviOSScreen.Recording.2023-10-04.at.12.59.41.movAndroidscreen-20231004-131320.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and tests well
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/arosiclair in version: 1.3.79-0 🚀
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀
|
Details
Fixed Issues
$ #28087
PROPOSAL: #28087 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Screencast.from.03-10-2023.16.23.05.webm
Mobile Web - Chrome
Record_2023-10-03-16-24-59.mp4
Mobile Web - Safari
Screen.Recording.2023-10-03.at.16.40.20.mov
Desktop
Screen.Recording.2023-10-03.at.16.46.53.mov
iOS
Screen.Recording.2023-10-03.at.16.37.10.mov
Android
Screencast.from.03-10-2023.16.45.44.webm