[HOLD for payment 2023-10-02] [HOLD for payment 2023-07-24] [$1000] Failed Room Termination: User Continues Chatting in Android App After Leaving Room on Web #21518

kavimuru · 2023-06-25T15:11:05Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Action Performed:

Login with User A ( mobile number) > create a workspace with user B and C
Create a room in public mode
Send the public room link or QR code to User B
Open User B in android as well as Desktop chrome and join the room across web and app using link & QR code
From User B, send messages to the room
From User B, Leave the room from web
Verify if User B can still send messages from android app

Expected Result:

When a user leaves a room on the web version, their participation in the room should be terminated across all platforms, including the Android app. They should not be able to send messages or interact within the room.

Actual Result:

After a user leaves a room on the web version, they can still send messages and participate in the chat room using the Android app. This behaviour contradicts the expected result and allows the user to continue engaging with the room despite their departure on the web.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.32-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

first.web.mp4

second.android.mp4

Recording.871.mp4

Expensify/Expensify Issue URL:
Issue reported by: @avi-shek-jha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687048129225459

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~012dc182ad93ca216b
Upwork Job ID: 1674172420971741184
Last Price Increase: 2023-07-05
Automatic offers:

wildan-m | Contributor | 27225915
avi-shek-jha | Reporter | 27225918

melvin-bot · 2023-06-25T15:11:10Z

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-06-25T15:11:13Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

johncschuster · 2023-06-28T18:28:16Z

Working on reproducing this behavior this afternoon.

melvin-bot · 2023-06-28T21:46:26Z

Job added to Upwork: https://www.upwork.com/jobs/~012dc182ad93ca216b

melvin-bot · 2023-06-28T21:46:29Z

Current assignee @johncschuster is eligible for the External assigner, not assigning anyone new.

melvin-bot · 2023-06-28T21:46:35Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

rayane-djouah · 2023-06-29T16:40:28Z

how can i create a room? I don't have this option on FAB

allroundexperts · 2023-07-01T02:36:25Z

how can i create a room? I don't have this option on FAB

@rayane-djouah You need to manually set permissions in Permission.js file.

jeet-dhandha · 2023-07-01T02:42:22Z

@allroundexperts why am i mentioned here 🤔 ?

allroundexperts · 2023-07-01T02:45:20Z

@allroundexperts why am i mentioned here 🤔 ?

Ah, Sorry, I meant to mention @rayane-djouah.

nishancx · 2023-07-02T03:14:35Z

(...redacted)

melvin-bot · 2023-07-04T20:11:46Z

@johncschuster, @allroundexperts Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

wildan-m · 2023-07-05T04:34:49Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Failed Room Termination: User Continues Chatting in Android App After Leaving Room on Web

What is the root cause of that problem?

The public room is re-opened on the second device (android) so the user will re-joined

What changes do you think we should make in order to solve the problem?

IMO, adding conditional logic to skip fetchReportIfNeeded() is not enough, since the report will still persist and the report can be reopened by another trigger e.g. onVisibilityChange

I'd propose adding an early return if the report is deleted.

We can change this code:

App/src/pages/home/ReportScreen.js

Lines 162 to 170 in 7e908b1

    
           // If you already have a report open and are deeplinking to a new report on native, 
        
           // the ReportScreen never actually unmounts and the reportID in the route also doesn't change. 
        
           // Therefore, we need to compare if the existing reportID is the same as the one in the route 
        
           // before deciding that we shouldn't call OpenReport. 
        
           const onyxReportID = this.props.report.reportID; 
        
           const routeReportID = getReportID(this.props.route); 
        
           if (onyxReportID === prevProps.report.reportID && (!onyxReportID || onyxReportID === routeReportID)) { 
        
               return; 
        
           }

To:

        const onyxReportID = this.props.report.reportID;
        const prevOnyxReportID = prevProps.report.reportID;
        const routeReportID = getReportID(this.props.route);

        // navigate to concierge when the room removed from another device (e.g. user leaving a room)
        // the report will not really null when removed, it will have defaultProps properties and values
        if (prevOnyxReportID && prevOnyxReportID === routeReportID && !onyxReportID && _.isEqual(this.props.report, defaultProps.report)) {
            Navigation.goBack();
            Report.navigateToConciergeChat();
            // isReportRemoved will prevent <FullPageNotFoundView> showing when navigating
            this.setState({isReportRemoved: true});
            return;
        }

To determine if a report is removed because props reportID is possible to null when transitioning to a new report or not readily stored in Onyx.

To prevent the page not found page shown before navigation, we can declare the new state:

            isReportRemoved: false,

and modify FullPageNotFoundView condition to

                    <FullPageNotFoundView
                        shouldShow={(!this.props.report.reportID && !this.props.report.isLoadingReportActions && !isLoading && !this.state.isReportRemoved) || shouldHideReport}

Result - return only

Recording.28.mp4

Result - navigateToConcierge + return

navigate.to.concierge.webm

What alternative solutions did you explore? (Optional)

N/A

nishancx · 2023-07-05T14:15:27Z

@wildan-m I noticed that with both our proposals, when Device A leaves room and then Device B refreshes the page, the user rejoins the room.

melvin-bot · 2023-07-05T16:00:34Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

johncschuster · 2023-07-05T18:45:16Z

@allroundexperts can you take a look at the above proposals when you get a moment? Do we need to keep looking?

wildan-m · 2023-07-05T23:21:12Z

@nishancx, how can we refresh the page in the native app?

luacmartins · 2023-10-06T15:56:35Z

I wasn't aware of that discussion, but I just caught up, thanks for the link. I agree that it's not a regression and that we should close out this issue once payment is issued. I also agree that we should create a new issue for the navigation requirement change. @wildan-m wanna report the issue and I can create it?

wildan-m · 2023-10-06T16:02:58Z

@luacmartins sure, I'll post it to expensify-bugs, please wait

wildan-m · 2023-10-06T16:28:00Z

@luacmartins posted here.

wildan-m · 2023-10-06T16:45:42Z

@luacmartins good news! the requirement changes have been resolved by this PR.

luacmartins · 2023-10-06T16:53:26Z

Cool, seems like we're all set then and just need to process payment for this issue

wildan-m · 2023-10-09T01:16:39Z

👍

wildan-m · 2023-10-10T09:20:23Z

Bump @luacmartins, @johncschuster

luacmartins · 2023-10-10T16:43:36Z

@johncschuster could you please help with payment?

wildan-m · 2023-10-12T05:46:56Z

Bump @johncschuster, @luacmartins

melvin-bot · 2023-10-16T18:15:31Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

melvin-bot · 2023-10-16T18:15:57Z

📣 @wildan-m 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

melvin-bot · 2023-10-16T18:16:01Z

📣 @avi-shek-jha 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

johncschuster · 2023-10-16T18:19:48Z

Ok, the job seems to not want to open back up. I'm going to create an issue just for payment for this. Standby.

johncschuster · 2023-10-16T18:24:00Z

@wildan-m can you please go to the linked issue above and comment on it so I can assign it to you? That should get the job offer sent to you correctly.

avi-shek-jha · 2023-10-16T19:32:03Z

Hello, as a reporter, I only received an offer for 50 dollars. I am aware of the new policies. But, I reported this on June 17 and the issue was created on June 25 almost 2 months before the new policies took place. Can anyone please send me the offer link with corrected amount of 250 USD?

johncschuster · 2023-10-18T18:26:59Z

Hi @avi-shek-jha, thanks for calling that out. I will correct that in Upwork.

johncschuster · 2023-10-18T18:37:38Z

@avi-shek-jha, I've corrected that in Upwork. Can you please accept the offer? I'll take care of payment once you've done that.

avi-shek-jha · 2023-10-18T19:49:39Z

Thank you John. I appreciate it. I have accepted the offer.

johncschuster · 2023-10-18T20:37:23Z

Ok everyone! I'm handling payments on this issue. I'm going to close this one out.

kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jun 25, 2023

melvin-bot bot assigned johncschuster Jun 25, 2023

melvin-bot bot added the Overdue label Jun 27, 2023

melvin-bot bot removed the Overdue label Jun 28, 2023

johncschuster added the External Added to denote the issue can be worked on by a contributor label Jun 28, 2023

melvin-bot bot changed the title ~~Failed Room Termination: User Continues Chatting in Android App After Leaving Room on Web~~ [$1000] Failed Room Termination: User Continues Chatting in Android App After Leaving Room on Web Jun 28, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 28, 2023

melvin-bot bot assigned allroundexperts Jun 28, 2023

melvin-bot bot added the Overdue label Jun 30, 2023

melvin-bot bot removed the Overdue label Jul 1, 2023

melvin-bot bot added the Overdue label Jul 3, 2023

melvin-bot bot removed the Overdue label Jul 5, 2023

johncschuster added the External Added to denote the issue can be worked on by a contributor label Oct 16, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 16, 2023

melvin-bot bot assigned aimane-chnaif Oct 16, 2023

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Oct 16, 2023

johncschuster assigned wildan-m and unassigned wildan-m and aimane-chnaif Oct 16, 2023

melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 16, 2023

johncschuster mentioned this issue Oct 16, 2023

[$1000] Payment issue for #21518 #29702

Closed

johncschuster closed this as completed Oct 18, 2023

[HOLD for payment 2023-10-02] [HOLD for payment 2023-07-24] [$1000] Failed Room Termination: User Continues Chatting in Android App After Leaving Room on Web #21518

[HOLD for payment 2023-10-02] [HOLD for payment 2023-07-24] [$1000] Failed Room Termination: User Continues Chatting in Android App After Leaving Room on Web #21518

Comments

kavimuru commented Jun 25, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

melvin-bot bot commented Jun 25, 2023

melvin-bot bot commented Jun 25, 2023 • edited by johncschuster Loading

Bug0 Triage Checklist (Main S/O)

johncschuster commented Jun 28, 2023

melvin-bot bot commented Jun 28, 2023

melvin-bot bot commented Jun 28, 2023

melvin-bot bot commented Jun 28, 2023

rayane-djouah commented Jun 29, 2023 • edited Loading

allroundexperts commented Jul 1, 2023 • edited Loading

jeet-dhandha commented Jul 1, 2023

allroundexperts commented Jul 1, 2023

nishancx commented Jul 2, 2023 • edited Loading

melvin-bot bot commented Jul 4, 2023

wildan-m commented Jul 5, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

nishancx commented Jul 5, 2023

melvin-bot bot commented Jul 5, 2023

johncschuster commented Jul 5, 2023

wildan-m commented Jul 5, 2023

luacmartins commented Oct 6, 2023 • edited Loading

wildan-m commented Oct 6, 2023

wildan-m commented Oct 6, 2023

wildan-m commented Oct 6, 2023

luacmartins commented Oct 6, 2023

wildan-m commented Oct 9, 2023

wildan-m commented Oct 10, 2023

luacmartins commented Oct 10, 2023

wildan-m commented Oct 12, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

johncschuster commented Oct 16, 2023

johncschuster commented Oct 16, 2023

avi-shek-jha commented Oct 16, 2023

johncschuster commented Oct 18, 2023

johncschuster commented Oct 18, 2023

avi-shek-jha commented Oct 18, 2023

johncschuster commented Oct 18, 2023

kavimuru commented Jun 25, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Jun 25, 2023 •

edited by johncschuster

Loading

rayane-djouah commented Jun 29, 2023 •

edited

Loading

allroundexperts commented Jul 1, 2023 •

edited

Loading

nishancx commented Jul 2, 2023 •

edited

Loading

wildan-m commented Jul 5, 2023 •

edited

Loading

luacmartins commented Oct 6, 2023 •

edited

Loading