fix: long press on emoji doesn't show highlight in mobile #26931

dummy-1111 · 2023-09-07T08:09:33Z

Details

Fix not to show highlight when long pressing emojis in android chrome

Fixed Issues

$ #24654
PROPOSAL: #24654 (comment)

Tests

Open ND and log in with any account
Navigate to any chat and open EmojiPicker
Long-press any emoji
Verify that emoji status doesn't change to highlight state

Verify that no errors appear in the JS console

Offline tests

Open ND and log in with any account
Navigate to any chat and open EmojiPicker
Long-press any emoji
Verify that emoji status doesn't change to highlight state

QA Steps

Open ND and log in with any account
Navigate to any chat and open EmojiPicker
Long-press any emoji
Verify that emoji status doesn't change to highlight state

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

24654_mac_chrome.mp4

Mobile Web - Chrome

24654_android_chrome.mp4

Mobile Web - Safari

24654_ios_safari.mp4

Desktop

24654_mac_desktop.mp4

iOS

24654_ios_native.mp4

Android

24654_android_native.mp4

melvin-bot · 2023-09-07T08:33:48Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allroundexperts · 2023-09-07T23:09:17Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-09-12.at.2.51.07.AM.mov

Mobile Web - Chrome

Screen.Recording.2023-09-12.at.2.48.00.AM.mov

Mobile Web - Safari

Screen.Recording.2023-09-12.at.2.39.49.AM.mov

Desktop

Screen.Recording.2023-09-12.at.3.01.22.AM.mov

iOS

Screen.Recording.2023-09-12.at.2.41.26.AM.mov

Android

Screen.Recording.2023-09-12.at.2.45.42.AM.mov

dummy-1111 · 2023-09-08T16:48:08Z

@allroundexperts
Please take a look

src/styles/styles.js

src/components/Pressable/GenericPressable/BaseGenericPressable.js

allroundexperts · 2023-09-10T19:37:21Z

@s-alves10 I'm still having the following issue on iOS safari some times.

Screen.Recording.2023-09-11.at.12.32.49.AM.mov

dummy-1111 · 2023-09-11T02:26:29Z

@allroundexperts

When releasing the emoji item quickly, onFocus event occurs after the onPressOut event is called. This is the root cause of the above issue.

In order to prevent this, we need to set the long press handler to () => {} only on android chrome

dummy-1111 · 2023-09-11T02:44:07Z

@allroundexperts

Please take a look again

TTaro · 2023-09-11T08:54:05Z

@allroundexperts as explained here #24654 (comment) I think that you need to fix this in onHoverOut because we are in mobile

allroundexperts · 2023-09-11T08:58:43Z

@TTaro Thanks for letting us know!

@s-alves10 Can you please check the comment from @TTaro?

dummy-1111 · 2023-09-11T09:14:12Z

@TTaro

I don't understand what you're saying. My solution includes all the fix you mentioned already. Can you be more specific?

cc @allroundexperts

allroundexperts · 2023-09-11T10:33:17Z

@s-alves10 The suggestion is to use onHoverOut instead of onPressOut.

dummy-1111 · 2023-09-11T10:51:09Z

@allroundexperts

What do you think? onPressOut makes more sense to me for mobile devices than onHoverOut

TTaro · 2023-09-11T12:07:56Z

@s-alves10 @allroundexperts I agree makes more sense, even if you review the doc https://necolas.github.io/react-native-web/docs/pressable/ but from my previous tests with onHoverOut it was working fine.

I tested with android simulated, and maybe tha is the reason why was working, maybe the key is to test in a real device ? Sorry I dont want to add more noise to this defect. Hope this helps.

dummy-1111 · 2023-09-11T13:49:24Z

@allroundexperts

Please let me know your thought on #26931 (comment)

allroundexperts · 2023-09-11T13:50:26Z

@allroundexperts

Please let me know your thought on #26931 (comment)

If your fix solves the issue, then I think there's no need to change it to onHoverOut.

dummy-1111 · 2023-09-11T13:53:50Z

Please take a look at the PR again, then
Thanks

allroundexperts

This is testing well!

dummy-1111 · 2023-09-11T23:35:27Z

@bondydaa

Please take a look at this PR

OSBotify · 2023-09-15T21:14:51Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-09-18T10:39:57Z

🚀 Deployed to staging by https://github.com/bondydaa in version: 1.3.71-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-09-20T08:12:27Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.71-12 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

parasharrajat · 2023-10-29T04:56:15Z

src/components/Pressable/GenericPressable/BaseGenericPressable.js

@@ -127,13 +128,15 @@ const GenericPressable = forwardRef((props, ref) => {
        return KeyboardShortcut.subscribe(shortcutKey, onPressHandler, descriptionKey, modifiers, true, false, 0, false);
    }, [keyboardShortcut, onPressHandler]);

+    const defaultLongPressHandler = Browser.isMobileChrome() ? () => {} : undefined;


Passing a default handler prevents browser native events which caused #28915

fix: long press on emoji doesn't show highlight in mobile

2b11ff9

dummy-1111 marked this pull request as ready for review September 7, 2023 08:33

dummy-1111 requested a review from a team as a code owner September 7, 2023 08:33

melvin-bot bot requested review from allroundexperts and removed request for a team September 7, 2023 08:33

dummy-1111 mentioned this pull request Sep 7, 2023

[HOLD for payment 2023-09-27] [$1000] Chat - Hover state is shown on long hold of an emoji on emoji picker pop over #24654

Closed

6 tasks

fix: disable selection by long-press

a0025c3

bernhardoj mentioned this pull request Sep 8, 2023

[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$2000] Unable to change the currency after double-clicking on the current currency #22497

Closed

6 tasks

allroundexperts reviewed Sep 10, 2023

View reviewed changes

src/styles/styles.js Show resolved Hide resolved

allroundexperts reviewed Sep 10, 2023

View reviewed changes

src/components/Pressable/GenericPressable/BaseGenericPressable.js Outdated Show resolved Hide resolved

fix: default long-press handler only for mobile browsers

4ddeff9

fix: change default long-press handler only on mobile chrome

4370f6f

allroundexperts approved these changes Sep 11, 2023

View reviewed changes

melvin-bot bot requested a review from bondydaa September 11, 2023 22:17

bondydaa approved these changes Sep 15, 2023

View reviewed changes

bondydaa merged commit 76c1559 into Expensify:main Sep 15, 2023

OSBotify mentioned this pull request Sep 18, 2023

Deploy Checklist: New Expensify 2023-09-18 #27654

Closed

91 tasks

abdel-h66 mentioned this pull request Sep 23, 2023

[$500] mWeb – Attachment - Unable to open image in new tab. #27896

Closed

6 tasks

bernhardoj mentioned this pull request Oct 6, 2023

[HOLD for payment 2023-10-25] [$500] mWeb / Chrome – Paste option not working in Request money BNP #28915

Closed

6 tasks

parasharrajat reviewed Oct 29, 2023

View reviewed changes

dummy-1111 deleted the fix/issue-24654 branch December 21, 2023 07:39

c3024 mentioned this pull request Oct 2, 2024

mWeb - scan - When long pressing a section in mweb, the selection disappears within seconds #50011

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: long press on emoji doesn't show highlight in mobile #26931

fix: long press on emoji doesn't show highlight in mobile #26931

dummy-1111 commented Sep 7, 2023

melvin-bot bot commented Sep 7, 2023

allroundexperts commented Sep 7, 2023 •

edited

Loading

dummy-1111 commented Sep 8, 2023

allroundexperts commented Sep 10, 2023

dummy-1111 commented Sep 11, 2023

dummy-1111 commented Sep 11, 2023

TTaro commented Sep 11, 2023

allroundexperts commented Sep 11, 2023

dummy-1111 commented Sep 11, 2023 •

edited

Loading

allroundexperts commented Sep 11, 2023

dummy-1111 commented Sep 11, 2023

TTaro commented Sep 11, 2023

dummy-1111 commented Sep 11, 2023

allroundexperts commented Sep 11, 2023

dummy-1111 commented Sep 11, 2023

allroundexperts left a comment

dummy-1111 commented Sep 11, 2023

OSBotify commented Sep 15, 2023

OSBotify commented Sep 18, 2023

OSBotify commented Sep 20, 2023

parasharrajat Oct 29, 2023

fix: long press on emoji doesn't show highlight in mobile #26931

fix: long press on emoji doesn't show highlight in mobile #26931

Conversation

dummy-1111 commented Sep 7, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 7, 2023

allroundexperts commented Sep 7, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

dummy-1111 commented Sep 8, 2023

allroundexperts commented Sep 10, 2023

dummy-1111 commented Sep 11, 2023

dummy-1111 commented Sep 11, 2023

TTaro commented Sep 11, 2023

allroundexperts commented Sep 11, 2023

dummy-1111 commented Sep 11, 2023 • edited Loading

allroundexperts commented Sep 11, 2023

dummy-1111 commented Sep 11, 2023

TTaro commented Sep 11, 2023

dummy-1111 commented Sep 11, 2023

allroundexperts commented Sep 11, 2023

dummy-1111 commented Sep 11, 2023

allroundexperts left a comment

Choose a reason for hiding this comment

dummy-1111 commented Sep 11, 2023

OSBotify commented Sep 15, 2023

OSBotify commented Sep 18, 2023

OSBotify commented Sep 20, 2023

parasharrajat Oct 29, 2023

Choose a reason for hiding this comment

allroundexperts commented Sep 7, 2023 •

edited

Loading

dummy-1111 commented Sep 11, 2023 •

edited

Loading