[HOLD for payment 2023-09-27] [$1000] Chat - Hover state is shown on long hold of an emoji on emoji picker pop over

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open ND on mWeb
2. Open any chat
3. Click on the emoji picker
4. Hold down on one of the emojis

Expected Result:

Hover state should not be visible on mWeb for long hold

Actual Result:

Hover state is being shown for long hold

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.54.11

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen_Recording_20230807_212804_Chrome.mp4

Record_2023-08-16-23-01-44.mp4

Expensify/Expensify Issue URL:

Issue reported by: @Nathan-Mulugeta

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691432854348509

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01efcb634d262da535
• Upwork Job ID: 1693672410355466240
• Last Price Increase: 2023-08-21
• Automatic offers:
• s-alves10 | Contributor | 26535914
• Nathan-Mulugeta | Reporter | 26535915

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Holding down the emoji item for a long time will leave a highlighted effect on the emoji.

What is the root cause of that problem?

When we hold a focusable element, it will trigger onFocus callback. I tested this on a plain HTML file and this behavior is there. onFocus will set the highlight of the focused emoji

App/src/components/EmojiPicker/EmojiPickerMenu/index.js

Line 510 in 0bdf183

onFocus={() => this.setState({highlightedIndex: index})}

To remove the focus, we can click/press anywhere and it will trigger onBlur to reset the highlighted index.

App/src/components/EmojiPicker/EmojiPickerMenu/index.js

Lines 511 to 517 in 0bdf183

	onBlur={() =>
	this.setState((prevState) => ({
	// Only clear the highlighted index if the highlighted index is the same,
	// meaning that the focus changed to an element that is not an emoji item.
	highlightedIndex: prevState.highlightedIndex === index ? -1 : prevState.highlightedIndex,
	}))
	}

On the web, even though we can focus the emoji by holding it down too, this didn't happen because we have onHoverOut that will also reset the highlighted index.

App/src/components/EmojiPicker/EmojiPickerMenu/index.js

Lines 503 to 508 in 0bdf183

	onHoverOut={() => {
	if (this.state.arePointerEventsDisabled) {
	return;
	}
	this.setState({highlightedIndex: -1});
	}}

What changes do you think we should make in order to solve the problem?

To also solve this issue on mWeb, we can rely on onPressOut to reset the highlighted index.

onPressOut={this.props.onHoverOut}

I think we can think of onPressOut as the equivalent of onHoverOut in this case. Technically the emoji item is not blurred, so I think calling onBlur is not correct

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01efcb634d262da535

[melvin-bot]

Current assignee @zanyrenney is eligible for the External assigner, not assigning anyone new.

[zanyrenney]

Oops, sorry I somehow missed this but have triaged now!

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[dummy-1111]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Hover state appears when long pressing an emoji in emoji picker popover

What is the root cause of that problem?

Whenever onLongPress event occurs, a short haptic feedback event also occurs. : This is a known issue in react-native-web.

And we have style of an emoji

App/src/components/EmojiPicker/EmojiPickerMenuItem/index.js

Lines 74 to 79 in 3892292

	style={({pressed}) => [
	Browser.isMobile() && StyleUtils.getButtonBackgroundColorStyle(getButtonState(false, pressed)),
	this.props.isHighlighted && this.props.isUsingKeyboardMovement ? styles.emojiItemKeyboardHighlighted : {},
	this.props.isHighlighted && !this.props.isUsingKeyboardMovement ? styles.emojiItemHighlighted : {},
	styles.emojiItem,
	]}

Because of the above known issue, when long pressing a Pressable, pressed value becomes false shortly. And also onFocus is called when we long press a Pressable(maybe related to context menu action in mWeb. Please refer here), so the selected item is highlighted.

That's why when we long-pressing an emoji, hover state is shown.

What changes do you think we should make in order to solve the problem?

We have a workaround for this issue as described here

To apply this, replace the below line

App/src/components/Pressable/GenericPressable/BaseGenericPressable.js

Line 136 in 494847a

onLongPress={!isDisabled && onLongPress ? onLongPressHandler : undefined}

with

        onLongPress={!isDisabled && onLongPress ? onLongPressHandler : () => {}}

And to prioritize the pressing effect, move this line

App/src/components/EmojiPicker/EmojiPickerMenuItem/index.js

Line 75 in 494847a

Browser.isMobile() && StyleUtils.getButtonBackgroundColorStyle(getButtonState(false, pressed)),

below this line

App/src/components/EmojiPicker/EmojiPickerMenuItem/index.js

Line 77 in 494847a

this.props.isHighlighted && !this.props.isUsingKeyboardMovement ? styles.emojiItemHighlighted : {},

This works as expected

Note: We might need to add onPressOut to set highlight index to -1 if we want to remove hover effect after press out

Result

24654.mp4

What alternative solutions did you explore? (Optional)

[TTaro]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When you press and hold, the icon below becomes highlighted.

What is the root cause of that problem?

We have logic to avoid issues when scrolling about onHoverOut we need to add same logic for mobile with onPressOut

What changes do you think we should make in order to solve the problem?

We need to add the logic of onHoverOut to onPressOut , set highlightedIndex=-1 when arePointersEventsDisabled is false.
In EmogiPickerMenuItem we need to configure onPressOut as any other needed event, onPressOut= this.props.onPressOut to have this event available.

What alternative solutions did you explore? (Optional)

[melvin-bot]

@allroundexperts, @zanyrenney Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[zanyrenney]

hey @allroundexperts what do you think of the proposal above from @TTaro ?

[dummy-1111]

I think the expected behavior is that pressing effect should last until press out.
@allroundexperts What do you think?

[allroundexperts]

@bernhardoj With your solution, it seems like the hover would be lost on long press. See the video below:

Screen.Recording.2023-08-28.at.12.50.55.AM.mov

I think this is not consistent with how it is behaving on desktop web. On desktop web, following happens:

Screen.Recording.2023-08-28.at.12.53.01.AM.mov

@s-alves10 your proposal makes the behaviour more consistent and as such, I think your approach is better.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @bondydaa, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[bernhardoj]

@allroundexperts that is consistent with all buttons on Android mWeb. My solution fixes the issue we have here and @s-alves10 extends mine by also including the fix to this issue which happens on all buttons and I think is out-of-scope of this issue. If we still going forward with the extended fix, then I think it would be fair if I get compensation for this issue too. What do you think?

cc: @bondydaa

[allroundexperts]

@bernhardoj I think we can split up the compensation. Collaborative work is always better!

@bondydaa can make the final call though.

[dummy-1111]

@bernhardoj

I understood that the expected behavior is to keep the press state until pressing out and this is totally different than your solution. I was not adding something to your solution.

Anyway, let's wait for @bondydaa

[TTaro]

@allroundexperts please can you review my proposal ?? Many thanks !!

[dummy-1111]

@allroundexperts

PR is ready for review

[dummy-1111]

@bondydaa

Please take a look at the PR

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @s-alves10 got assigned: 2023-09-06 22:53:27 Z
• when the PR got merged: 2023-09-15 21:09:56 UTC
• days elapsed: 6

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.71-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: long press on emoji doesn't show highlight in mobile #26931

If no regressions arise, payment will be issued on 2023-09-27. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @allroundexperts does not require payment (Eligible for Manual Requests)
• @s-alves10 requires payment offer (Contributor)
• @Nathan-Mulugeta requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts] Determine if we should create a regression test for this bug.
• [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[zanyrenney]

payment summary - (no urgency bonuses applied)
@allroundexperts does not require payment (Eligible for Manual Requests) payment due is $1000 (no urgency bonus)
@s-alves10 requires payment offer (Contributor) - $1000 [PAID]
@Nathan-Mulugeta requires payment offer (Reporter) - $250 [PAID]

[zanyrenney]

@s-alves10 have invited you to the job. please accept so we can close this out.

[dummy-1111]

@zanyrenney

Accepted

[zanyrenney]

All that can be paid, paid. @allroundexperts please request in ND.

[allroundexperts]

Requested!

[JmillsExpensify]

Need a payment amount in the BZ summary for @allroundexperts before I can issue payment.

[allroundexperts]

@zanyrenney Can you please look into this? 🙇

[JmillsExpensify]

Updated, thank you!

[JmillsExpensify]

$1,000 payment approved for @allroundexperts based on BZ summary.