Add “Reveal details” for the digital card #26778

JKobrynski · 2023-09-05T13:51:29Z

Details

Fixed Issues

$ #22874
PROPOSAL: N/A

Tests

Add the following code to InitialSettingsPage.js:

useEffect(() => {
    window.Onyx.merge(`cardList`, {
        'virtual': {
            cardID: 234523452345,
            state: 3,
            bank: 'Expensify',
            availableSpend:10000,
    domainName: 'Expensify',
    lastFourPAN: '',
    isVirtual: true,
    cardholderFirstName: "Test",
    cardholderLastName: "Test",
        }, 'physical': {
            cardID: 234523452345,
            state: 3,
            bank: '1000',
            availableSpend:10000,
    domainName: 'Expensify',
    lastFourPAN: '2345',
    isVirtual: false,
        },
    });

    Navigation.navigate(ROUTES.SETTINGS_WALLET_DOMAINCARDS.getRoute('expensify'));
}, []);

Open the settings, you should be automatically navigated to the cards page
Click the "Reveal Details" button
You should see (mocked for now) details of the card

Verify that no errors appear in the JS console

Offline tests

QA Steps

As of now it's not possible to test it without editing the code.

PR Author Checklist

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

chrome.webm

Mobile Web - Safari

safari.mp4

Desktop

desktop.mov

iOS

ios.mp4

Android

android.webm

src/components/menuItemPropTypes.js

src/components/MenuItem.js

src/languages/es.js

rezkiy37

Left comments.

src/pages/settings/Wallet/ExpensifyCardPage.js

rezkiy37

Left a few comments.

src/pages/settings/Wallet/WalletPage/CardDetails.js

src/components/MenuItem.js

melvin-bot · 2023-09-26T13:56:54Z

@jasperhuangg Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/pages/settings/Wallet/WalletPage/CardDetails.js

src/languages/en.ts

src/pages/settings/Wallet/ExpensifyCardPage.js

grgia · 2023-09-29T11:24:28Z

Assigning @eVoloshchak for C+ review from issue

grgia · 2023-10-02T09:23:56Z

@eVoloshchak are you able to prioritize this PR?

eVoloshchak · 2023-10-02T09:14:59Z

src/pages/settings/Wallet/WalletPage/CardDetails.js

+    usePrivatePersonalDetails();
+    const {translate} = useLocalize();
+
+    const handleCopyToClipboard = () => {


We can use CopyTextToClipboard instead
It will also add a hover effect to the copy icon and a tooltip, so it's consistent with the rest of the app

Screen.Recording.2023-10-02.at.11.13.49.mov

Unfortunately it won't work for this UI, because CopyTextToClipboard displays a text component that we don't need as it's already displayed by MenuItemWithTopDescription. However, I found out that this would work:

<MenuItemWithTopDescription ... shouldShowRightComponent rightComponent={ <PressableWithDelayToggle tooltipText={translate('reportActionContextMenu.copyToClipboard')} tooltipTextChecked={translate('reportActionContextMenu.copied')} icon={Expensicons.Copy} onPress={handleCopyToClipboard} /> } ... />

So basically, a part of CopyTextToClipboard that displays the icon, what do you think?

Awesome, let's do that instead!

eVoloshchak · 2023-10-02T09:23:11Z

src/libs/CardUtils.ts

+
+    const formatted = addressItems.join(', ');
+
+    // Remove the last comma of the address


Correct me if I'm wrong, but I don't think this is needed. join() doesn't add a separator string after the last element, I don't see a difference when commenting out this line

I am not sure I understand, you are saying we don't need join()? If we remove it, it will be an array

I changed the implementation a lot, so I guess that comment might be outdated

eVoloshchak · 2023-10-02T09:29:35Z

src/libs/CardUtils.ts

+function getFormattedAddress(privatePersonalDetails: OnyxTypes.PrivatePersonalDetails): string | null {
+    const {address} = privatePersonalDetails;
+    const [street1, street2] = (address?.street ?? '').split('\n');
+    const addressItems = [street1, street2, address?.city, address?.state, address?.zip, address?.country];


If we don't have Address Line 2 populated, it just shows a blank space instead of filtering it out

Could we just re-use getFormattedAddress? Seems like both methods are supposed to be doing the same thing, we could move it to addressUtils (or similar) and use one method for both pages

I changed it a little bit and moved it to PersonalDetailsUtils, let me know what you think!

JKobrynski · 2023-10-02T13:49:40Z

@eVoloshchak MenuItem's misalignment is also fixed now 😄

eVoloshchak · 2023-10-02T14:31:43Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-10-02.at.16.38.45.mov

Mobile Web - Chrome

screen-20231002-164043.mp4

Mobile Web - Safari

Screen.Recording.2023-10-02.at.16.41.17.mov

Desktop

Screen.Recording.2023-10-02.at.16.36.38.mov

iOS

Screen.Recording.2023-10-02.at.16.43.06.mov

Android

screen-20231002-164014.mp4

eVoloshchak · 2023-10-02T14:51:08Z

Tests well on all the platforms, only a couple of things left

Am I correct in understanding the QA team won't be able to test this? If so, we should leave a message about this in QA tests section
There's a failing test, is it related to this PR?
I don't have access to the design doc so this might be by design, but shouldn't the icon be aligned vertically?

cc: @JKobrynski

JKobrynski · 2023-10-03T07:02:01Z

Thanks, I updated the description
That failing test is not related to this PR,
-About, the icon, looking at the design doc I am pretty sure it should be aligned vertically, I will adjust it

JKobrynski · 2023-10-03T07:28:20Z

@eVoloshchak icon aligned, should be fine now 😄

eVoloshchak

LGTM

melvin-bot · 2023-10-03T09:55:47Z

🎯 @eVoloshchak, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #28704.

grgia · 2023-10-03T14:38:15Z

src/pages/settings/Wallet/ExpensifyCardPage.js

+                                        pan="1234123412341234"
+                                        expiration="11/02/2024"
+                                        cvv="321"


looks great, but could you add a quick comment that these will be replaced in this issue: https://github.com/orgs/Expensify/projects/58?pane=issue&itemId=33286617

grgia

🎉 Fantastic work getting this done, thanks!

OSBotify · 2023-10-04T15:00:54Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2023-10-04T15:39:53Z

Performance Comparison Report 📊

Significant Changes To Duration

Name	Duration
App start TTI	1229.524 ms → 1347.327 ms (+117.803 ms, +9.6%) 🔴
App start runJsBundle	856.310 ms → 948.438 ms (+92.127 ms, +10.8%) 🔴

Show details

Name	Duration
App start TTI	Baseline Mean: 1229.524 ms Stdev: 37.079 ms (3.0%) Runs: 1164.1744079999626 1172.8120639999397 1188.249265999999 1189.3406750001013 1193.484211999923 1193.828133000061 1194.5424130000174 1200.0925900000148 1200.7955009997822 1206.9100480000488 1214.0879330001771 1217.7798520000651 1218.6940279998817 1221.3226129999384 1222.3375479998067 1222.732245999854 1226.4161310000345 1227.4454259998165 1229.2176149999723 1229.7822320000269 1238.8710239999928 1247.2568350001238 1250.7805599998683 1258.4543429999612 1260.9412920000032 1263.1227370002307 1270.823522000108 1272.8209379999898 1296.5179099999368 1305.5594779998064 1316.0535109997727 Current Mean: 1347.327 ms Stdev: 39.654 ms (2.9%) Runs: 1282.7187359998934 1288.859825000167 1296.0974409999326 1304.0765350000001 1305.889088000171 1309.3088449998759 1313.3015140001662 1318.8402049997821 1323.4211869998835 1327.7301679998636 1331.856935000047 1332.8473490001634 1334.7162480000407 1337.2477190000936 1337.5218409998342 1339.8263289998285 1346.2030259999447 1346.5919670001604 1348.2284670001827 1353.6262599998154 1355.670938000083 1361.0306040002033 1361.8385319998488 1368.323503000196 1378.158987000119 1384.766183000058 1385.9266070001759 1394.641077999957 1410.2257220000029 1436.90056299977 1450.7568290000781
App start runJsBundle	Baseline Mean: 856.310 ms Stdev: 22.795 ms (2.7%) Runs: 816 825 825 832 833 837 839 841 841 843 843 847 849 850 854 855 856 857 863 866 875 876 877 877 877 880 886 903 910 Current Mean: 948.438 ms Stdev: 30.861 ms (3.3%) Runs: 881 894 909 915 916 919 920 922 925 927 929 934 934 941 941 943 956 958 962 964 964 969 970 970 973 974 978 979 980 985 1006 1012

Meaningless Changes To Duration

Show entries

Name	Duration
Open Search Page TTI	622.906 ms → 637.765 ms (+14.860 ms, +2.4%)
App start regularAppStart	0.018 ms → 0.016 ms (-0.002 ms, -10.4%)
App start nativeLaunch	21.467 ms → 20.933 ms (-0.533 ms, -2.5%)

Show details

Name	Duration
Open Search Page TTI	Baseline Mean: 622.906 ms Stdev: 14.416 ms (2.3%) Runs: 602.3069249996915 604.0179449999705 606.0804449999705 607.488078000024 611.4069009996019 612.2269700001925 612.7117110001855 612.9995120000094 613.5583089999855 615.1079920004122 615.6397710000165 615.9643149999902 618.778239000123 619.2261970001273 620.1538900001906 622.3103030002676 623.366415000055 626.3361409995705 629.1240239995532 630.5496020000428 631.9815679998137 632.0928549999371 636.2993169999681 636.4893809999339 636.5079350001179 637.3228760003112 638.282186999917 673.026815999765 Current Mean: 637.765 ms Stdev: 18.208 ms (2.9%) Runs: 613.5685229999945 615.4754229998216 616.8902180003934 618.0074869999662 618.1687420001253 619.5573330000043 621.037434999831 621.3820809996687 623.2928470000625 625.5838629999198 626.5190429999493 628.715210000053 629.6542969997972 635.0021159998141 635.3189300000668 635.4621589998715 635.869752000086 638.2266839998774 640.2292080000043 642.4908039998263 643.659587000031 646.9155689999461 651.8899340000935 652.1963300001808 654.9607349997386 656.0131029998884 656.1495769997127 676.0111899999902 676.9815679998137 677.7309570000507
App start regularAppStart	Baseline Mean: 0.018 ms Stdev: 0.002 ms (11.0%) Runs: 0.015137000009417534 0.015218000393360853 0.015949999913573265 0.01599099999293685 0.01607300015166402 0.01635799976065755 0.016642999835312366 0.0166830001398921 0.0167239997535944 0.017212000209838152 0.017414999660104513 0.0174150001257658 0.017538000363856554 0.017659000121057034 0.017659000121057034 0.017862999811768532 0.01794400019571185 0.018391999881714582 0.018472999799996614 0.018716999795287848 0.018716999795287848 0.019084000028669834 0.019247000105679035 0.019328000023961067 0.01940999971702695 0.020589000079780817 0.021525000222027302 0.021850999910384417 0.02209499990567565 0.022948999889194965 Current Mean: 0.016 ms Stdev: 0.001 ms (5.2%) Runs: 0.014891999773681164 0.015015000011771917 0.015177000313997269 0.01537999976426363 0.015420999843627214 0.015461999922990799 0.015503000002354383 0.015625 0.015705999918282032 0.015746999997645617 0.0157880000770092 0.015868999995291233 0.015951000154018402 0.015951000154018402 0.016113999765366316 0.016276000067591667 0.01631700014695525 0.01643799990415573 0.016561000142246485 0.016600999981164932 0.016844999976456165 0.016845999751240015 0.016887000296264887 0.016927000135183334 0.016966999974101782 0.017008000053465366 0.017212000209838152 0.01725299982354045 0.0176189998164773 0.017700999975204468 0.018554999958723783
App start nativeLaunch	Baseline Mean: 21.467 ms Stdev: 2.473 ms (11.5%) Runs: 19 19 19 19 19 19 19 19 20 20 20 20 20 20 21 21 21 22 22 22 22 22 23 23 23 24 25 26 27 28 Current Mean: 20.933 ms Stdev: 1.181 ms (5.6%) Runs: 19 20 20 20 20 20 20 20 20 20 20 20 20 20 21 21 21 21 21 21 21 22 22 22 22 22 22 22 24 24

github-actions · 2023-10-04T15:39:55Z

@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker.

OSBotify · 2023-10-05T00:38:57Z

🚀 Deployed to staging by https://github.com/grgia in version: 1.3.78-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-06T07:53:54Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.78-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-06T08:26:06Z

🚀 Deployed to staging by https://github.com/grgia in version: 1.3.79-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-09T22:34:40Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-09T22:43:33Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-09T23:19:27Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅