Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hold for payment 2023-10-13] [ECard Settings] - Add “Reveal details” for the digital card #22874

Closed
grgia opened this issue Jul 14, 2023 · 26 comments
Closed

[Hold for payment 2023-10-13] [ECard Settings] - Add “Reveal details” for the digital card #22874

grgia opened this issue Jul 14, 2023 · 26 comments
Assignees
@eVoloshchak @grgia @JKobrynski @joekaufmanexpensify
Labels
Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Weekly KSv2

Comments

@grgia
Copy link
Contributor

grgia commented Jul 14, 2023 •
edited by melvin-bot bot
Loading

HOLD ON #22873

Design Doc Section

https://docs.google.com/document/d/1rFxJ78vz5On6zSWzYa51B9v-tyLdC5pUsBeLOLig0t4/edit#bookmark=id.gpdwt3bqorke

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0191d13ceb3e2b2971
  • Upwork Job ID: 1679790549101445120
  • Last Price Increase: 2023-07-14
@grgia grgia added the Internal Requires API changes or must be handled by Expensify staff label Jul 14, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 14, 2023

Job added to Upwork: https://www.upwork.com/jobs/~0191d13ceb3e2b2971

@melvin-bot
Copy link

melvin-bot bot commented Jul 14, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @eVoloshchak (Internal)

@grgia grgia mentioned this issue Jul 14, 2023
Closed
@melvin-bot melvin-bot bot added the Monthly KSv2 label Jul 17, 2023
@grgia
Copy link
Contributor Author

grgia commented Aug 31, 2023

cc @pac-guerreiro

@melvin-bot melvin-bot bot added the Overdue label Aug 31, 2023
@pac-guerreiro
Copy link
Contributor

Could you assign me to this @grgia ? 😄

@marcaaron
Copy link
Contributor

This one is held on the Expensify Card page I think because you need an actual virtual card. Though we could also start building out a component + story for this with test data.

And then once the card page is ready plug it all in and hook up the API request to fetch and display the card details.

@marcaaron marcaaron added Daily KSv2 and removed Monthly KSv2 labels Aug 31, 2023
@melvin-bot melvin-bot bot removed the Overdue label Aug 31, 2023
@marcaaron marcaaron changed the title [HOLD #22873][ECard Settings] - Add “Reveal details” for the digital card [ECard Settings] - Add “Reveal details” for the digital card Aug 31, 2023
@JKobrynski
Copy link
Contributor

Hi, I'm Julian from Callstack - expert contributor group - and I would like to take a look at this issue.

@melvin-bot melvin-bot bot added the Overdue label Sep 4, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 4, 2023

@eVoloshchak, @pac-guerreiro Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot removed the Overdue label Sep 4, 2023
@JKobrynski JKobrynski mentioned this issue Sep 5, 2023
Merged
58 tasks
@melvin-bot
Copy link

melvin-bot bot commented Sep 12, 2023

@eVoloshchak, @JKobrynski Still overdue 6 days?! Let's take care of this!

@melvin-bot melvin-bot bot added the Overdue label Sep 12, 2023
@JKobrynski
Copy link
Contributor

Melvin, no overdue here, this issue is waiting for another issue to be merged.

@melvin-bot melvin-bot bot removed the Overdue label Sep 12, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 19, 2023

@eVoloshchak, @JKobrynski Still overdue 6 days?! Let's take care of this!

@melvin-bot melvin-bot bot added the Overdue label Sep 19, 2023
@JKobrynski
Copy link
Contributor

Melvin, no overdue here, this issue is waiting for another issue to be merged.

@melvin-bot melvin-bot bot removed the Overdue label Sep 19, 2023
@JKobrynski JKobrynski mentioned this issue Sep 21, 2023
Closed
59 tasks
@melvin-bot
Copy link

melvin-bot bot commented Sep 26, 2023

@eVoloshchak, @JKobrynski 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@melvin-bot melvin-bot bot added the Overdue label Sep 26, 2023
@JKobrynski
Copy link
Contributor

The PR is ready for review!

@melvin-bot melvin-bot bot removed the Overdue label Sep 26, 2023
@grgia grgia self-assigned this Sep 27, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 2, 2023

@eVoloshchak, @JKobrynski Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added the Overdue label Oct 2, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 4, 2023

@eVoloshchak, @grgia, @JKobrynski 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@grgia
Copy link
Contributor Author

grgia commented Oct 4, 2023

not overdue

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 4, 2023
@grgia grgia added the Reviewing Has a PR in review label Oct 10, 2023
@melvin-bot melvin-bot bot removed the Overdue label Oct 10, 2023
@grgia
Copy link
Contributor Author

grgia commented Oct 10, 2023

We need to handle $500 C+ review payment to @eVoloshchak before closing @joekaufmanexpensify

@joekaufmanexpensify
Copy link
Contributor

Cool cool, I can take this.

@joekaufmanexpensify joekaufmanexpensify self-assigned this Oct 10, 2023
@joekaufmanexpensify
Copy link
Contributor

@JKobrynski is with an agency, so their payment is handled separately. The only payment needed here is a $500 payment to @eVoloshchak for their C+ review of this PR. This will be paid via NewDot.

@joekaufmanexpensify
Copy link
Contributor

@eVoloshchak could you please submit a request for $500 and let us know here once you've done that? TY!

@eVoloshchak
Copy link
Contributor

@joekaufmanexpensify, but the PR was deployed to production 4 days ago
Shouldn't we wait 3 more days?

@joekaufmanexpensify
Copy link
Contributor

Oh yeah, good call. I will add a header to remember, and then follow up in 3 more days!

@joekaufmanexpensify joekaufmanexpensify changed the title [ECard Settings] - Add “Reveal details” for the digital card [Hold for payment 2023-10-13] [ECard Settings] - Add “Reveal details” for the digital card Oct 10, 2023
@joekaufmanexpensify joekaufmanexpensify added Weekly KSv2 and removed Daily KSv2 labels Oct 10, 2023
@joekaufmanexpensify
Copy link
Contributor

@eVoloshchak mind requesting payment today? It's now been 7 days.

@eVoloshchak eVoloshchak mentioned this issue Oct 16, 2023
Closed
@eVoloshchak
Copy link
Contributor

Requested the payment, apologies for the delay

@joekaufmanexpensify
Copy link
Contributor

Great, thanks for confirming! Closing as payment has been requested. Payment summary message is here.

@JmillsExpensify
Copy link

$500 payment approved for @eVoloshchak based on summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eVoloshchak eVoloshchak

@grgia grgia

@JKobrynski JKobrynski

@joekaufmanexpensify joekaufmanexpensify

Labels
Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@JmillsExpensify @eVoloshchak @marcaaron @grgia @JKobrynski @pac-guerreiro @joekaufmanexpensify