Refactor IOUCurrencySelection class to use hooks #20579

Julesssss · 2023-06-12T11:34:46Z

CC @marcaaron

Details

Simply refactors the IOUCurrencySelection file away from class and introduces hooks.

Fixed Issues

$ #16274

Tests

Request Money

From the FAB menu, request money from any user
At the amount step, tap the currency
You should be able to select a different currency by searching or scrolling
At the final step of the flow you should be able to edit the currency
The request should succeed when created
Verify that no errors appear in the JS console

Split Bill

From within a group chat, split bill
At the amount step, tap the currency
You should be able to select a different currency by searching or scrolling
At the final step of the flow you should be able to edit the currency
The split and requests should succeed when created
Verify that no errors appear in the JS console

Send Money

Only testable if you have Expensify wallets configured, (C+ can ignore)
From the FAB menu, send money to any user
At the amount step, tap the currency
Search for a currency to filter results
Delete the search results, the filtering should be removed
At the final step of the flow you should be able to edit the currency
The request should succeed when created
Verify that no errors appear in the JS console

Offline tests

Request Money

From the FAB menu, request money from any user
At the amount step, tap the currency
You should be able to select a different currency by searching or scrolling
At the final step of the flow you should be able to edit the currency
The request should succeed when created
Verify that no errors appear in the JS console

Split Bill

From within a group chat, split bill
At the amount step, tap the currency
You should be able to select a different currency by searching or scrolling
At the final step of the flow you should be able to edit the currency
The split and requests should succeed when created
Verify that no errors appear in the JS console

Send Money

Only testable if you have Expensify wallets configured, (C+ can ignore)
From the FAB menu, send money to any user
At the amount step, tap the currency
Search for a currency to filter results
Delete the search results, the filtering should be removed
At the final step of the flow you should be able to edit the currency
The request should succeed when created
Verify that no errors appear in the JS console

QA Steps

Request Money

From the FAB menu, request money from any user
At the amount step, tap the currency
You should be able to select a different currency by searching or scrolling
At the final step of the flow you should be able to edit the currency
The request should succeed when created
Verify that no errors appear in the JS console

Split Bill

From within a group chat, split bill
At the amount step, tap the currency
You should be able to select a different currency by searching or scrolling
At the final step of the flow you should be able to edit the currency
The split and requests should succeed when created
Verify that no errors appear in the JS console

Send Money

Only testable if you have Expensify wallets configured, (C+ can ignore)
From the FAB menu, send money to any user
At the amount step, tap the currency
Search for a currency to filter results
Delete the search results, the filtering should be removed
At the final step of the flow you should be able to edit the currency
The request should succeed when created
Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

melvin-bot · 2023-06-12T15:35:39Z

@narefyev91 @youssef-lr One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Julesssss · 2023-06-12T15:38:29Z

Hey both, I'm struggling to figure out why this lint change is necessary.

Julesssss · 2023-06-12T15:39:17Z

src/pages/iou/IOUCurrencySelection.js

-            </ScreenWrapper>
-        );
-    }
+    }, [searchValue, currencyData, props.translate]);


Surely it's better to just pass props.translate rather than props?

for sure - props.translate should be in deps

@Julesssss We have similar case before , we fixed that by a partial props destructing , check full thread here https://expensify.slack.com/archives/C01GTK53T8Q/p1684969645381109

Thanks. I've read up on prop destructuring, is this how it's supposed to be done?

const { translate } = props;

I think I've done this correctly: https://github.com/Expensify/App/pull/20579/files#diff-496700da68574808c5981ac4884e39d73ea02df4aa59bd5869e0c9227defe4c2R94

src/pages/iou/IOUCurrencySelection.js

Julesssss · 2023-06-15T13:04:17Z

I think I have successfully merged the updates to a single useMemo. Please review again

narefyev91 · 2023-06-15T13:16:45Z

src/pages/iou/IOUCurrencySelection.js

+                  ],
+            headerMessage: isEmpty ? translate('common.noResultsFound') : '',
+        };
+    }, [props.currencyList, searchValue, selectedCurrencyCode, translate]);


maybe we can also add currencyList at line 78?

fedirjh

Nice work , LGTM 🚀

narefyev91 · 2023-06-15T13:56:47Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web2.mov

web1.mov

Mobile Web - Chrome

android-web2.mov

android-web1.mov

Mobile Web - Safari

ios-web2.mov

ios-web1.mov

Desktop

desktop-2.mov

desktop-1.mov

iOS

ios-2.mov

ios-1.mov

Android

android-2.mov

android-1.mov

narefyev91

Nice work! LGTM!

Julesssss · 2023-06-15T14:02:12Z

Thanks both. All yours @youssef-lr

Julesssss · 2023-06-16T09:16:56Z

Bumping for final review @youssef-lr

# Conflicts: # src/pages/iou/IOUCurrencySelection.js

Julesssss · 2023-06-29T11:25:00Z

Hi @fedirjh, I forgot about this one and had to resolve a conflict. Would you mind one final review of the changes since you last approved please?

Julesssss · 2023-06-29T15:45:54Z

@youssef-lr is OOO, so I will reassign once this is ready for internal review.

fedirjh

LGTM and tests well.

cc @Julesssss

melvin-bot · 2023-06-29T15:52:30Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #16274... Please reach out for help on Slack if no one gets assigned!

Julesssss · 2023-06-30T08:59:20Z

Hey @srikarparsi, pullerbear is broken, but you won the reviewer lottery. Assigning you for the code review, C+ has already approved

srikarparsi

code looks good to me!

OSBotify · 2023-06-30T16:37:53Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-07-03T14:49:44Z

🚀 Deployed to staging by https://github.com/srikarparsi in version: 1.3.36-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

dangrous · 2023-07-03T19:10:59Z

Haven't confirmed yet but it's looking like this caused #22130, I'll look into it and see if I can figure out a fix but wanted to ping early.

dangrous · 2023-07-03T19:25:50Z

src/pages/iou/IOUCurrencySelection.js

+                <>
+                    <HeaderWithBackButton
+                        title={translate('iOUCurrencySelection.selectCurrency')}
+                        onBackButtonPress={() => Navigation.goBack(ROUTES.getIouRequestRoute(Navigation.getTopmostReportId()))}


ROUTES.getIouRequestRoute() doesn't currently exist which is causing the regression I commented on, will see if I can figure out what this is supposed to be and add it.

@dangrous I think it should be :

onBackButtonPress={() => Navigation.goBack(ROUTES.getMoneyRequestRoute(iouType, reportID))}

Yep! That's what I ended up going with - https://github.com/Expensify/App/pull/22135/files#diff-496700da68574808c5981ac4884e39d73ea02df4aa59bd5869e0c9227defe4c2R119 - it's weird, I looked through every commit in this PR and it never actually changed away from that in any of them. But it ends up being different in the end. I'm not sure how that happened

I think maybe it's merging main into this branch, This PR was created while another PR that refactors the IOU modal is open, At some point the other PR was merged with new code, and I think upon merging the main we didn’t accept the new changes.

ahh that makes sense.

Thanks both, Yeah my first guess was the merge as I recall some conflicts. I must have missed one when resolving.

OSBotify · 2023-07-05T17:12:57Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.36-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Julesssss added 5 commits June 12, 2023 11:35

switch from class to functional component

cb9cdab

refactor props uses

6491d6e

migrate searchValue state to useState hook

daf3b25

refactor IOUCurrencySelection to use hooks

14b0a3c

refactor IOUCurrencySelection function to hook

3416326

Julesssss self-assigned this Jun 12, 2023

Julesssss added 2 commits June 12, 2023 14:53

finish refactoring and formatting IOUCurrency page

02d0522

make getCurrencyOptions use useMemo and other improvements

025bf9b

Julesssss requested a review from a team June 12, 2023 15:35

Julesssss marked this pull request as ready for review June 12, 2023 15:35

melvin-bot bot requested review from narefyev91 and youssef-lr and removed request for a team June 12, 2023 15:35

Julesssss commented Jun 12, 2023

View reviewed changes

Julesssss mentioned this pull request Jun 12, 2023

[HOLD for payment 2023-07-12] [$250] Migrate IOUCurrencySelection.js to function component #16274

Closed

1 task

narefyev91 reviewed Jun 13, 2023

View reviewed changes

src/pages/iou/IOUCurrencySelection.js Outdated Show resolved Hide resolved

narefyev91 reviewed Jun 13, 2023

View reviewed changes

src/pages/iou/IOUCurrencySelection.js Outdated Show resolved Hide resolved

Merge branch 'main' into jules-refactorIOUCurrencySelection

a020c99

Julesssss requested a review from a team as a code owner June 13, 2023 10:49

melvin-bot bot requested review from allroundexperts and AndrewGable and removed request for a team June 13, 2023 10:50

Julesssss added 3 commits June 13, 2023 13:47

use prop destructuring

5d9143c

reorder hook statements

5e2ea3b

apply review suggestion and format code with prettier

0f0ea5b

Julesssss removed request for allroundexperts and AndrewGable June 13, 2023 12:50

Expensify deleted a comment from melvin-bot bot Jun 13, 2023

merge individual state changes to a single useMemo

9febc2f

narefyev91 reviewed Jun 15, 2023

View reviewed changes

pull currencyList from props in IOUCurrencySelection

ba01429

fedirjh approved these changes Jun 15, 2023

View reviewed changes

narefyev91 approved these changes Jun 15, 2023

View reviewed changes

Merge branch 'main' into jules-refactorIOUCurrencySelection

b74c0aa

# Conflicts: # src/pages/iou/IOUCurrencySelection.js

Julesssss removed the request for review from youssef-lr June 29, 2023 15:45

fedirjh approved these changes Jun 29, 2023

View reviewed changes

Julesssss requested a review from a team June 29, 2023 16:06

melvin-bot bot requested review from fedirjh and removed request for a team June 29, 2023 16:06

Expensify deleted a comment from melvin-bot bot Jun 29, 2023

Julesssss requested a review from srikarparsi June 30, 2023 08:58

srikarparsi approved these changes Jun 30, 2023

View reviewed changes

srikarparsi merged commit 12e9718 into main Jun 30, 2023

srikarparsi deleted the jules-refactorIOUCurrencySelection branch June 30, 2023 16:33

OSBotify mentioned this pull request Jul 3, 2023

Deploy Checklist: New Expensify 2023-07-03 #22116

Closed

40 tasks

dangrous reviewed Jul 3, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor IOUCurrencySelection class to use hooks #20579

Refactor IOUCurrencySelection class to use hooks #20579

Julesssss commented Jun 12, 2023 •

edited

Loading

melvin-bot bot commented Jun 12, 2023

Julesssss commented Jun 12, 2023

Julesssss Jun 12, 2023

narefyev91 Jun 12, 2023

fedirjh Jun 12, 2023

Julesssss Jun 13, 2023

Julesssss Jun 13, 2023

Julesssss commented Jun 15, 2023

narefyev91 Jun 15, 2023

fedirjh left a comment

narefyev91 commented Jun 15, 2023

narefyev91 left a comment

Julesssss commented Jun 15, 2023

Julesssss commented Jun 16, 2023

Julesssss commented Jun 29, 2023

Julesssss commented Jun 29, 2023

fedirjh left a comment

melvin-bot bot commented Jun 29, 2023

Julesssss commented Jun 30, 2023 •

edited

Loading

srikarparsi left a comment

OSBotify commented Jun 30, 2023

OSBotify commented Jul 3, 2023

dangrous commented Jul 3, 2023

dangrous Jul 3, 2023

fedirjh Jul 3, 2023

dangrous Jul 3, 2023

fedirjh Jul 3, 2023 •

edited

Loading

dangrous Jul 3, 2023

Julesssss Jul 4, 2023

OSBotify commented Jul 5, 2023

Refactor IOUCurrencySelection class to use hooks #20579

Refactor IOUCurrencySelection class to use hooks #20579

Conversation

Julesssss commented Jun 12, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 12, 2023

Julesssss commented Jun 12, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Julesssss commented Jun 15, 2023

Choose a reason for hiding this comment

fedirjh left a comment

Choose a reason for hiding this comment

narefyev91 commented Jun 15, 2023

Reviewer Checklist

Screenshots/Videos

narefyev91 left a comment

Choose a reason for hiding this comment

Julesssss commented Jun 15, 2023

Julesssss commented Jun 16, 2023

Julesssss commented Jun 29, 2023

Julesssss commented Jun 29, 2023

fedirjh left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Jun 29, 2023

Julesssss commented Jun 30, 2023 • edited Loading

srikarparsi left a comment

Choose a reason for hiding this comment

OSBotify commented Jun 30, 2023

OSBotify commented Jul 3, 2023

dangrous commented Jul 3, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fedirjh Jul 3, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OSBotify commented Jul 5, 2023

Julesssss commented Jun 12, 2023 •

edited

Loading

Julesssss commented Jun 30, 2023 •

edited

Loading

fedirjh Jul 3, 2023 •

edited

Loading