[HOLD for payment 2023-07-12] [$250] Migrate IOUCurrencySelection.js to function component

[marcaaron]

Class Component Migration

Filenames

• src/pages/iou/IOUCurrencySelection.js
  • type: React.Component
  • has state values: true
  • has refs: false
  • has context: false
  • lifecycle methods: none

Task

• We currently have some class components in our codebase that we would like to refactor to a function component.
• Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
• If you need additional guidance, please ask in #expensify-open-source
• Test for any regressions and verify that there are no breaking changes

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01037953951de42c17
• Upwork Job ID: 1671792773890433024
• Last Price Increase: 2023-06-22

[muxriddinmuqimov77]

I'd like to work on this issue

[melvin-bot]

Whoops! This issue is 2 days overdue. Let's get this updated quick!

[Julesssss]

I have been looking for a migration PR to complete, maybe this is a good one to start with.

[Julesssss]

PR in review. I just have one small lint issue to figure out

[Julesssss]

Assigning both @fedirjh and @narefyev91 for review payments. Thanks both!

[narefyev91]

@narefyev91 you should’ve post this to the linked PR 🥲

Yup lost myself in those links - lol

[melvin-bot]

@Julesssss, @narefyev91, @fedirjh Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01037953951de42c17

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[CortneyOfstad]

Sorry, just seeing this! Was only working 50% last week, but tackling today!

@Julesssss to confirm, the payment to @narefyev91 and @fedirjh would just be the $250, correct? Or is there any additional funds that need to be added?

[Julesssss]

Yeah, that's correct 👍

But for now, we're still waiting for the PR to be reviewed by an internal engineer, then deployed.

[CortneyOfstad]

Okay, so will wait to pay until the PR is reviewed 👍

Heading OoO for the week (back July 10) so re-assigning this in the meantime

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MitchExpensify]

Hired @fedirjh. @narefyev91 mind applying here for eventual payment? Thanks! https://www.upwork.com/jobs/~01037953951de42c17

[narefyev91]

Hired @fedirjh. @narefyev91 mind applying here for eventual payment? Thanks! https://www.upwork.com/jobs/~01037953951de42c17

@MitchExpensify Hey! No needs to do anything in Upwork, i'm from Callstack

[MitchExpensify]

Oops! thanks @narefyev91 ❤️

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.36-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Refactor IOUCurrencySelection class to use hooks #20579

If no regressions arise, payment will be issued on 2023-07-12. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@narefyev91 / @fedirjh] The PR that introduced the bug has been identified. Link to the PR:
• [@narefyev91 / @fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@narefyev91 / @fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@narefyev91 / @fedirjh] Determine if we should create a regression test for this bug.
• [@narefyev91 / @fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[MitchExpensify]

Added a reminder for payment to my calendar 👍

@fedirjh friendly reminder ton the BZ steps above when you get a chance

[fedirjh]

@MitchExpensify It's a refactor and doesn’t need BZ checklist.

[MitchExpensify]

Cool, thanks @fedirjh 👍

[Julesssss]

So this can be paid out, right?

[MitchExpensify]

Paid @fedirjh and contract ended @Julesssss