Fix: Unmatched parent report ID and report action ID #20574

tienifr · 2023-06-12T03:39:21Z

Details

When we call any API for thread's first message, we're sending the reportID of the thread (child) report, but together with the reportActionID of the parent report; while this reportActionID does not exist in the child report. This makes most of the APIs failed. This PR fixes that issue.

Fixed Issues

$ #19363
$ #19348
$ #19352
$ #19901
$ #20390
$ #20907
$ #21598
PROPOSAL: #19363 (comment), #19363 (comment)

Tests

Login with any account
Go to any chat
Reply your message in thread
Toggle report action context menu by hovering over the thread's first message (A)
======
Verify that the Reply in thread option is not available in A's context menu but available in the parent message's (B)
======
Add/remove any reaction to A
Verify that the reactions apply to both A and B
======
Copy link A
Verify that the copied link has correct report ID, i.e. /r/A_reportID/actionID for A and /r/B_reportID/actionID for B
======
Mark as unread A
Verify that A is marked as unread but not B
======
Edit comment A
Verify that the edited content also applies to B
======
Delete comment A
Verify that B is also deleted
======
Reply the other account's message in thread
Flag as offensive A
Verify that B is also flagged

Repeat step 6-18 with B message.

Verify that no errors appear in the JS console

Offline tests

Same above

QA Steps

Login with any account
Go to any chat
Reply your message in thread
Toggle report action context menu by hovering over the thread's first message (A)
======
Verify that the Reply in thread option is not available in A's context menu but available in the parent message's (B)
======
Add/remove any reaction to A
Verify that the reactions apply to both A and B
======
Copy link A
Verify that the copied link has correct report ID, i.e. /r/A_reportID/actionID for A and /r/B_reportID/actionID for B
======
Mark as unread A
Verify that A is marked as unread but not B
======
Edit comment A
Verify that the edited content also applies to B
======
Delete comment A
Verify that B is also deleted
======
Reply the other account's message in thread
Flag as offensive A
Verify that B is also flagged

Repeat step 6-18 with B message.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screencast.from.12-06-2023.17.35.29.webm

Mobile Web - Chrome

video-20230613-160657-edit_2vcfrcj9.mp4

Screenrecording_20230613_161506.mp4

Mobile Web - Safari

6763031456571314782_RmJkiXgb.mp4

Desktop

screen-recording-2023-06-14-at-010657_3FXUvD8O.mp4

iOS

screen-recording-2023-06-14-at-011947_nvc0z2aL.mp4

Android

src/libs/Navigation/Navigation.js

melvin-bot · 2023-06-14T03:45:19Z

@cristipaval @aimane-chnaif One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/libs/Navigation/Navigation.js

src/libs/ReportUtils.js

aimane-chnaif · 2023-06-14T04:47:24Z

I don't think getTopmostReportId approach will work. After navigation refactor, we allow multiple report screens open on mobile devices.
So when we open thread report from parent report, parent report gets wrong reportId, though the screen is hidden by thread report.

Here's example:

Screen.Recording.2023-06-14.at.5.44.02.AM.mov

aimane-chnaif · 2023-06-14T04:48:57Z

Let's still pass reportID as before and don't change navigation related code if it's not related to this PR.

aimane-chnaif · 2023-06-14T08:52:58Z

@tienifr please let me know when ready for review again

…unmatched-parent-report-and-action

tienifr · 2023-06-14T10:24:12Z

@aimane-chnaif Did you test on my branch? I cannot reproduce the bug you mentioned. Actually I've added the currentReportId (which is returned by getTopMostReportId) as a memo dependency of the ReportActionItem component. So whenever currentReportId changes, the action item'll get rerendered.

aimane-chnaif · 2023-06-14T12:06:40Z

@tienifr yes, I tested your branch. And pulled main locally. This is reproducible only on mobile.
I think you don't get what the bug is yet.
Here's clear reproducible video:

Screen.Recording.2023-06-14.at.1.04.40.PM.mov

tienifr · 2023-06-15T10:39:03Z

@aimane-chnaif Please take a look. Basically isParentReport tells whether the report action comes with the parent report, since it's normally passed with the current report.

…unmatched-parent-report-and-action

tienifr · 2023-06-19T07:52:25Z

Bump @aimane-chnaif

aimane-chnaif

This PR is very buggy at the moment. Not able to continue testing

src/pages/home/report/ContextMenu/ContextMenuActions.js

src/pages/home/report/ReportActionItem.js

aimane-chnaif · 2023-06-21T16:51:58Z

src/components/ShowContextMenuContext.js

@@ -37,6 +38,7 @@ function showContextMenuForReport(event, anchor, reportID, action, checkIfContex
        checkIfContextMenuActive,
        checkIfContextMenuActive,
        isArchivedRoom,
+        isParentReport,


Is this param passed anywhere? showContextMenuForReport is called from various places.

i.e. In BasePreRenderer onLongPress event, isParentReport is not passed at all.

Screen.Recording.2023-06-21.at.6.58.34.PM.mov

I started concerning about this approach of passing isParentReport

{parentReportAction && ( <ReportActionItem isParentReport report={props.parentReport}

tienifr · 2023-06-23T06:59:03Z

About the draft status mentioned here: #19363 (comment). If we proceed with the latest changes, we can agree upon the initial behavior:

edit A and don't save -> A is drafted but B doesn't follow A status so not drafted
edit B and don't save -> B is drafted but A doesn't follow B status so not drafted

aimane-chnaif · 2023-06-23T10:10:11Z

The latest code looks much simpler and less possible regressions.
@cristipaval do you agree with the approach we finally landed on?

cristipaval · 2023-06-23T10:21:20Z

The latest code looks much simpler and less possible regressions. @cristipaval do you agree with the approach we finally landed on?

Yes, and I also like that we are consistent with the way that editing works

aimane-chnaif

Code looks good. Will test shortly

src/libs/ReportUtils.js

aimane-chnaif · 2023-06-23T11:35:56Z

After deleting message, context menu is not synced until page refresh.
This is known bug - #21103 and out of scope for this PR.

Screen.Recording.2023-06-23.at.12.04.45.PM.mov

aimane-chnaif · 2023-06-23T12:29:39Z

I don't think this is bug or at least won't be handled in this PR.
Whisper message for flagging shows only on parent chat

desktop-moderation.mov

tienifr · 2023-06-23T12:42:09Z

Do you want the whisper message to appear in thread report as well? Do we need to handle that in this PR?

aimane-chnaif · 2023-06-23T12:44:18Z

When delete message which already has reactions, reactions are cleared at first but after refresh, appears again.
This already happens on production so I also think out of scope.

android-reactions.mov

aimane-chnaif · 2023-06-23T12:44:58Z

Do you want the whisper message to appear in thread report as well? Do we need to handle that in this PR?

@cristipaval what do you think?

aimane-chnaif · 2023-06-23T12:50:18Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

reaction-edit-unread-link.mov

web-delete.mov

Mobile Web - Chrome

mchrome.mov

Mobile Web - Safari

msafari-delete.mov

Desktop

desktop-moderation.mov

iOS

ios-delete.mov

Android

android-reactions.mov

aimane-chnaif

Issues found while testing:

#20574 (comment)
#20574 (comment)
#20574 (comment)

I suggest to consider these out of scope. Please comment If you disagree.
Otherwise looks good.
cc: @cristipaval

tienifr · 2023-06-26T10:07:15Z

Bump @cristipaval

OSBotify · 2023-06-26T20:21:02Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-06-26T21:05:58Z

🚀 Deployed to staging by https://github.com/cristipaval in version: 1.3.33-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

aimane-chnaif · 2023-06-27T05:00:09Z

$ https://github.com/Expensify/App/issues/19363, https://github.com/Expensify/App/issues/21598

@tienifr this will break automation

Please update like this:

$ https://github.com/Expensify/App/issues/19348
$ https://github.com/Expensify/App/issues/19352
$ https://github.com/Expensify/App/issues/19901
$ https://github.com/Expensify/App/issues/20390
$ https://github.com/Expensify/App/issues/20907
$ https://github.com/Expensify/App/issues/21598

tienifr · 2023-06-27T05:00:49Z

Thanks!

OSBotify · 2023-06-28T14:06:22Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.33-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

tienifr added 2 commits June 10, 2023 15:05

fix: unmatched parent report id and report action id

c1c14ac

fix mark unread and copy link

eb64012

tienifr changed the title ~~fix: unmatched parent report id and report action id~~ Fix: Unmatched parent report ID and report action ID Jun 12, 2023

get active report id

d49e550

tienifr commented Jun 12, 2023

View reviewed changes

src/libs/Navigation/Navigation.js Outdated Show resolved Hide resolved

fix rerender

d993726

tienifr marked this pull request as ready for review June 14, 2023 03:45

tienifr requested a review from a team as a code owner June 14, 2023 03:45

melvin-bot bot requested review from aimane-chnaif and cristipaval and removed request for a team June 14, 2023 03:45

tienifr mentioned this pull request Jun 14, 2023

[HOLD for payment 2023-07-05] [$1000] delete message functionality not working for first message in thread #19363

Closed

6 tasks

This comment was marked as outdated.

Sign in to view

aimane-chnaif reviewed Jun 14, 2023

View reviewed changes

src/libs/Navigation/Navigation.js Outdated Show resolved Hide resolved

src/libs/ReportUtils.js Outdated Show resolved Hide resolved

revert getReportIdFromRoute

258c53b

Merge branch 'main' of https://github.com/tienifr/App into fix/19363-…

9de6038

…unmatched-parent-report-and-action

isParentReport approach

5b948c2

tienifr added 3 commits June 15, 2023 18:59

Merge branch 'main' of https://github.com/tienifr/App into fix/19363-…

5aff5a2

…unmatched-parent-report-and-action

Merge 'main' into fix/19363

df26a8d

Merge 'main' into fix/19363

49d77a3

aimane-chnaif reviewed Jun 21, 2023

View reviewed changes

resolve review

0057e5a

aimane-chnaif reviewed Jun 23, 2023

View reviewed changes

src/libs/ReportUtils.js Outdated Show resolved Hide resolved

update comment

5b37315

aimane-chnaif approved these changes Jun 23, 2023

View reviewed changes

cristipaval approved these changes Jun 26, 2023

View reviewed changes

cristipaval merged commit 4ba4d5d into Expensify:main Jun 26, 2023

OSBotify mentioned this pull request Jun 26, 2023

Deploy Checklist: New Expensify 2023-06-26 #21650

Closed

23 tasks

aimane-chnaif mentioned this pull request Jun 27, 2023

[HOLD for REPORTING payment 2023-07-05] [$1000] reaction does not work for first message of thread in offline mode #21598

Closed

6 tasks

This was referenced Jul 5, 2023

fix: Regression - Emoji reaction not working - Issue 22235 (Original - 21826) #22270

Merged

[HOLD for payment 2023-08-01] [$1000] Dev: Web - Reaction does not work for first message of thread #22235

Closed

aimane-chnaif mentioned this pull request Aug 1, 2023

fix: emoji showing original message for few moments #21933

Merged

56 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Unmatched parent report ID and report action ID #20574

Fix: Unmatched parent report ID and report action ID #20574

tienifr commented Jun 12, 2023 •

edited

Loading

melvin-bot bot commented Jun 14, 2023

This comment was marked as outdated.

aimane-chnaif commented Jun 14, 2023

aimane-chnaif commented Jun 14, 2023

aimane-chnaif commented Jun 14, 2023

tienifr commented Jun 14, 2023 •

edited

Loading

aimane-chnaif commented Jun 14, 2023 •

edited

Loading

tienifr commented Jun 15, 2023 •

edited

Loading

tienifr commented Jun 19, 2023

aimane-chnaif left a comment

aimane-chnaif Jun 21, 2023

aimane-chnaif Jun 21, 2023

tienifr commented Jun 23, 2023 •

edited

Loading

aimane-chnaif commented Jun 23, 2023

cristipaval commented Jun 23, 2023

aimane-chnaif left a comment

aimane-chnaif commented Jun 23, 2023

aimane-chnaif commented Jun 23, 2023

tienifr commented Jun 23, 2023 •

edited

Loading

aimane-chnaif commented Jun 23, 2023

aimane-chnaif commented Jun 23, 2023

aimane-chnaif commented Jun 23, 2023

aimane-chnaif left a comment

tienifr commented Jun 26, 2023

OSBotify commented Jun 26, 2023

OSBotify commented Jun 26, 2023

aimane-chnaif commented Jun 27, 2023

tienifr commented Jun 27, 2023

OSBotify commented Jun 28, 2023

Fix: Unmatched parent report ID and report action ID #20574

Fix: Unmatched parent report ID and report action ID #20574

Conversation

tienifr commented Jun 12, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 14, 2023

This comment was marked as outdated.

aimane-chnaif commented Jun 14, 2023

aimane-chnaif commented Jun 14, 2023

aimane-chnaif commented Jun 14, 2023

tienifr commented Jun 14, 2023 • edited Loading

aimane-chnaif commented Jun 14, 2023 • edited Loading

tienifr commented Jun 15, 2023 • edited Loading

tienifr commented Jun 19, 2023

aimane-chnaif left a comment

Choose a reason for hiding this comment

aimane-chnaif Jun 21, 2023

Choose a reason for hiding this comment

aimane-chnaif Jun 21, 2023

Choose a reason for hiding this comment

tienifr commented Jun 23, 2023 • edited Loading

aimane-chnaif commented Jun 23, 2023

cristipaval commented Jun 23, 2023

aimane-chnaif left a comment

Choose a reason for hiding this comment

aimane-chnaif commented Jun 23, 2023

aimane-chnaif commented Jun 23, 2023

tienifr commented Jun 23, 2023 • edited Loading

aimane-chnaif commented Jun 23, 2023

aimane-chnaif commented Jun 23, 2023

aimane-chnaif commented Jun 23, 2023

Reviewer Checklist

Screenshots/Videos

aimane-chnaif left a comment

Choose a reason for hiding this comment

tienifr commented Jun 26, 2023

OSBotify commented Jun 26, 2023

OSBotify commented Jun 26, 2023

aimane-chnaif commented Jun 27, 2023

tienifr commented Jun 27, 2023

OSBotify commented Jun 28, 2023

tienifr commented Jun 12, 2023 •

edited

Loading

tienifr commented Jun 14, 2023 •

edited

Loading

aimane-chnaif commented Jun 14, 2023 •

edited

Loading

tienifr commented Jun 15, 2023 •

edited

Loading

tienifr commented Jun 23, 2023 •

edited

Loading

tienifr commented Jun 23, 2023 •

edited

Loading