[HOLD for payment 2023-07-26] [$1000] Chat - Inconsistent behavior on deleting message that have reply/thread

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to any chat on new.expensify.com
2. Write and send a message
3. Reply to your own message, it will lead you to thread page(good)
4. Go back to conversation page and delete the message
5. It says "[deleted message] 1 reply" (good), delete that message again.
6. It will remove the [deleted message] with the 1 reply temporarily, then go to the thread that is created when you reply to the message
7. Go back to the conversation, observe the "[deleted message]" reappeared(bad)
   Note that: I am not saying the deleted message is reappearing but the label "[deleted message]" is appearing again after it is deleted

Expected Result:

When the [deleted message] is deleted it should permanently be not shown, or it always shouldn't allow the label [deleted message] to be deleted based on Expensify rule. At least, it should be consistent.

Actual Result:

Now, it is not consistent. When you delete the "[deleted message]" label in the conversation it will delete temporarily, then after you get in to the thread and get back to the conversation you will see it reappearing.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

**Version Number:**1.3.28-5

Reproducible in staging?: y

Reproducible in production?: y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screenshare.-.2023-06-13.11_18_59.AM.1.mp4

Recording.784.mp4

Expensify/Expensify Issue URL:

Issue reported by: @KALLL

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686645553886709

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019b1d6662d4b09fb2
• Upwork Job ID: 1671865093908606976
• Last Price Increase: 2023-06-22

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat - Inconsistent behavior on deleting message that have reply/thread

What is the root cause of that problem?

We are checking condition to show the Delete button inside ContextMenu here:

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Lines 267 to 273 in e6c2704

	shouldShow: (type, reportAction, isArchivedRoom, betas, menuTarget, isChronosReport, reportID) =>
	// Until deleting parent threads is supported in FE, we will prevent the user from deleting a thread parent
	type === CONTEXT_MENU_TYPES.REPORT_ACTION &&
	ReportUtils.canDeleteReportAction(reportAction, reportID) &&
	!isArchivedRoom &&
	!isChronosReport &&
	!ReportActionUtils.isMessageDeleted(reportAction),

In this case, after message is deleted, we deleted the reportAction by updating the optimisticData to this:

    const deletedMessage = [
        {
            type: 'COMMENT',
            html: '',
            text: '',
            isEdited: true,
            isDeletedParentAction: true,
        },
    ];

But in isMessageDeleted we are checking isDeletedParentAction inside originalMessage

function isMessageDeleted(reportAction) {
    return lodashGet(reportAction, 'originalMessage.isDeletedParentAction', false);
}

What changes do you think we should make in order to solve the problem?

We should also update the originalMessage's isDeletedParentAction property to true in our optimisticReportActions data in here
Something like this:

    const optimisticReportActions = {
        [reportActionID]: {
            pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE,
            previousMessage: reportAction.message,
            message: deletedMessage,
            originalMessage: {
                isDeletedParentAction: true,
                html: '',
                text: '',
            },
            errors: null,
        },
    };

What alternative solutions did you explore? (Optional)

We can also use the message prop to identify if the message is deleted or not

function isMessageDeleted(reportAction) {
    return lodashGet(reportAction, ['message', 0, 'isDeletedParentAction'], false);
}

[joekaufmanexpensify]

i can reproduce this. I think this is related to the above issue. Sense checking next steps here.

[joekaufmanexpensify]

Still determining next steps

[joekaufmanexpensify]

Was advised on the other issue, that this one was out of scope there. Here is my reproduction of this bug. For expected behavior, once you delete a parent thread message. We should immediately change the comment actions menu to show only "reply in thread" and "mark Unread", which is what is shows once you leave the leave the chat and come back.

2023-06-20_16-43-23.mp4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019b1d6662d4b09fb2

[melvin-bot]

Current assignee @joekaufmanexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[joekaufmanexpensify]

@fedirjh thoughts on the above proposal?

[fedirjh]

@joekaufmanexpensify @aimane-chnaif @dhairyasenjaliya I think this is a regression from #20460 , Specifically this line

App/src/libs/ReportActionsUtils.js

Line 435 in f4ca4c8

return lodashGet(reportAction, 'originalMessage.isDeletedParentAction', false);

We should use the message prop to identify if the message is deleted or not, similar to this line

App/src/libs/ReportActionsUtils.js

Line 312 in 3531af2

const isDeletedParentAction = lodashGet(reportAction, ['message', 0, 'isDeletedParentAction'], false);

Why ?

When we delete a message the server response includes only the message prop

When we check if the message is deleted it will fail

In the other hand the OpenReport command include both props and that explain why the context menu updates after we navigate back from the thread , because new OpenReport command is triggered ...

Solution

update isMessageDeleted to

function isMessageDeleted(reportAction) {
    return lodashGet(reportAction, ['message', 0, 'isDeletedParentAction'], false);
}

[aimane-chnaif]

@fedirjh why do you think it's a regression? Did you test this issue before that PR and confirm it was working?
Context menu actions always appeared on Step 5 so never worked before.

And that was original logic. We just generalized that from download action to all actions.
https://github.com/Expensify/App/pull/20460/files#diff-c352943cfbc37be8eb6e327927c6f50b353de8481ea7bc0bc1d40776513a301dL98
This condition was added originally in #19769

[fedirjh]

why do you think it's a regression?

This case should have been handled in that PR. The PR introduced a new method and that method is causing this issue. From the context of that PR , when we delete message, we should hide other actionable item, The test included in he PR will not cover this case, in fact it hides it. We should have included another test inside the parent report, if we delete a comment inside a report it should immediately hide other context menu items.

We just generalized that from download action to all actions.

hmm but we generalized the wrong code.

[aimane-chnaif]

This issue was reported on June 13.
Our PR was merged on June 15.
So not regression.

[aimane-chnaif]

There are 3 issues related to parent message deletion.
1.Deleting parent message on thread chat doesn't update immediately (before refresh) - #19363
2.Deleting parent message on parent chat doesn't update context menu immediately (before refresh) - #21103
3.Deleted parent message (both on thread chat and parent chat) is still deletable from context menu (after refresh) - #20074

As all of these have different root causes, it's fine these issues are handled separately. But I agree it would have been better if #20074 covered #21103 as well.

[fedirjh]

This issue was reported on June 13.

My analysis is based on @joekaufmanexpensify's comment here #21103 (comment) which provide an updated expected result based on the merged PR.

[fedirjh]

As all of these have different root causes, it's fine these issues are handled separately. But I agree it would have been better if #20074 covered #21103 as well.

I am fine with handling it separately in this issue given that the original issue was reported before the PR is merged.

[hungvu193]

There's another dupe of this issue here: #21532

[joekaufmanexpensify]

Yeah @techievivek and I chatted about this and are cool to treat this like a separate issue, rather than a regression.

[hungvu193]

@MonilBhavsar @fedirjh #22956 is now ready for review!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.42-26 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix Inconsistent behavior on deleting message that have reply/thread #22956

If no regressions arise, payment will be issued on 2023-07-26. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@fedirjh] The PR that introduced the bug has been identified. Link to the PR: Fix: On delete Message hide un-actionable items #20460
• [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Fix: On delete Message hide un-actionable items #20460 (comment)
• [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: This case was missed during initial thread implementation.
• [@fedirjh] Determine if we should create a regression test for this bug.
• [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/303154

[joekaufmanexpensify]

@fedirjh Could you please complete your portion of the BZ checklist so we can prep to issue payment here?

[fedirjh]

BugZero Checklist:

• Link to the PR: Fix: On delete Message hide un-actionable items #20460
• Link to comment: Fix: On delete Message hide un-actionable items #20460 (comment)
• Link to discussion: I don't think any other step is needed. This case was missed during initial thread implementation.
• Determine if we should create a regression test for this bug: ✅

1. Send any message in any chat room
2. Thread that message
3. Send any message on that thread
4. Return to Parent Report
5. Delete the threaded message
6. Hover over [Deleted message]
7. Verify that context menu shows only "Mark as unread" icon, no other icons show

[joekaufmanexpensify]

BZ checklist is now complete, all set to issue payment. @hungvu193 was assigned on 2023-07-14, and the PR was merged on 2023-07-17. The 15th and 16th were weekend days, so the PR was merged in ~1 business day and qualifies for a bonus. So we need to make the following payments:

• @fedirjh $1,500 - C+ review and speed bonus.
• @hungvu193 $1,500 - PR and speed bonus.
• @KALLL $250 - reporting bonus.

[joekaufmanexpensify]

@hungvu193 $1,500 sent and contract ended!

[hungvu193]

@hungvu193 $1,500 sent and contract ended!

Thank you! 😄

[joekaufmanexpensify]

@KALLL It looks like our automation incorrectly sent you two offers for this job in Upwork. I see the first automatically paid you $250 for the reporting bonus here on 2023-07-14. So I've gone ahead and closed out the second with no payment.

Please let us know if you have any questions. Thanks!

[joekaufmanexpensify]

@KALLL you should have been sent an escrow refund request for $250 for the duplicate payment, since we ended the contract with no payment. Please confirm here once you've accepted it. Thanks!

I also went ahead and ended the contract for which you received your $250 payment as well!

[joekaufmanexpensify]

@fedirjh could you please accept our offer here so we can pay you? Thanks!

[fedirjh]

@joekaufmanexpensify Thank you. Accepted

[joekaufmanexpensify]

Great, thanks! @fedirjh $1,500 sent and contract ended!

[joekaufmanexpensify]

Upwork job closed.

[joekaufmanexpensify]

Bug is fixed, BZ checklist complete, and all payment issued. Closing as this is all set. Thanks everyone!