Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal QA] Update location usage key #13730

Merged
merged 2 commits into from
Dec 20, 2022
Merged

Conversation

luacmartins
Copy link
Contributor

@luacmartins luacmartins commented Dec 20, 2022

Details

Asks for permission to always use the user's location.

cc @yuwenmemon @Julesssss

Fixed Issues

$ #13731

Tests

  1. Make sure the App builds
  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Make sure we no longer get the email from Apple complaining about the missing string.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web

Mobile Web - Chrome

chrome

Mobile Web - Safari

safari

Desktop desktop
iOS

ios

Android

android

@luacmartins luacmartins self-assigned this Dec 20, 2022
@luacmartins luacmartins changed the title Update location usage key [No QA] Update location usage key Dec 20, 2022
@luacmartins luacmartins changed the title [No QA] Update location usage key [Internal QA] Update location usage key Dec 20, 2022
@luacmartins luacmartins added the InternalQA This pull request required internal QA label Dec 20, 2022
@luacmartins luacmartins marked this pull request as ready for review December 20, 2022 16:58
@luacmartins luacmartins requested a review from a team as a code owner December 20, 2022 16:58
@melvin-bot melvin-bot bot requested review from deetergp and rushatgabhane and removed request for a team December 20, 2022 16:59
@melvin-bot
Copy link

melvin-bot bot commented Dec 20, 2022

@rushatgabhane @deetergp One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@rushatgabhane
Copy link
Member

rushatgabhane commented Dec 20, 2022

@deetergp all yours! because I'm OOO and this seems internal

@@ -17,7 +17,7 @@
<key>CFBundlePackageType</key>
<string>APPL</string>
<key>CFBundleShortVersionString</key>
<string>1.2.42</string>
<string>1.2.41</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to change this? This update will go out with the latest version, no?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops jinx you fixed this!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Xcode auto "corrected" this. I asked in Slack and reverted this. Thanks for the review and merge!

@yuwenmemon
Copy link
Contributor

yuwenmemon commented Dec 20, 2022

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android

@yuwenmemon yuwenmemon merged commit bd55a20 into main Dec 20, 2022
@yuwenmemon yuwenmemon deleted the cmartins-updateInfoPlist branch December 20, 2022 17:14
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Copy link
Contributor

@Julesssss Julesssss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for resolving this.

@github-actions
Copy link
Contributor

Performance Comparison Report 📊

Significant Changes To Duration

There are no entries

Meaningless Changes To Duration

Show entries
Name Duration
TTI 813.611 ms → 828.317 ms (+14.706 ms, +1.8%)
nativeLaunch 9.645 ms → 10.031 ms (+0.386 ms, +4.0%)
regularAppStart 0.014 ms → 0.015 ms (+0.001 ms, +5.6%)
runJsBundle 196.531 ms → 193.750 ms (-2.781 ms, -1.4%)
Show details
Name Duration
TTI Baseline
Mean: 813.611 ms
Stdev: 34.294 ms (4.2%)
Runs: 765.4580920003355 769.173914000392 772.1058000000194 773.3264960004017 780.0603029998019 781.6856429995969 784.704904999584 786.8851399999112 787.3941740002483 787.9195440001786 788.56597100012 791.7237309999764 796.6751020001248 798.2817820003256 798.6587570002303 799.4898229995742 804.5341860000044 815.8684320002794 818.7220839997754 827.5439790003002 839.3586769998074 841.6374469995499 842.601490999572 844.563436999917 848.6216329997405 849.8946810001507 850.0965790003538 852.6827299995348 853.2562250001356 863.5081299999729 906.9430940002203

Current
Mean: 828.317 ms
Stdev: 32.743 ms (4.0%)
Runs: 771.5043930001557 771.6138970004395 790.9570810003206 792.4052379997447 793.0792950000614 795.9710999997333 803.4206379996613 806.7899580001831 809.5414739996195 812.3773140003905 812.5092970002443 816.0316319996491 821.1167879998684 821.286616999656 824.1414799997583 824.2261469997466 826.4897290002555 829.74237800017 832.3445450002328 833.035163000226 833.9313989998773 838.2329770000651 849.5401600003242 855.2922090003267 870.2927010003477 870.5104599995539 876.562160000205 876.8102989997715 888.3202640004456 901.4431090001017
nativeLaunch Baseline
Mean: 9.645 ms
Stdev: 1.577 ms (16.4%)
Runs: 7 8 8 8 8 8 8 8 8 8 9 9 9 9 9 9 10 10 10 10 11 11 11 11 11 11 11 11 12 13 13

Current
Mean: 10.031 ms
Stdev: 1.960 ms (19.5%)
Runs: 8 8 8 8 8 8 8 8 9 9 9 9 9 9 9 10 10 10 10 10 10 10 10 10 11 12 12 13 13 14 14 15
regularAppStart Baseline
Mean: 0.014 ms
Stdev: 0.001 ms (6.8%)
Runs: 0.012532000429928303 0.012614000588655472 0.012736000120639801 0.012736000120639801 0.01297999918460846 0.012980999425053596 0.013062000274658203 0.01314299926161766 0.013143000192940235 0.013183999806642532 0.013224000111222267 0.013224000111222267 0.013386999256908894 0.013427999801933765 0.0134680001065135 0.013590999878942966 0.013834000565111637 0.013835000805556774 0.013957000337541103 0.0139979999512434 0.014038000255823135 0.014159999787807465 0.014159999787807465 0.014159999787807465 0.01444500032812357 0.014485999941825867 0.01534000039100647 0.015665999613702297 0.01574699953198433 0.016276000067591667

Current
Mean: 0.015 ms
Stdev: 0.001 ms (5.6%)
Runs: 0.013306000269949436 0.013345999643206596 0.013509000651538372 0.013591000810265541 0.013712000101804733 0.01371300034224987 0.013915999792516232 0.013996999710798264 0.013996999710798264 0.013998000882565975 0.014241000637412071 0.014282000251114368 0.0143630001693964 0.014405000023543835 0.014444999396800995 0.01444500032812357 0.014485999941825867 0.014485999941825867 0.014688999392092228 0.014728999696671963 0.0147299999371171 0.014973999932408333 0.015300000086426735 0.01534000039100647 0.01537999976426363 0.015381000004708767 0.015421000309288502 0.015828000381588936 0.01595000084489584 0.0167239997535944
runJsBundle Baseline
Mean: 196.531 ms
Stdev: 22.943 ms (11.7%)
Runs: 158 161 164 165 171 172 183 184 184 184 186 187 189 189 190 190 193 197 197 197 201 202 207 209 211 217 218 224 236 237 238 248

Current
Mean: 193.750 ms
Stdev: 18.534 ms (9.6%)
Runs: 165 166 169 173 174 175 176 177 178 178 180 181 182 183 192 197 198 199 199 202 203 205 205 207 208 208 209 212 213 217 230 239

@luacmartins
Copy link
Contributor Author

This needs to be tested in prod.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @yuwenmemon in version: 1.2.43-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @chiragsalian in version: 1.2.43-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
InternalQA This pull request required internal QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants