Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-01-03] Fix location permissions for App #13731

Closed
luacmartins opened this issue Dec 20, 2022 · 2 comments
Closed

[HOLD for payment 2023-01-03] Fix location permissions for App #13731

luacmartins opened this issue Dec 20, 2022 · 2 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Dec 20, 2022

Problem

We keep getting emails from Apple complaining about the lack of a purpose string for always asking to use location

We identified one or more issues with a recent delivery for your app, "New Expensify" 1.2.42 (1.2.42.1). Your delivery was successful, but you may wish to correct the following issues in your next delivery:

ITMS-90683: Missing purpose string in Info.plist - Your app’s code references one or more APIs that access sensitive user data, or the app has one or more entitlements that permit such access. The Info.plist file for the “New Expensify.app” bundle should contain a NSLocationAlwaysAndWhenInUseUsageDescription key with a user-facing purpose string explaining clearly and completely why your app needs the data. If you’re using external libraries or SDKs, they may reference APIs that require a purpose string. While your app might not use these APIs, a purpose string is still required.

Why is this important

Apple can lower our App store visibility

Solution

Add the string to Info.plist

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0125a2ad675d6725f8
  • Upwork Job ID: 1605346216202936320
  • Last Price Increase: 2022-12-20
@luacmartins luacmartins added the Daily KSv2 label Dec 20, 2022
@luacmartins luacmartins self-assigned this Dec 20, 2022
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Dec 20, 2022
@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Dec 20, 2022
@luacmartins
Copy link
Contributor Author

PR here

@luacmartins luacmartins added the Internal Requires API changes or must be handled by Expensify staff label Dec 20, 2022
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Dec 27, 2022
@melvin-bot melvin-bot bot changed the title Fix location permissions for App [HOLD for payment 2023-01-03] Fix location permissions for App Dec 27, 2022
@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jan 2, 2023
@luacmartins
Copy link
Contributor Author

This one is done. No payments due. Closing.

@Expensify Expensify unlocked this conversation Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

1 participant