[$125] Android - LHN - Sending a text+attachment displays text with ellipsis.

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.12
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Launch app
2. Tap on a report
3. Send a text+attachment choosing a image from gallery
4. Navigate to LHN

Expected Result:

Sending a text+attachment must display text+attachment in LHN

Actual Result:

Sending a text+attachment displays text with ellipsis

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6552316_1721890748266.Screenrecorder-2024-07-25-12-22-52-482_compress_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0143efae25694044fa
• Upwork Job ID: 1819194218797436242
• Last Price Increase: 2024-09-09

Issue Owner

Current Issue Owner: @mollfpr

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@RachCHopkins FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[RachCHopkins]

@lanitochka17 do we know what "Sending a text+attachment must display text+attachment in LHN" means? I can't decipher the meaning of this statement, what should show in the LHN?

[lanitochka17]

That is the word Attachment should be displayed instead of ...

[melvin-bot]

@RachCHopkins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0143efae25694044fa

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[RachCHopkins]

Thanks @lanitochka17

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Sending a text+attachment displays text with ellipsis

What is the root cause of that problem?

In many places we use formatReportLastMessageText

• App/src/libs/SidebarUtils.ts

  Line 437 in 5005f59

  result.alternateText = ReportUtils.formatReportLastMessageText(getWelcomeMessage(report, policy).messageText ?? Localize.translateLocal('report.noActivityYet'));

• App/src/libs/SidebarUtils.ts

  Line 406 in 5005f59

  result.alternateText = ReportUtils.formatReportLastMessageText(TaskUtils.getTaskReportActionMessage(lastAction).text);

The idea is that we'll format the last message text correctly by replacing line breaks with spaces, trim the value to a max length, ...

App/src/libs/ReportUtils.ts

Line 1789 in 5005f59

return StringUtils.lineBreaksToSpaces(String(lastMessageText).trim()).substring(0, CONST.REPORT.LAST_MESSAGE_TEXT_MAX_LENGTH).trim();

However we don't use it consistently for all places, so in this text + attachment case, formatReportLastMessageText is not applied and the last message text is displayed with line breaks like

24

[Attachment]

As the last message text has numberOfLines 1, it will show ellipsis.

What changes do you think we should make in order to solve the problem?

We need to make sure to apply formatReportLastMessageText consistently for all cases of last message text. The best way is to update right before we display it, here to

{ReportUtils.formatReportLastMessageText(Parser.htmlToText(optionItem.alternateText))}

After that optionally we can remove some other usage of formatReportLastMessageText like the ones mentioned in RCA, because using it here should be adequate for the last message text to be displayed correctly.

What alternative solutions did you explore? (Optional)

Use ReportUtils.formatReportLastMessageText and Parser.htmlToText for individual cases when we set the result.alternateText:

• App/src/libs/SidebarUtils.ts

  Lines 447 to 448 in 5005f59

  	? `${lastActorDisplayName}: ${lastMessageText}`
  	: lastMessageText || formattedLogin;

• App/src/libs/SidebarUtils.ts

  Line 431 in 5005f59

  result.alternateText = `${lastActorDisplayName}: ${lastMessageText}`;

  
  And many more.

Another thing we could contemplate is to trim unnecessary spaces in formatReportLastMessageText, so if there's any multiple spaces sequentially they could be replaced by 1 space. However that seems out of scope of the issue.

[github-actions]

true

[daledah]

Proposal modified to add a small detail

[github-actions]

true

[melvin-bot]

@mollfpr, @RachCHopkins Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mollfpr]

@daledah Could you explain why it's only happen in native?

[daledah]

@mollfpr Great question! That's because in web, the alternate text has white-space: no-wrap, so both text and attachment are shown on the same line due to no-wrap behavior. Meanwhile on native there's no such property for Text. whiteSpace is disabled specifically for native as can see here.

So the problem is mostly only visible in native, although in web the alternateText is also formatted incorrectly but the no-wrap behavior hides the bug.

[mollfpr]

@daledah That's make sense to me!

The proposal looks good, but I would prefer the alternative solution incase we will use getOptionData in somewhere else then the alternateText is well formatted.

🎀 👀 🎀 C+ reviewed!

[melvin-bot]

Triggered auto assignment to @techievivek, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @daledah You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[greg-schroeder]

fyi @RachCHopkins the PR for this issue led to a regression (#47248). I'm not paying folks in that issue, but they should be subject to the regression penalty in this one (if you haven't paid them yet, which it seems like you haven't)

[melvin-bot]

This issue has not been updated in over 15 days. @mollfpr, @RachCHopkins, @techievivek, @daledah eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[RachCHopkins]

@techievivek @mollfpr I can't actually tell what's going on with this issue - is someone able to give me a quick summary of where it's at?

[mollfpr]

@RachCHopkins I think it's ready for the payment summary. The original PR and follow-up PR were in production last month.

[melvin-bot]

Upwork job price has been updated to $125

[RachCHopkins]

Payment Summary:

Contributor: @daledah to be paid $125 via Upwork
Contributor+: @mollfpr to be paid $125 via NewDot Manual Request
Upwork job here

[RachCHopkins]

@daledah I have sent you another proposal!

[rohit9625]

I just saw the job on upwork but after reading the comments, I am unsure if it's fixed now or not. Could anyone please clarify?

[melvin-bot]

📣 @rohit9625! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[daledah]

@daledah I have sent you another proposal!

Thank you @RachCHopkins I have accepted

[RachCHopkins]

Sorry for the confusion @rohit9625 - that was me trying to get a fresh offer to the person who'd already fixed the issue.

Contributor has been paid, the contract has been completed, and the Upwork post has been closed.

[rohit9625]

Sorry for the confusion @rohit9625 - that was me trying to get a fresh offer to the person who'd already fixed the issue.

No problem, Thanks :)

[garrettmknight]

$125 approved for @mollfpr