LHN - Missing space between user and to in "invited 1 userto #room" when inviting user to room

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.19-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to a room.
3. Click on the room header > Members.
4. Invite a member to the room.
5. Go to #admins.

Expected Result:

#admins report preview in LHN will display "invited 1 user to #room".

Actual Result:

#admins report preview in LHN displays "invited 1 userto #room".

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6570031_1723474843471.20240812_225750.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @blimpich (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to #vip-vsb

[etCoderDysto]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Missing space between user and to in "invited 1 userto #room" when inviting user to room

What is the root cause of that problem?

formatReportLastMessageText trims the space before preposition and return ${preposition} ${roomName}

App/src/libs/SidebarUtils.ts

Line 418 in 9aa78ff

result.alternateText += ReportUtils.formatReportLastMessageText(`${preposition} ${roomName}`);

What changes do you think we should make in order to solve the problem?

We should add space before the value returned from formatReportLastMessageText

result.alternateText += ` ${ReportUtils.formatReportLastMessageText(`${preposition} ${roomName}`)}`;

Note: we can check for all instances of ReportUtils.formatReportLastMessageText to see if it trimmed a space before a message on other places, and apply the same change.

What alternative solutions did you explore? (Optional)

[blimpich]

Shouldn't be blocking backend deploys, and I'd also say this probably isn't a frontend deploy blocker either. It doesn't look good but I don't think its a blocker.

[blimpich]

@etCoderDysto thank you for pointing out the problematic code 🙏. In the future when proposing a solution to an issue marked as a DeployBlocker please make sure to link to the PR that introduced the issue, which in this case would be this PR.

Generally for deploy blockers we would assign this to the contributor who caused the regression in the first place. But we might assign to a contributor who makes a proposal if (A) the contributor who caused the regression isn't available to work on it or isn't easily reachable via Slack (B) we don't want to revert the original PR and (C) the issue is truly urgent and the contributor who proposed a fix is able to work on it quickly.

For this case I think A & B are true, but I don't think C is true. I don't consider this urgent. So I'm going to assign the original contributor and C+ to work on this as follow up.

cc: @daledah @mollfpr

[blimpich]

@daledah for some reason GH won't let me assign you to this PR, but could you please raise a PR to fix this issue since it was caused by the PR you raised last week?

Sidenote: what is your Slack username? I tried to find you in Slack to ask you about this issue but couldn't find you.

[etCoderDysto]

In the future when proposing a solution to an issue marked as a DeployBlocker please make sure to link to the PR that introduced the issue.

Sorry, I will do that for the future.

[daledah]

@blimpich i'll raise follow up PR soon

Sidenote: what is your Slack username? I tried to find you in Slack to ask you about this issue but couldn't find you.

We are having some issues with adding new people to Slack so I can't get into Slack right now.

[daledah]

@mollfpr @blimpich We have a follow-up PR here

[sakluger]

FYI - I'll be OOO for the next week, back on Aug 30. @blimpich hopefully I won't be needed between now and then - if so, you can assign another BZ member by removing me, then removing and re-adding the Bug label.

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[greg-schroeder]

This seems to have been deployed to prod on 8/19 - regression period is through today

[greg-schroeder]

Seems this was a regression fix by original PR authors (@daledah and @mollfpr) so no payment is due here. Payment will be handled in original issue #46190