DM Chat message sent by Jeremy to me didn't show up in web chat

[mallenexpensify]

Problem
I sent Jeremy a message in Chat, he received it and replied. The message didn't show up for me in Chat on web. I got the message via email then went back to Chat and it still wasn't there. I had Daniel send a test DM which properly showed as bolded in LHN and in the chat. After I hard refreshed the site, Jeremy's message finally showed up.

Solution
See if we figure out why this might be happening. @chiragsalian , any chance this might be related to 'unread' work you're currently doing?

[mallenexpensify]

Happened again on web, this time for #deprecate-slack

[quinthar]

Yep, I'm experiencing this one too.

…

On Thu, Sep 3, 2020 at 9:42 AM Matt Allen ***@***.***> wrote: Happened again on web, this time for #deprecate-slack [image: image] <https://user-images.githubusercontent.com/22508304/92143104-a2936700-edc9-11ea-9e87-47f398499e61.png> [image: image] <https://user-images.githubusercontent.com/22508304/92143117-a7581b00-edc9-11ea-9dcd-ee3bf85c2805.png> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#388 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEMNUXY7HEENXWLOD64Y6DSD7BN5ANCNFSM4QTOYAQQ> .

[mallenexpensify]

@chiragsalian will this be fixed with the bug you found yesterday? I think it's related.. maybe (where you can refresh and unreads will still show)

[chiragsalian]

No i don't think this is related. The bug i found and fixed is - if a person has never DM'd you sends you a message it should show up in LHN in realtime. Atm the current code won't show the new message until you refresh.

Anyway no i think this issue is different. I have seen this happening on dev but it has been very rare.

[peterdbarkerUK]

This happened for me and Conor too today.

Related: when navigating to the chat manually (cmd+k: Conor) I only saw the first message I sent him. To get the rest of our message history I had to send another message. This approach didn't work for the issue at hand here.

[jboniface]

This is happening to me in rooms, as well as DMs.

[mallenexpensify]

@chiragsalian and I were testing #352 and ran into the issue of him sending me DMs while I was signed out, then me not seeing them once I logged in. We're hoping that problem is related to this issue and that we can fix both.

I'm bumping to Critical since we need people to see DMs in LHN in order to properly use Chat and there's no workaround.

[mallenexpensify]

@chiragsalian something that might be helpful...
When I was testing, it appears that the issue of a user not 'popping up' so that I can DM them happens if there is previously text in the compose box. On desktop, to replicate, start typing a message to me (don't send) > go to #deprecate-slack > then use the chat switcher to try to message me again. For me, nothing happens. Expect... minutes later I was able to 'pull you up' via chat switcher but the text I had previously typed was gone (which.. is likely another issue to discuss soonish)

[chiragsalian]

I believe the cause of this issue is the same mentioned here because if you ever visited the chat and then that person sends a DM it would never show up for you to revisit.

The code for it got pushed a few minutes back and since then i haven't been able to reproduce the problem on dev so i think we need to re-test that code once it gets deployed.

[jboniface]

This seems to be working now

[mallenexpensify]

I had an issue this morn where a chat with Conor didn't show up in LHN on web but I got an email for it and it showed in Desktop when I was able to login.
Coincidentally, @rafecolton had the same issue with a chat I sent him too.
Can you take a look @chiragsalian and let us know if you need anything else from us?

[rafecolton]

I'm not exactly sure how to reproduce this, but here's the chat for context in case it helps.

[mallenexpensify]

Dropped this down to MEDIUM for right now since it appears that the issue happens rarely. Let's keep it open and on the milestone right now to see if anyone else has thoughts/ideas.

From @chiragsalian

i think for 95% of the cases it works well while there is like a 5% chance of DM not being sent. We haven’t figured out if its due to pusher or a code mistake but its hard to trace hence i’m not sure if its worth investigate for our POC. Thoughts?

Would it be helpful to collect more examples and for us to review logs?

Yeah its nice to collect examples. But the issue is also POC critical atm which if open means that it doesn’t work. As for logs, well this native chat is so new that it doesn’t support recording logs at the moment. We could improve the browser logs but when you refresh you would loose it.

[mallenexpensify]

Same issue happened to me again with Conor on Desktop this morn when I first opened computer.
@abekkala had it happen this morn, bumping up to HIGH since this seems to be widespread enough that we should continue to look into and try to solve

[koswalto]

This just happened to me too. I wished @sakluger a happy birthday (HAPPY BIRTHDAY SASHA!!!) and his reply didn't come to the chat but only to email. I'm using the desktop app, v. 1.0.1-47.

Same thing happened with Conor. I replied to the email via an email as well, but nothing showed up in chat except my original message. Only when Conor responded to that email did all messages suddenly appear in chat.

[mallenexpensify]

Moving up to CRITICAL, this appears to be very common, I just had three chats not show up, had to hard refresh :(

[chiragsalian]

As discussed with @mallenexpensify and @jboniface, i believe the issue was due to pusher reconnects that was tackled here - #475

[AndrewGable]

Sound like this was fixed. Let's close and reopen if it happens again?

[mallenexpensify]

it's still happening, for some reason I didn't initially directly correlate the issues and created this new GH #490
@AndrewGable @chiragsalian do you think it's best to reopen this one (and close the new one) or to move the chat over to the new one?

[chiragsalian]

I don't think we should reopen these. But for the GH recently created we should mention if its one-off or something that always happens. For something thats always reproducible its priority should be higher than items that are one-offs.