[$500] Room - Web - Header shows changed Room name & room name on composer unchanged room name

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.33-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go offline
2. Create a room
3. Change the name of the room
4. Take a note of room name on header and room name above the composer

Expected Result:

Room name should be consistent

Actual Result:

Inconsistency in Room name preview when change in offline mode.
Header shows changed Room name while room name above composer shows the first unchanged room name

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6361117_1706634444941.Recording__1966.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d1afbac3cc3b8deb
• Upwork Job ID: 1752383443231072256
• Last Price Increase: 2024-02-06
• Automatic offers:
• Ollyws | Reviewer | 28150301
• esh-g | Contributor | 28150302

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d1afbac3cc3b8deb

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[lanitochka17]

We think that this bug might be related to #vip-vsp.
CC @quinthar

[esh-g]

Proposal

Please re-state the issue we are trying to solve

Header shows changed Room name & room name on composer unchanged room name

Root cause

We are memoizing the ReportActionItemCreated component incorrectly.

App/src/pages/home/report/ReportActionItemCreated.tsx

Lines 111 to 119 in 9909a36

	memo(
	ReportActionItemCreated,
	(prevProps, nextProps) =>
	prevProps.policy?.name === nextProps.policy?.name &&
	prevProps.policy?.avatar === nextProps.policy?.avatar &&
	prevProps.report?.stateNum === nextProps.report?.stateNum &&
	prevProps.report?.statusNum === nextProps.report?.statusNum &&
	prevProps.report?.lastReadTime === nextProps.report?.lastReadTime,
	),

What changes should be made to fix this?

We should check if props.report?.reportName changed in the memo

[mkhutornyi]

I think this can be fixed together in #35123 or #35378

[Ollyws]

@mkhutornyi None of the solutions proposed in those issues would fix this one.

@esh-g's proposal LGTM.

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @Gonals, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[mkhutornyi]

I meant they can be combined into one issue since all of these came from memo:

#35471
#35378
#35419

    memo(
        ReportActionItemCreated,
        (prevProps, nextProps) =>
            prevProps.policy?.name === nextProps.policy?.name &&
            prevProps.policy?.avatar === nextProps.policy?.avatar &&
            prevProps.policy?.avatar === nextProps.policy?.avatar &&
+           _.isEqual(prevProps.report?.participantAccountIDs, nextProps.report?.participantAccountIDs) &&
+           prevProps.report?.reportName === nextProps.report?.reportName &&
+           _.isEqual(prevProps.personalDetails, nextProps.personalDetails)
            prevProps.report?.stateNum === nextProps.report?.stateNum &&
            prevProps.report?.statusNum === nextProps.report?.statusNum &&
            prevProps.report?.lastReadTime === nextProps.report?.lastReadTime,
    ),

[adelekennedy]

@Gonals will you review the selected proposal?

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[adelekennedy]

we have a selected proposal - just waiting for engineer review @Gonals

[melvin-bot]

📣 @Ollyws 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @esh-g 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

This issue has not been updated in over 15 days. @Ollyws, @Gonals, @adelekennedy, @esh-g eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[esh-g]

@adelekennedy I think the payments for this issue are pending. The PR was deployed to prod 3 weeks ago.

[adelekennedy]

@esh-g thank you! It looks like the automation failed for updating the title - settling payments now

[adelekennedy]

@Ollyws it looks like you haven't accepted the offer on Upwork, once you do I can remit payment and will you take a look at the checklist below?

;;BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• The PR that introduced the bug has been identified. Link to the PR:
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here:

[Ollyws]

Just trying to track down which PR caused this.... @esh-g if you have any insights they would be much appreciated.

[Ollyws]

BugZero Checklist:

• The PR that introduced the bug has been identified. Link to the PR:

#34463

• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

#34463 (comment)

• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

N/A

• A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here:

Regression Test Proposal

1. Go offline
2. Create a room
3. Change the name of the room
4. Take a note of room name on header and room name above the composer and make sure they are same.

Do we agree 👍 or 👎

[Ollyws]

@adelekennedy Checklist complete and offer accepted.

[esh-g]

@Ollyws Sorry for not replying before. I had to take a break due to health reasons, so wasn't active then. Be sure to contact anytime in future if such help is needed. Thanks!

[Ollyws]

@adelekennedy Can we pay and close this one? Thanks!

[Ollyws]

Friendly bump @adelekennedy

[adelekennedy]

So sorry!! Paying this out now