[$500] Chat - Profile pic is not displayed for non communicated existing report in chat area

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.33-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Open the app and login with gmail account
2. Open search
3. Search for user which already exists on app, has a profile pic but current logged in user has no conversation history with it (should be gmail account)
4. Click on the result
5. Observe that app displays profile pic in header but not in chat area

Expected Result:

App should either display profile pic in both chat area and header or should not display profile pic in either places

Actual Result:

App displays profile pic in header but does not display profile pic in chat area

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6360678_1706607798363.new_message_new_user_issue_profile.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017ddf238b8d0fa663
• Upwork Job ID: 1752285750358851584
• Last Price Increase: 2024-02-13

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017ddf238b8d0fa663

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Profile pic in chat area doesn't show the custom avatar when starting a new chat with a new user.

What is the root cause of that problem?

When we start a new chat, the LHN and header avatar is updated after we receive the personal detail data, but not for the avatar in the chat area and that's because we memoize the component but didn't consider the personal details data.

App/src/pages/home/report/ReportActionItemCreated.tsx

Lines 107 to 119 in aaa658f

	personalDetails: {
	key: ONYXKEYS.PERSONAL_DETAILS_LIST,
	},
	})(
	memo(
	ReportActionItemCreated,
	(prevProps, nextProps) =>
	prevProps.policy?.name === nextProps.policy?.name &&
	prevProps.policy?.avatar === nextProps.policy?.avatar &&
	prevProps.report?.stateNum === nextProps.report?.stateNum &&
	prevProps.report?.statusNum === nextProps.report?.statusNum &&
	prevProps.report?.lastReadTime === nextProps.report?.lastReadTime,
	),

So, the component isn't updated when the personal detail is updated.

What changes do you think we should make in order to solve the problem?

Add check for personal details too.

_.isEqual(prevProps.personalDetails, nextProps.personalDetails)

What alternative solutions did you explore? (Optional)

Or we can just use usePersonalDetails hook so we don't need to compare it in the memo.

I notice that we only check for some fields of report and policy which could potentially raise some issues too, perhaps we can remove the memo completely as it's really hard to maintain the list of attributes of each onyx data. We can totally do that, but it's just not worth the effort I guess

[ikevin127]

Dupe, mentioned here: #35123
I posted the same proposal (rca, main solution) there 2 days ago as the one posted above here.

[s77rt]

@ikevin127 Looks you reported a new (similar) bug. I think we can handle that there.

cc @sonialiap We can close this

[ikevin127]

I can confirm that both issues are solved - not reproducible aymore 🚀
Must've been the big PR merged recently.

MacOS: mWeb Chrome

Screen.Recording.2024-02-02.at.13.42.53.mov

cc @sonialiap @s77rt

[s77rt]

We can close this then

[s77rt]

To be closed

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[s77rt]

@sonialiap ^

[s77rt]

To be closed

[melvin-bot]

@s77rt @sonialiap this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸