[$1000] Inconsistent blurring of parent message in offline mode

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Login to staging new dot
2. Turn force online on
3. Go to any chat and send a message
4. Long press the message and click on reply on a thread
5. Send a message in the thread
6. Long press the parent message in the thread and click on edit and observe that even in edit mode the message is blurred
7. Go back to main chat and long press parent message and open edit mode
8. Observe that the parent message is not blurred when opened in edit mode

Expected Result:

Parent message blurring should be consistent

Actual Result:

Parent message is blurred out in thread but not in main chat when edited

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.57-5
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

2023_08_19_10_53_03.mp4

screen-20230827-101818.mp4

Expensify/Expensify Issue URL:
Issue reported by: @SofoniasN
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692431934822249

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c804b9b7ce7b7a1d
• Upwork Job ID: 1696153710008893440
• Last Price Increase: 2023-09-18

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Inconsistent blurring of parent message in offline mode

What is the root cause of that problem?

I think the RCA of this is our ReportActionItemParentAction is wrapped with OfflineWithFeedback, meanwhile the ReportActionItemMessageEdit of ReportActionItem is not.

What changes do you think we should make in order to solve the problem?

We can wrap our ReportActionItemMessageEdit inside ReportActionItem with OfflineWithFeedback.

<OfflineWithFeedback pendingAction={props.action.pendingAction}>
<ReportActionItemMessageEdit />
</OfflineWithFeedback />

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c804b9b7ce7b7a1d

[melvin-bot]

Current assignee @CortneyOfstad is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Parent message is blurred out in thread but not in main chat when edited

What is the root cause of that problem?

In a normal ReportActionItemMessageEdit, we have this condition to avoid the offline blurring UI if we're editing the message

App/src/pages/home/report/ReportActionItem.js

Line 570 in c7c538f

pendingAction={props.draftMessage ? null : props.action.pendingAction}

But in the case of ReportActionItemMessageEdit inside ReportActionItemParentAction, it's wrapped in another OfflineWithFeedback here that is missing the draft message checking condition. So when the condition there is true, it will show the blurring without checking the draft message

What changes do you think we should make in order to solve the problem?

We need to add the condition here to here as well.

pendingAction={props.draftMessage ? null : (lodashGet(props.report, 'pendingFields.addWorkspaceRoom') || lodashGet(props.report, 'pendingFields.createChat'))}

(The draftMessage we'll get by using withReportActionsDrafts, similar to in ReportActionItem

We can consider not setting the errors if there's draftMessage too

What alternative solutions did you explore? (Optional)

If instead we want to make all MessageEdit to have the blur style offline, then we can remove the draftMessage condition here.

pendingAction={props.action.pendingAction}

[CortneyOfstad]

@aimane-chnaif thoughts on the proposals above? TIA!

[CortneyOfstad]

@aimane-chnaif Bump ^^^

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@CortneyOfstad, @aimane-chnaif Whoops! This issue is 2 days overdue. Let's get this updated quick!

[CortneyOfstad]

@aimane-chnaif Bump on the above proposals ^^^ TIA!

[aimane-chnaif]

@dukenv0307 can you please share demo video after applying your solution?

[dukenv0307]

@aimane-chnaif Here is the video. I also had a branch here https://github.com/dukenv0307/App/tree/fix/26036, You can see and test again if needed.

Screen.Recording.2023-09-08.at.20.09.59.mov

[CortneyOfstad]

@aimane-chnaif ^^^ TIA!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[aimane-chnaif]

If the bug is fixed by a PR that is not associated with your bug report, then you will not be eligible for the corresponding compensation unless you can find the PR that fixed it and prove your bug report came first.

@SofoniasN If bug is not reproducible, you should find out fixed PR to get reporting bonus according to contributing guideline.

[CortneyOfstad]

@SofoniasN bump on @aimane-chnaif's comment above ^^^

[CortneyOfstad]

@SofoniasN bump ^^^

[SofoniasN]

@CortneyOfstad i couldnt find the PR that fixed this issue.

[dukenv0307]

@SofoniasN This is fixed in this PR #26213

[melvin-bot]

@madmax330, @CortneyOfstad, @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[CortneyOfstad]

I was under the impression that if a PR fixed multiple bugs, the reporting bonus was not provided on any subsequent GHs. Can you confirm @madmax330?

[madmax330]

@CortneyOfstad maybe ask in bug-zero or c+ I haven't heard of this either

[melvin-bot]

@madmax330, @CortneyOfstad, @aimane-chnaif Huh... This is 4 days overdue. Who can take care of this?

[CortneyOfstad]

I was under the impression that if a PR fixed multiple bugs, the reporting bonus was not provided on any subsequent GHs.

@sakluger I believe you and I talked about this on another GH. I believe that to be the case, but need a gut-check. Thanks!

[CortneyOfstad]

Bump @sakluger ^^^ Thank you!

[CortneyOfstad]

I am heading OoO until Oct. 25 so reassigning BZ to keep an eye on this while I'm gone 👍

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[joekaufmanexpensify]

@CortneyOfstad as an fyi, I think we are supposed to leave ourselves assigned to chores when going OOO, so you can take them back once you're back from OOO. So going to re-assign you back.

Happy to watch this while you're out though!

[joekaufmanexpensify]

I think the case here is covered well by the contributing guidelines that @aimane-chnaif referenced above. It sounds like this bug was fixed in this PR.

That PR is linked to this issue, and the bug in that issue was reported several weeks before the bug in this issue. Based on the guidelines, the reporter in this issue would not be eligible for a reporting bonus here.

[joekaufmanexpensify]

Closing, as this bug is fixed, and no payment is needed here!