-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-09-20] [HOLD for payment 2023-09-18][$1000] Inconsistency: Different grayness levels on parent and child message #24263
Comments
Triggered auto assignment to @joekaufmanexpensify ( |
Bug0 Triage Checklist (Main S/O)
|
ProposalPlease re-state the problem that we are trying to solve in this issue.Inconsistency: Different grayness levels on parent and child message What is the root cause of that problem?App/src/pages/home/report/ReportActionItemParentAction.js Lines 55 to 60 in bba0eb2
We are applying OfflineWithFeedback to both ReportActionItemParentAction and ReportActionItemCreated with the same props App/src/pages/home/report/ReportActionItemCreated.js Lines 59 to 65 in c9df4db
So that the parent message of the thread will be wrapped by 2 OfflineWithFeedback Components. It makes the parent message of the thread become darker gray than other comments What changes do you think we should make in order to solve the problem?We should remove the OfflineWithFeedback in ReportActionItemParentAction Result |
ProposalPlease re-state the problem that we are trying to solve in this issue.Inconsistency: Different grayness levels on parent and child message What is the root cause of that problem?The What changes do you think we should make in order to solve the problem?Solution 1: const needsOpacity = !props.isDisabledOpacity && (...) In ReportActionItemParentAction, we use that prop to avoid setting opacity when ReportActionItem will set it. <OfflineWithFeedback
isDisabledOpacity={parentReportAction.pendingAction} Solution 2: return parentReportAction.pendingAction ? (
{reportActionContent}
) : (
<OfflineWithFeedback
...
>
{reportActionContent}
</OfflineWithFeedback>
); |
I can reproduce this. I can't think of any reason why we'd want parent and child messages to be in a different shade of grey here. Especially as the parent and child messages are normally the same text color while online. 2023-08-08_16-31-23.mp4 |
Job added to Upwork: https://www.upwork.com/jobs/~0192daee63c42d4dbd |
Current assignee @joekaufmanexpensify is eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane ( |
Pending review of proposals |
ProposalPlease re-state the problem that we are trying to solve in this issue.The level of grayness on the Parent and child messages are different while offline What is the root cause of that problem?App/src/pages/home/report/ReportActionItemParentAction.js Lines 55 to 75 in 811a83e
ReportActionItemParentAction component renders ReportActionItem component wrapped by OfflineWithFeedback component App/src/pages/home/report/ReportActionItem.js Lines 533 to 564 in 811a83e
And ReportActionItem also renders content wrapped by OfflineWithFeedback component So the parent report content is wrapped by 2 OfflineWithFeedback Components, thereby we have darker grey What changes do you think we should make in order to solve the problem?We should make ReportActionItemParentAction has only one OfflineWithFeedback component In my opinion, it would be better to add new property(isParentPendingAction) to ReportActionItem component, and update pendingAction property below App/src/pages/home/report/ReportActionItem.js Line 535 in 811a83e
to pendingAction={props.draftMessage ? null : props.action.pendingAction && !props.isParentPendingAction} So the nested OfflineWithFeedback component won't have opacity My details |
📣 @henryhover! 📣
|
@sobitneupane thoughts on these proposals? |
Bumped in Slack. |
Thanks for the proposal @ginsuma
If |
ProposalUpdate App/src/pages/home/report/ReportActionItemParentAction.js Lines 55 to 57 in 566efc9
cc: @sobitneupane |
Please re-state the problem that we are trying to solve in this issue.Inconsistency: Different grayness levels on parent and child message What is the root cause of that problem?when we are offline the Parent character opacity is 0.5 and child character opacity is 1, opacity value is different for parent and child components. What changes do you think we should make in order to solve the problem?To solve this issue you need to create a new class in
and also change class in below file:
Video |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
@sobitneupane do you think we're close to being able to use any of these proposals? |
ProposalPlease re-state the problem that we are trying to solve in this issue.Inconsistency: Different grayness levels on parent and child message What is the root cause of that problem?We are applying 2 OfflineWithFeedback to the first message of child thread App/src/pages/home/report/ReportActionItemParentAction.js Lines 55 to 60 in 7f13cdd
App/src/pages/home/report/ReportActionItem.js Lines 533 to 539 in 811a83e
What changes do you think we should make in order to solve the problem?We should remove OfflineWithFeedback in ReportActionItemParentAction. And then, in ReportActionItemParentAction we will pass new prop called offlineObject like this:
And in ReportActionItem, if offlineObject props exist we will use it as params of OfflineWithFeedback Component else we still use the current condition What alternative solutions did you explore? (Optional) |
@joekaufmanexpensify Merge freeze is over now https://expensify.slack.com/archives/C01GTK53T8Q/p1694405959277169 so I went ahead and merged the PR. |
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.68-17 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-09-20. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
@sobitneupane mind completing the BZ checklist here so we can prep to issue payment? |
Bump @sobitneupane mind working on the BZ checklist so we can finish this one off? |
Bumped in Slack |
Probably offline tests were not performed in the linked PR. This should have been caught in offline test.
Yes.
|
Regression Test Proposal
|
I will request payment in newDot once the payment is summarized. |
Great, thanks! I will work on the BZ checklist. |
IMO, this is a very minor visual bug, and no regression test is needed. |
BZ checklist is complete, all set to issue payment. We need to make the following payments:
|
@daveSeife $250 sent and contract ended! |
@ginsuma $500 sent and contract ended! |
@sobitneupane could you please request $500 and confirm here once that's done? TY! |
@joekaufmanexpensify received. Thank you! |
Pending request |
Closing per our slack discussion! Payment summary message for when @sobitneupane requests is here. |
Requested payment on newDot |
$500 payment approved for @sobitneupane based on BZ summary. |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Action Performed:
Notice the level of grayness on the Parent and child message
Expected Result:
Same grayness levels
Actual Result:
Different grayness levels
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.51-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Test99.Graynesslevel-1.mp4
Expensify/Expensify Issue URL:
Issue reported by: @daveSeife
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690943139195889
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: