[HOLD for payment 2024-01-17] [TS migration] Migrate 'FloatingActionButton.js' component to TypeScript

[melvin-bot]

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path	Dependencies
src/components/FloatingActionButton.js	11

Issue Owner

Current Issue Owner: @sophiepintoraetz

[melvin-bot]

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[JKobrynski]

Hi, I'm Julian from Callstack - expert contributor group - and I would like to take a look at this issue.

[melvin-bot]

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

[JKobrynski]

This issue is blocked by #16150

[JKobrynski]

This issue is no longer blocked!

[JKobrynski]

The PR is ready for review!

[melvin-bot]

Triggered auto assignment to @roryabraham, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

Triggered auto assignment to @sophiepintoraetz (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[roryabraham]

@sophiepintoraetz hi 👋🏼 the PR was just merged, and the only payment due here is $250 to @eVoloshchak for the C+ review of a TS migration PR (pending deploy to prod and regression period)

[sophiepintoraetz]

offer sent

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.23-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [TS Migration] migrate FloatingActionButton to TypeScript #33247

If no regressions arise, payment will be issued on 2024-01-17. 🎊

For reference, here are some details about the assignees on this issue:

• @eVoloshchak requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eVoloshchak] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@sophiepintoraetz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[eVoloshchak]

@sophiepintoraetz, could you post a payment summary here please?
Noting this has caused two regressions, the amount should be $62.5

[sophiepintoraetz]

Thanks for the transparency @eVoloshchak! Confirming that the payment should be $62.5

[eVoloshchak]

@sophiepintoraetz, any updates on the above?

[mallenexpensify]

Contributor+: @eVoloshchak due $62.50 via NewDot

[JmillsExpensify]

$62.50 approved for @eVoloshchak