Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD for payment 2024-01-09] [$250] Migrate FloatingActionButton.js to function component #16150

Closed
1 task
marcaaron opened this issue Mar 20, 2023 · 42 comments
Closed
1 task

[HOLD for payment 2024-01-09] [$250] Migrate FloatingActionButton.js to function component #16150

marcaaron opened this issue Mar 20, 2023 · 42 comments
Assignees
@twisterdotcom @rushatgabhane @MitchExpensify @roryabraham @rayane-djouah
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement.
Milestone
React Class Compo...

Comments

@marcaaron
Copy link
Contributor

marcaaron commented Mar 20, 2023 •
edited by melvin-bot bot
Loading

Class Component Migration

Filenames

Task

  • We currently have some class components in our codebase that we would like to refactor to a function component.
  • Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
  • If you need additional guidance, please ask in #expensify-open-source
  • Test for any regressions and verify that there are no breaking changes
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0135528d050de22c41
  • Upwork Job ID: 1681842818291113984
  • Last Price Increase: 2023-07-20
  • Automatic offers:
    • rayane-djouah | Contributor | 26487109
@marcaaron marcaaron added Engineering Improvement Item broken or needs improvement. labels Mar 20, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 20, 2023
@Expensify Expensify unlocked this conversation Mar 21, 2023
@marcaaron marcaaron changed the title [HOLD] Migrate FloatingActionButton.js to function component [HOLD][$250] Migrate FloatingActionButton.js to function component Apr 13, 2023
@MelvinBot
Copy link

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

@muxriddinmuqimov77
Copy link

I'd like to work on this issue

@s-alves10
Copy link
Contributor

I'd love to work on this.

@dayana7204
Copy link
Contributor

I am ready to work on this ticket. :)

@olexyt
Copy link
Contributor

olexyt commented Jul 7, 2023

I can work on this issue.

@rayane-djouah
Copy link
Contributor

Can I work on this issue?

@mkhutornyi
Copy link
Contributor

I'd like to work on this.

@KrAbhas
Copy link
Contributor

KrAbhas commented Jul 19, 2023

I would like to work on this

@marcaaron marcaaron self-assigned this Jul 20, 2023
@marcaaron marcaaron added the Internal Requires API changes or must be handled by Expensify staff label Jul 20, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 20, 2023

Job added to Upwork: https://www.upwork.com/jobs/~0135528d050de22c41

@melvin-bot
Copy link

melvin-bot bot commented Jul 20, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @Santhosh-Sellavel (Internal)

@payal-lathidadiya
Copy link
Contributor

can i work on this

@marcaaron marcaaron changed the title [HOLD][$250] Migrate FloatingActionButton.js to function component [$250] Migrate FloatingActionButton.js to function component Jul 20, 2023
@marcaaron marcaaron mentioned this issue Jul 20, 2023
Closed
57 tasks
@code0406
Copy link
Contributor

I am available to work on this.

@marcaaron
Copy link
Contributor Author

@code0406 please read the contributing guidelines and learn to identify issues that need help with the Help Wanted label.

@roryabraham
Copy link
Contributor

Assigning this to @rayane-djouah per this discussion. Refactoring FloatingActionButton to a functional component appears to be the best way to refactor Icon without introducing bugs due to FloatingActionButton's use of Animated.createAnimatedComponent, which only works with class components.

@roryabraham roryabraham added the External Added to denote the issue can be worked on by a contributor label Sep 4, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 4, 2023

Triggered auto assignment to @MitchExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot melvin-bot bot added the Daily KSv2 label Sep 4, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Dec 21, 2023
@melvin-bot melvin-bot bot changed the title [$250] Migrate FloatingActionButton.js to function component [HOLD for payment 2023-12-28] [$250] Migrate FloatingActionButton.js to function component Dec 21, 2023
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 21, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 21, 2023
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 21, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-12-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Dec 27, 2023
@MitchExpensify
Copy link
Contributor

Not 100% on whether payment is due here seeing as the PR was reverted, mind giving me a BZ buddy check here @mallenexpensify ? Thank you!

@rushatgabhane
Copy link
Member

@MitchExpensify no payment due yet.
@rayane-djouah has raised a new PR, let's wait on it's merge for next payment date

@MitchExpensify
Copy link
Contributor

Thanks, @rushatgabhane !

@roryabraham roryabraham changed the title [HOLD for payment 2023-12-28] [$250] Migrate FloatingActionButton.js to function component [$250] Migrate FloatingActionButton.js to function component Dec 29, 2023
@roryabraham roryabraham removed the Awaiting Payment Auto-added when associated PR is deployed to production label Dec 29, 2023
@roryabraham
Copy link
Contributor

The new PR is currently on staging

@melvin-bot melvin-bot bot added the Overdue label Jan 1, 2024
@rayane-djouah
Copy link
Contributor

Not overdue, PR on staging

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Overdue Daily KSv2 labels Jan 1, 2024
@melvin-bot melvin-bot bot changed the title [$250] Migrate FloatingActionButton.js to function component [HOLD for payment 2024-01-09] [$250] Migrate FloatingActionButton.js to function component Jan 2, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jan 2, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.20-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-01-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@MitchExpensify
Copy link
Contributor

Reminder set to pay!

Payment summary:

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jan 9, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jan 9, 2024

Issue is ready for payment but no BZ is assigned. @twisterdotcom you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

@MitchExpensify
Copy link
Contributor

Paid and contract ended @rayane-djouah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@twisterdotcom twisterdotcom

@rushatgabhane rushatgabhane

@MitchExpensify MitchExpensify

@roryabraham roryabraham

@rayane-djouah rayane-djouah

Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement.
Projects
None yet
Milestone
React Class Component Migration
Development

No branches or pull requests