Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] [HOLD for payment 2024-01-18] [HOLD for payment 2024-01-17] LHN - Clicking the (FAB) after opening the modal does not close the modal #34185

Closed
1 of 6 tasks
lanitochka17 opened this issue Jan 9, 2024 · 17 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@lanitochka17
Copy link

lanitochka17 commented Jan 9, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.23-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1: Sign in to the staging environment of Expensify.
2: Click on the Floating Action Button (FAB) to open the modal.
3: Click on the FAB again; the modal should close

Expected Result:

After opening the modal, clicking on the FAB again should close the modal

Actual Result:

The modal does not close after opening, even when clicking on the FAB again

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6337079_1704830896228.Screen5.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0178ff077f70abe686
  • Upwork Job ID: 1748053502135980032
  • Last Price Increase: 2024-01-18
@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Jan 9, 2024
Copy link
Contributor

github-actions bot commented Jan 9, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Jan 9, 2024

Triggered auto assignment to @marcochavezf (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@s-alves10
Copy link
Contributor

This is a regression of this PR #33247

Copy link

melvin-bot bot commented Jan 9, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Jan 9, 2024
@roryabraham
Copy link
Contributor

Fix is being CP'd to staging, cheers to @situchan for the quick fix

@thienlnam thienlnam removed the DeployBlockerCash This issue or pull request should block deployment label Jan 10, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jan 10, 2024
@melvin-bot melvin-bot bot changed the title LHN - Clicking the (FAB) after opening the modal does not close the modal [HOLD for payment 2024-01-17] LHN - Clicking the (FAB) after opening the modal does not close the modal Jan 10, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jan 10, 2024
Copy link

melvin-bot bot commented Jan 10, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jan 10, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.23-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-01-17. 🎊

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jan 11, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-01-17] LHN - Clicking the (FAB) after opening the modal does not close the modal [HOLD for payment 2024-01-18] [HOLD for payment 2024-01-17] LHN - Clicking the (FAB) after opening the modal does not close the modal Jan 11, 2024
Copy link

melvin-bot bot commented Jan 11, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.24-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-01-18. 🎊

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Jan 16, 2024
@melvin-bot melvin-bot bot added the Daily KSv2 label Jan 16, 2024
Copy link

melvin-bot bot commented Jan 18, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@melvin-bot melvin-bot bot added the Overdue label Jan 18, 2024
@situchan
Copy link
Contributor

@marcochavezf can you please assign me and add Bug label? Thanks

@marcochavezf marcochavezf added the Bug Something is broken. Auto assigns a BugZero manager. label Jan 18, 2024
Copy link

melvin-bot bot commented Jan 18, 2024

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@marcochavezf
Copy link
Contributor

Hi @joekaufmanexpensify, could you handle the payment for @situchan for fixing this deploy blocker?

@joekaufmanexpensify joekaufmanexpensify added the External Added to denote the issue can be worked on by a contributor label Jan 18, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-01-18] [HOLD for payment 2024-01-17] LHN - Clicking the (FAB) after opening the modal does not close the modal [$500] [HOLD for payment 2024-01-18] [HOLD for payment 2024-01-17] LHN - Clicking the (FAB) after opening the modal does not close the modal Jan 18, 2024
Copy link

melvin-bot bot commented Jan 18, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0178ff077f70abe686

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 18, 2024
Copy link

melvin-bot bot commented Jan 18, 2024

Current assignee @situchan is eligible for the External assigner, not assigning anyone new.

@joekaufmanexpensify joekaufmanexpensify removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 18, 2024
@joekaufmanexpensify
Copy link
Contributor

@situchan offer sent for $500!

@joekaufmanexpensify
Copy link
Contributor

@situchan $500 sent and contract ended!

@joekaufmanexpensify
Copy link
Contributor

All set!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

7 participants