Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$1000] Web - Task - Task actions not updated in real time in task report #20266

Closed
1 of 6 tasks
kbecciv opened this issue Jun 6, 2023 · 14 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@kbecciv
Copy link

kbecciv commented Jun 6, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Issue found when executing PR #19515

Action Performed:

  1. Login with any account
  2. Click FAB icon >> Assign task
  3. Fill in Title and Description >> Next
  4. Select a contact for Assignee (Select the current user) and share somewhere
  5. Press Confirm task
  6. Navigate to the newly create Task report
  7. Press Mark as done
  8. Navigate to the Task report
  9. Press vertical three dots menu on report header >> Mark as incomplete

Expected Result:

Verify that the task is successfully marked as done in both Task report and parent report
Verify that the task is successfully re-opened in both Task report and parent report

Actual Result:

Task actions are not updated in real time in task report

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.24.4

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6082159_19515_Desktop_task.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c08a5e26aeab6cb2
  • Upwork Job ID: 1666168015864901632
  • Last Price Increase: 2023-06-13
@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jun 6, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 6, 2023

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jun 6, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@adelekennedy adelekennedy added the External Added to denote the issue can be worked on by a contributor label Jun 6, 2023
@melvin-bot melvin-bot bot changed the title Web - Task - Task actions not updated in real time in task report [$1000] Web - Task - Task actions not updated in real time in task report Jun 6, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 6, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01c08a5e26aeab6cb2

@melvin-bot
Copy link

melvin-bot bot commented Jun 6, 2023

Current assignee @adelekennedy is eligible for the External assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented Jun 6, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 6, 2023
@adelekennedy
Copy link

reproducible, and I can't find an identical bug > external

@melvin-bot
Copy link

melvin-bot bot commented Jun 6, 2023

Triggered auto assignment to @Gonals (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@rojiphil
Copy link
Contributor

rojiphil commented Jun 7, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

When tasks are completed and reopened in Task Report, the Task Report is not getting updated realtime.

What is the root cause of that problem?

Once the task actions for complete task and reopen task are initiated and completed, the front end does not have the updated comments from the Task Report action. Hence, there is no real time update of the Task Report . This is the root cause.

What changes do you think we should make in order to solve the problem?

Once the API request for CompleteTask and ReopenTask commands are initiated, also initiate an API request for OpenReport command so that updated report actions are triggered to perform real time updates to the Task Report.

The following line needs to be added after API calls
Report.openReport(taskReportID);

The code is referenced for CompleteTask here and for ReopenTask here.

Alternatively, the backend can also update the Report Actions for the Task Report as part of API response of CompleteTask and ReopenTask. This will trigger the updates to the Task Report.

Test Result Video:

20266_taskreportupdate.mp4

What alternative solutions did you explore? (Optional)

@rojiphil
Copy link
Contributor

rojiphil commented Jun 7, 2023

Just checked this issue with 1.3.25-4.
Looks like the issue is resolved with pusher updates.

@abdulrahuman5196
Copy link
Contributor

@adelekennedy Same here not able to reproduce on the latest main. Can we re-check and close the issue if its not reproducible?

@melvin-bot melvin-bot bot added the Overdue label Jun 9, 2023
@abdulrahuman5196
Copy link
Contributor

@adelekennedy could you check on this?#20266 (comment)

@melvin-bot melvin-bot bot removed the Overdue label Jun 12, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 13, 2023

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@adelekennedy
Copy link

ai - coming back to this late. I just tried to reproduce and I'm seeing the task updates in real time. I think we can close this due to the upstream fix
Screenshot 2023-06-13 at 2 21 02 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

6 participants