Deploy Checklist: New Expensify 2023-06-05

[OSBotify]

Release Version: 1.3.24-5
Compare Changes: production...staging

This release contains changes from the following pull requests:

• [No QA] Hooks best practices #16882
• Disable attachment carousel scroll when zoomed in #18634
• Refactor DateOfBirthPage as function component #18975
• feat: use pressable with press feedback #19391
• Feature Request: Assign task to yourself #19515
• 17015 - migrate SidebarLinks to PressableWithoutFeedback #19597
• Remove Mandatory Description field on edit task #19749
• fix workspace avatar it not updated #19750
• 17027 - migrated CollapsibleSection to PressableWithFeedback #19753
• Use Paid language in requests instead of settled and other manual requests polish #19817
• fix: Prevent enter key press on BaseOptionsSelector if screen is not focused #19824
• Fix crash on split confirm #19875
• Allow Hoverable to accept single element array of children and improve tooltip overlapping check #19886
• Fix replay component position while editing message #19902
• fix: set initial task title and description values from Onyx if present #19908
• Redirect to sign-in when anonymous user clicks on profile email #19940
• Display Concierge chat report when there is no report to be displayed #19945
• Fix: Contact Method - Validation error message doesn't disappear upon requesting new magic code #19950
• Qr code update #19984
• [No QA] feat: add storybook check to CI #19998
• Clean up nvp_paypalMeAddress Onyx key #20031
• feat: use accountID instead of email in WithCurrentUserPersonalDetails #20034
• feat: use accountID in App.js #20036
• feat: use accountID in DateUtils #20037
• 17034 - migrated HeaderWithCloseButton to PressableWithoutFeedback #20055
• [No-QA]Use large runners for deploys #20056
• 20019 - migrated TaskHeader to PressableWithFeedback #20068
• Try to use labels: to get large runner to start #20096
• [No QA] feat: fix storybook #20097
• [No QA]Revert Ubuntu large runner testing #20104
• Refactor LogInWithShortLivedAuthTokenPage to a functional component #20112
• Fix text align top for welcome message input #20113
• Show default Keyboard if login account is not an email in CloseAccount page #20116
• Chat - Tiny dots displayed in link name for message/link [([some])](https://google.com) #19646 #20147
• Add null check before react effect #20155
• [No QA]Update electron-builder to latest to try to fix hdiutil error #20199
• [No QA] Fix electron notary #20210
• [No QA] Update electron-notarize package name #20218
• Revert PERSONAL_DETAILS_LIST Onyx changes #20220

Deploy Blockers:

• [HOLD for payment 2023-06-13] Profile - Timezone toggle is not working when going offline #20209
• Display name - Unable to update first and last name #20219
• Profile - Unable to change time zone #20227
• Profile - Unable to update avatar offline. Avatar updated after back online #20229
• [$1000] Closed accounts aren't removed from workspace members list #20264
• [HOLD for payment 2023-06-21] mWeb - Workspaces are not immediately displayed when transitioning from OD to ND #20275
• Assign task - Error message about title shows up when title is inputted #20281
• [HOLD 19330] Assign task - Mark as complete CTA is cut off #20284
• Task - Task is not unchecked when marked as incomplete #20285

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[isagoico]

#20036 - Will be tested with the regression run, will check it off after the regression is complete (if it is a pass)

For #20068 unsure if we need to execute step 1 to be able to verify this PR - @Skalakid @Gonals can you confirm please

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.24-1 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.24-1 has been deployed to staging 🎉

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.24-0 🚀

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.24-2 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.24-2 has been deployed to staging 🎉

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.24-3 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.24-3 has been deployed to staging 🎉

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.24-4 🚀

[roryabraham]

Fix for #20154 was deployed with the last checklist, removing the label

[roryabraham]

Can we please retest the following deploy blockers in 1.3.24-4. I think they all may have been fixed by #20220. Please log out and back in after updating before retesting:

• [HOLD for payment 2023-06-13] Profile - Timezone toggle is not working when going offline #20209
• Display name - Unable to update first and last name #20219
• Profile - Unable to change time zone #20227
• Profile - Unable to update avatar offline. Avatar updated after back online #20229

[isagoico]

#20112 is failing because of issue #20275 Left a message for @francoisl to confirm if it should be a DB or not

[Julesssss]

Regarding #20264

Though it was introduced in this release, I don't think we should block the deployment for it, given that not showing avatar (on Desktop only) is not a critical issue. I removed the label and checked it off, but feel free to make your own decision here @roryabraham

[isagoico]

Update on #20220 - Desktop app tests are missing since the app has not yet updated to 1.3.24-4. Rests of the platforms are a pass.

[Julesssss]

Ahhh, that might explain why the issue only exists on Desktop. I need to retest and double-check the version.

[roryabraham]

Oh, yeah desktop deploy failed for 1.3.24-4. It's been very flaky and I don't really have a solution other than retrying for now.

[isagoico]

Full Summary of PR testing:

1. Feature Request: Assign task to yourself #19515 several issues were found, including 3 different deploy blockers:

• [$500 BONUS PAYOUT] [$1000] Web - Chat - '# Reply' is not displayed after replying to root message without network #20265
• [$1000] Web - Task - Task actions not updated in real time in task report #20266
• Task - Task is not unchecked when marked as incomplete #20285
• Assign task - Error message about title shows up when title is inputted #20281

2. fix workspace avatar it not updated #19750 - is being retested after the DB fix. Desktop test is missing bc 1.3.24-4 is not available yet
3. 17027 - migrated CollapsibleSection to PressableWithFeedback #19753 is failing because of issue [$2000] IOU - Add bank account is looping when clicking pay with expensify #20280
4. Use Paid language in requests instead of settled and other manual requests polish #19817 is failing because of this issue [HOLD on prioritizing P2P] IOU - Button doesn't show the expected text "Pay" or "Pay Elsewhere"  #20236
5. Fix replay component position while editing message #19902 is failing because of [$500 BONUS PAYOUT] [$1000] Web - Chat - '# Reply' is not displayed after replying to root message without network #20265
6. For 20019 - migrated TaskHeader to PressableWithFeedback #20068 we're unsure if we need to execute step 1 to be able to verify this PR (Asked here)
7. Refactor LogInWithShortLivedAuthTokenPage to a functional component #20112 is failing because of issue [HOLD for payment 2023-06-21] mWeb - Workspaces are not immediately displayed when transitioning from OD to ND #20275 (Left a message to validate if it should be a DB or not)
8. Revert PERSONAL_DETAILS_LIST Onyx changes #20220 - waiting for desktop build

Going to hide the previous comments as this list centralizes all the issues with unchecked PRs.

[roryabraham]

Working on getting desktop deploys fixed

[francoisl]

#20112 is failing because of issue #20275 Left a message for @francoisl to confirm if it should be a DB or not

Commented in the issue, not a blocker so feel free to check 20112 if the rest is working fine. Thanks!

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.24-5 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.24-5 has been deployed to staging 🎉

[roryabraham]

Desktop deploy worked btw ... 5th time's the charm

[mvtglobally]

@roryabraham thsnks for confirmation. We will wrap up now.

[mvtglobally]

Full Summary of unchecked PR testing:

Feature Request: Assign task to yourself #19515 several issues were found, including 3 different deploy blockers. We are retesting this Pr after revert

fix workspace avatar it not updated #19750 - is being retested after the DB fix. Desktop test is missing bc 1.3.24-5 just got available. It's pass checking off

This PR #19753 (comment) is failing QA because of issue #20280

Use Paid language in requests instead of settled and other manual requests polish #19817 is failing because of this issue [HOLD on prioritizing P2P] IOU - Button doesn't show the expected text "Pay" or "Pay Elsewhere" #20236

Fix replay component position while editing message #19902 is failing because of Web - Chat - '# Reply' is not displayed after replying to root message without network #20265

#20068 (comment)

Revert PERSONAL_DETAILS_LIST Onyx changes #20220 - just got desktop build, checking

[roryabraham]

Ok, sorry for the delay. Let's see if we can get this over the finish line. Here's where we're at right now:

• [HOLD for payment 2023-06-21] mWeb - Workspaces are not immediately displayed when transitioning from OD to ND #20275 – demoted, checking it off.
• [$1000] Closed accounts aren't removed from workspace members list #20264 – not a blocker but should be fixed in 1.3.24-4. Now that that deploy completed successfully, let's please retest and close if not reproducible.
• fix workspace avatar it not updated #19750 – needs retest on desktop
• 17027 - migrated CollapsibleSection to PressableWithFeedback #19753 – issue not a deploy blocker, checking it off.
• Use Paid language in requests instead of settled and other manual requests polish #19817 - issue not a deploy blocker, checking it off.
• Fix replay component position while editing message #19902 – issue not a deploy blocker, checking it off.
• 20019 - migrated TaskHeader to PressableWithFeedback #20068 – I was able to verify this one, checking it off.
• Refactor LogInWithShortLivedAuthTokenPage to a functional component #20112 – issue not a deploy blocker, checking it off.

[roryabraham]

Concise summary:

All that's left is these two PRs:

• Feature Request: Assign task to yourself #19515 - all the associated issues were fixed by the revert, just re-checking those on desktop
• fix workspace avatar it not updated #19750 – looks like this has been checked off so nothing more to do here

[roryabraham]

Noticed something weird with the timing dashboard, not a blocker but brought up here: https://expensify.slack.com/archives/C035J5C9FAP/p1686081343190679

[isagoico]

#20305 was found while executing the retest of #19515. The issue is reproducible in production so not sure if it should be related to this PR.
We were also able to reproduce this one #20284 (comment) but it's getting fixed on a different PR

Aside from these 2 issues, the PR was a pass.

[roryabraham]