fix(lnd): add jstype to channel ids #1036
Merged
+77
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
offerm
reviewed
Jun 17, 2019
There was a problem hiding this comment.
Looks good to me if this was the solution used in the past.
Only question I have is for @sangaman - Why lightningnetwork/lnd#2352 was closed? Did you find a different solution ?
|
I was wondering the same about lightningnetwork/lnd#2352. It would be great to have some kind of mechanism in place to prevent this from happening in the future. |
ghost
mentioned this pull request
offerm
approved these changes
Jun 17, 2019
offerm
approved these changes
Jun 17, 2019
I must have deleted the branch by accident after the PR didn't get picked up after several months. I'm going to rebase the branch and reopen the PR as it would be helpful to prevent these sorts of things in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we're adding
jstype = JS_STRINGback to lnd proto definitions. They were originally added via #747 and removed when the hold invoices feature was merged (35ae4f6#diff-b455b61269f578b306ff6d7f238d0aa7).This fixes the
UnknownNextPeeroutput described in #984 when usingSendToRoute.