Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure jstype proto definitions are permanent #1038

Closed
ghost opened this issue Jun 17, 2019 · 3 comments
Closed

ensure jstype proto definitions are permanent #1038

ghost opened this issue Jun 17, 2019 · 3 comments
Assignees
@sangaman
Labels
code quality Improving code structure, organization, and clarity P3 low priority

Comments

@ghost
Copy link

ghost commented Jun 17, 2019

This is a follow-up issue to: #1036 to ensure we have some mechanism in place to prevent this from happening in the future.
@ghost ghost assigned sangaman Jun 17, 2019
@sangaman
Copy link
Collaborator

I reopened and rebased lightningnetwork/lnd#2352. Aside from that I'm not that sure what we can do aside from be vigilant when we update the lnd proto definition from the main repo. Any ideas?

@kilrau kilrau added the code quality Improving code structure, organization, and clarity label Aug 29, 2019
@kilrau
Copy link
Contributor

kilrau commented Oct 9, 2019

@erkarl

@kilrau kilrau added the P3 low priority label Oct 9, 2019
@sangaman
Copy link
Collaborator

Done! lightningnetwork/lnd@7408fe5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sangaman sangaman

Labels
code quality Improving code structure, organization, and clarity P3 low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sangaman @kilrau