Skip to content
This repository has been archived by the owner on Jul 2, 2024. It is now read-only.

Fix timezone display part 3 / 5 #76

Merged
merged 11 commits into from
Aug 26, 2017

Conversation

Trim
Copy link
Member

@Trim Trim commented Aug 22, 2017

mivExchangeCalendar.js: getItemsFromMemoryCache: fix looking for items in memory cache

The code before were using simple day index to go through start and end of the
range. Furthermore, it didn't managed that range were given in local timezone
and memory cache is in UTC.

This fix use Lightning tools to go through range and it converts local timezone
to UTC, so the cache is correctly read.

Fixes #67

@Trim Trim changed the title Fix timezone display part 3 Fix timezone display part 3 / 5 Aug 22, 2017
@Trim Trim changed the base branch from fix-timezone-display-part2 to ec-4.0 August 23, 2017 06:11
Trim added 11 commits August 25, 2017 15:10
Note that logInfo already do itself debug param check before logging.
Remove use of this.debug
Inverse tests inside if statements to avoid double negation (not, else)
…s in cache

The code before were using simple day index to go through start and end of the
range. Furthermore, it didn't managed that range were given in local timezone
and memory cache is in UTC.

This fix use Lightning tools to go through range and it converts local timezone
to UTC, so the cache is correctly read.

Fixes Ericsson#67
@Trim Trim force-pushed the fix-timezone-display-part3 branch from 6d4bb48 to 8963df8 Compare August 25, 2017 19:15
@advancingu
Copy link
Member

Ok, Github is still showing the commits that were already merged, even though the have the exact same hashes. That's too bad.
In any case, it is only one additional commit which looks fine.

@advancingu advancingu merged commit fc0fd26 into ExchangeCalendar:ec-4.0 Aug 26, 2017
@Trim Trim deleted the fix-timezone-display-part3 branch August 29, 2017 13:54
@Trim Trim restored the fix-timezone-display-part3 branch August 29, 2017 13:54
@Trim Trim deleted the fix-timezone-display-part3 branch August 29, 2017 13:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants