This repository has been archived by the owner on Jul 2, 2024. It is now read-only.
forked from Ericsson/exchangecalendar
-
Notifications
You must be signed in to change notification settings - Fork 57
Fix timezone display part 3 / 5 #76
Merged
advancingu
merged 11 commits into
ExchangeCalendar:ec-4.0
from
Trim:fix-timezone-display-part3
Aug 26, 2017
Merged
Fix timezone display part 3 / 5 #76
advancingu
merged 11 commits into
ExchangeCalendar:ec-4.0
from
Trim:fix-timezone-display-part3
Aug 26, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that logInfo already do itself debug param check before logging.
Remove use of this.debug Inverse tests inside if statements to avoid double negation (not, else)
…ilability calendar events
…s in cache The code before were using simple day index to go through start and end of the range. Furthermore, it didn't managed that range were given in local timezone and memory cache is in UTC. This fix use Lightning tools to go through range and it converts local timezone to UTC, so the cache is correctly read. Fixes Ericsson#67
Trim
force-pushed
the
fix-timezone-display-part3
branch
from
August 25, 2017 19:15
6d4bb48
to
8963df8
Compare
Ok, Github is still showing the commits that were already merged, even though the have the exact same hashes. That's too bad. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mivExchangeCalendar.js: getItemsFromMemoryCache: fix looking for items in memory cache
The code before were using simple day index to go through start and end of the
range. Furthermore, it didn't managed that range were given in local timezone
and memory cache is in UTC.
This fix use Lightning tools to go through range and it converts local timezone
to UTC, so the cache is correctly read.
Fixes #67