Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UX error when saving Out of Office #67

Closed
SockThief opened this issue Jan 7, 2015 · 9 comments
Closed

UX error when saving Out of Office #67

SockThief opened this issue Jan 7, 2015 · 9 comments

Comments

@SockThief
Copy link

When saving an Out of Office message, the alert box uses a red-exclamation mark type icon, which is inappropriate for a successful notification. Simillarly the alert-tone used is more related to error than ok
@andrelaszlo
Copy link

It's not possible to change the icon when calling alert. IMO, modals should be avoided completely unless something actually goes wrong (then the "alert" and ❗ semantics is still appropriate).

bavincen added a commit that referenced this issue Jan 7, 2015
@bavincen
UX error when saving Out of Office #67
d5e2965
@bavincen
Copy link

bavincen commented Jan 7, 2015

you may check this updated popup notification

@bavincen
Copy link

bavincen commented Jan 8, 2015

screenshot from 2015-01-08 09 34 16

@bavincen bavincen closed this as completed Jan 8, 2015
@SockThief
Copy link
Author

i like that change :) much better

@Mechtilde
Copy link

Where caqn I find the string "Out of Office" for translation

@bavincen
Copy link

bavincen commented Jan 8, 2015

This is title of window

@bavincen
Copy link

bavincen commented Jan 9, 2015

locale/exchangecalendar/en-US/oofSettings.dtd
title.oofsettings for english please find your respective folder and edit it .. thanks :)

@muthusuba
Copy link

Similar dialog seems to appear after successfully forwarding an event.

bavincen added a commit that referenced this issue Jan 13, 2015
@bavincen
UX error when saving Out of Office #67
105783a
@bavincen
Copy link

updated

Trim added a commit to Trim/exchangecalendar that referenced this issue Aug 18, 2017
@Trim
mivExchangeCalendar.js: getItemsFromMemoryCache: fix looking for item…
6d4bb48 
…s in cache

The code before were using simple day index to go through start and end of the
range. Furthermore, it didn't managed that range were given in local timezone
and memory cache is in UTC.

This fix use Lightning tools to go through range and it converts local timezone
to UTC, so the cache is correctly read.

Fixes Ericsson#67
Trim added a commit to Trim/exchangecalendar that referenced this issue Aug 25, 2017
@Trim
mivExchangeCalendar.js: getItemsFromMemoryCache: fix looking for item…
8963df8 
…s in cache

The code before were using simple day index to go through start and end of the
range. Furthermore, it didn't managed that range were given in local timezone
and memory cache is in UTC.

This fix use Lightning tools to go through range and it converts local timezone
to UTC, so the cache is correctly read.

Fixes Ericsson#67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@andrelaszlo @muthusuba @SockThief @Mechtilde @bavincen