attachment-view.js: update toolbar default items to latest Lightning

[Trim]

Fix javascript code to:

• avoid removing event listener
• avoid using try/catch without need
• avoid to reset current set of items, but instead add back attachment
  if not already in toolbar and url attachment is there

[Trim]

This PR should fix #9

It could need to reset the toolbar to default (see the personalize window) to have back real default buttons.

[advancingu]

@Trim Thanks for the PR.

Is this how it is supposed to look for an Exchange calendar in the menu? Also, the Attachments button has no icon (but space is reserved for one).

Exchange calendar:

For reference, here is a CalDAV calendar:

[Trim]

In the xul, there's no image defined, that's why we don't see one. I'll check if I can add the same image than the standard button.

For the menu, it should not display a list, but open the dialog too.

Thanks for your tests !

[Trim]

I have to close this PR, because here I have the same issue than the editor in event dialog:

Now, the event dialog window is broken, because all items have been moved in an iframe by Lightning.

I'm working on it and I add the commits to the PR #11

[advancingu]

@Trim In this case, I would suggest fixing #11 first and once that is merged work on the fix for this issue here separately. It makes it much easier to review PRs when only one issue is addressed at a time. However, if you already have the code included in the other branch now, leave it in there.

[Trim]

Yes I understand it's better to do one by one, but the changes made by Lightning forces me to do everything at same time: the new iframe is not accessible from the window and the window is not accessible from the iframe.

So I have to find a way to do actions from menus and from dialog even if the DOM space is not shared. I'm taking time tomorrow to study how Lightning is able to do that.