Event dialog: fix content editor and attendees dialog #11
Conversation
This commit fix the overlay, but the JavaScript needs now fixes to hide/display exchangecalendar items with the good context.
This code was the same than the original Lightening code contained in chrome://messenger/content/messenger.xul Exchangecalendar has nothing added and the overlay is bugged: * it didn't overlay the context menu in the attendee tab on the bottom of the dialog * it didn't display days and times in the header of attendee dialog
…alizer to get valid xhtml code (with XML tags well terminated)
correctly setup current window.
This reverts commit 9f0aacb. I'm reverting this change, since I use now correctly formatted xhtml which avoids exceptions while saving content to innerHTML.
…hange task is edited
…tead of capture This is to be sure to be called after the Lightening onLoad() listener.
|
@Trim Thanks as well for the PR here. Tested a bit and found the following: In this PR, date and time input boxes are double-nested: In the |
|
Thanks for the tests, I supposed that was because of the GTK3 migration of Thunderbrid, so I didn't take care. I'll check why we have such double nest. |
… of datetime picker
|
Well, this commit fix the double nesting for the current TB release. Although, for the current TB beta, it looses the new graphical datetime picker. I'm looking to find a solution to have both working, but for now, this code works with TB release. Edit: I've just seen you already have graphical datetime picker in your screen shots. I don't have them under Debian 9 even with a blank profile, strange... |
Fix javascript code to: * avoid removing event listener * avoid using try/catch without need * avoid to reset current set of items, but instead add back attachment if not already in toolbar and url attachment is there
|
I'll made a new branch to fix the entire event-dialog. On this one, I've made a lot of experiments and they are more noise than really relevant. I have to take time to read this documentation and make a plan before coding. |
|
Ok, Lightning allows now to use window dialog or tabs to open event and tasks. That's why the dialog is now defined in an iframe. First step for us will be to correctly update the standard window dialog, then we could take in consideration for the tab view. I didn't now, but the parent can modify its ifram child by use of contextWindow: https://developer.mozilla.org/en-US/docs/Web/API/HTMLIFrameElement/contentWindow So, we should be able to use work in this branch. |
To reflect clearly the calendar event dialog has been moved to an iframe by Lightning, we move all our stuff to the new name.
…t menu Tabs have been replaced by spaces too as most of the file where replaced too.
|
Great, that sounds like it will do the trick. |
…dow menu and toolbar Now that the main dialog is included in an iframe, we have to communicate with the iframe from the parent to give to the iframe the good commands. The structure of sendMessage/receiveMessage come from the Lightning project. Especially the sendMessage() function which send command with the good event id (needed for tab view).
…commands from parent using the receiveMessage() function.
As window menu and toolbar belong to the parent, the inner iframe can't modify them.
|
Ok, I've updated this branch as the work wasn't so big I thought yesterday. Now attachment menus and attachment list works well (including context menu on right click). I think I won't have the motivation to debug the issue with the HTML content editor. |
|
@Trim Great, this works fine now. |
This merge request try to resolve issue #5 and the "add attendees dialog":
Some times, the HTML editor won't work: you'll be unable to see/edit content and toolbar buttons will be not responding. When the editor is in this state, a workaround is to close the window and open it again.