Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] connect: add df.limit and df.first #3309

Merged
merged 2 commits into from
Nov 21, 2024

separate tests

e099f2e
Select commit
Loading
Failed to load commit list.
Merged

[FEAT] connect: add df.limit and df.first #3309

separate tests
e099f2e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 21, 2024 in 1s

77.35% (+0.00%) compared to 3394a66

View this Pull Request on Codecov

77.35% (+0.00%) compared to 3394a66

Details

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.35%. Comparing base (3394a66) to head (e099f2e).

Files with missing lines Patch % Lines
src/daft-connect/src/translation/logical_plan.rs 87.50% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3309   +/-   ##
=======================================
  Coverage   77.35%   77.35%           
=======================================
  Files         685      685           
  Lines       83631    83639    +8     
=======================================
+ Hits        64695    64703    +8     
  Misses      18936    18936           
Files with missing lines Coverage Δ
src/daft-connect/src/translation/logical_plan.rs 71.42% <87.50%> (+9.89%) ⬆️

... and 1 file with indirect coverage changes

---- 🚨 Try these New Features: