Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] connect: add df.limit and df.first #3309

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Conversation

andrewgazelka
Copy link
Member

@andrewgazelka andrewgazelka commented Nov 18, 2024

No description provided.

@andrewgazelka andrewgazelka force-pushed the andrew/connect-first branch 2 times, most recently from c00b97d to 9718df8 Compare November 18, 2024 21:21
@andrewgazelka andrewgazelka force-pushed the andrew/improve-range branch 5 times, most recently from 3901ec2 to 4f1210c Compare November 20, 2024 03:26
Copy link
Member Author

andrewgazelka commented Nov 20, 2024

Base automatically changed from andrew/improve-range to main November 20, 2024 03:47
@github-actions github-actions bot added the enhancement New feature or request label Nov 20, 2024
@andrewgazelka andrewgazelka changed the base branch from main to andrew/connect-consolidate-session November 20, 2024 03:49
Copy link

codspeed-hq bot commented Nov 20, 2024

CodSpeed Performance Report

Merging #3309 will degrade performances by 48.97%

Comparing andrew/connect-first (e099f2e) with main (3394a66)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 15 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main andrew/connect-first Change
test_iter_rows_first_row[100 Small Files] 324.1 ms 284 ms +14.11%
test_show[100 Small Files] 15.9 ms 31.2 ms -48.97%

Base automatically changed from andrew/connect-consolidate-session to main November 20, 2024 19:52
@andrewgazelka andrewgazelka force-pushed the andrew/connect-first branch 2 times, most recently from adfc808 to 02e0d1e Compare November 20, 2024 23:29
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.35%. Comparing base (3394a66) to head (e099f2e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/daft-connect/src/translation/logical_plan.rs 87.50% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3309   +/-   ##
=======================================
  Coverage   77.35%   77.35%           
=======================================
  Files         685      685           
  Lines       83631    83639    +8     
=======================================
+ Hits        64695    64703    +8     
  Misses      18936    18936           
Files with missing lines Coverage Δ
src/daft-connect/src/translation/logical_plan.rs 71.42% <87.50%> (+9.89%) ⬆️

... and 1 file with indirect coverage changes

---- 🚨 Try these New Features:

Copy link
Member Author

andrewgazelka commented Nov 21, 2024

Merge activity

  • Nov 21, 11:41 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Nov 21, 11:41 AM EST: Graphite couldn't merge this PR because it failed optional checks and "ignore optional checks" was not selected.

@andrewgazelka andrewgazelka merged commit cbe9d3b into main Nov 21, 2024
46 of 47 checks passed
@andrewgazelka andrewgazelka deleted the andrew/connect-first branch November 21, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants