Fix write_crystfel_geom offset unit #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have no idea why the test failed... |
takluyver
reviewed
Aug 27, 2021
extra_geom/crystfel_fmt.py
Outdated
| @@ -54,7 +54,8 @@ def _crystfel_format_vec(vec): | |||
|
|
|||
| def frag_to_crystfel(fragment, p, a, ss_slice, fs_slice, dims, pixel_size): | |||
| tile_name = 'p{}a{}'.format(p, a) | |||
| c = fragment.corner_pos / pixel_size | |||
| c = fragment.corner_pos | |||
| c[:2] = c[:2] / pixel_size | |||
There was a problem hiding this comment.
This will modify fragment.corner_pos, so exporting a geometry object to a .geom file will change it. This is because c is a reference to the existing array, not a copy.
For clarity, I think it's better to make a separate array with positions in pixel units, rather than mixing pixel units and metres in the same array.
There was a problem hiding this comment.
Does it mean the corner_pos needs to be redefined here if one will have a separate variable for the offset?
|
Please see the current workaround: |
takluyver
reviewed
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #101