'coffset' unit when write_crystfel_geom

[JunCEEE]

Hi @takluyver,

I just found a 'coffset' problem related to #59. Although we fixed the 'coffset' unit in reading, it still writes in pixel unit (line 77):

EXtra-geom/extra_geom/crystfel_fmt.py

Line 57 in 1ab6100

c = fragment.corner_pos / pixel_size

EXtra-geom/extra_geom/crystfel_fmt.py

Lines 66 to 77 in 1ab6100

	return PANEL_TEMPLATE.format(
	dims='\n'.join(dim_list),
	name=tile_name,
	min_ss=ss_slice.start,
	max_ss=ss_slice.stop - 1,
	min_fs=fs_slice.start,
	max_fs=fs_slice.stop - 1,
	ss_vec=_crystfel_format_vec(fragment.ss_vec / pixel_size),
	fs_vec=_crystfel_format_vec(fragment.fs_vec/ pixel_size),
	corner_x=c[0],
	corner_y=c[1],
	coffset=c[2],

I could submit a pull request to fix it if you like.

---

Reproduce:

from extra_geom import AGIPD_1MGeometry
geom_file = 'agipd_20210820.geom'
save_file = 'agipd_20210820_rewrite.geom'
geom = AGIPD_1MGeometry.from_crystfel_geom(geom_file)
geom.inspect()
geom.write_crystfel_geom(save_file,dims=('frame', 'ss', 'fs'),clen=0.1218, adu_per_ev=0.0075, photon_energy=9300)
geom_new = AGIPD_1MGeometry.from_crystfel_geom(save_file)
geom_new.inspect()

Geometry files:
agipd_20210820.zip

Converted file:

Original file:

[takluyver]

Thanks Jun - a pull request would be welcome. Maybe we can also add a z-shift in one of the tests (with the offset() method) to check that it's written to and read from CrystFEL files correctly.

[JunCEEE]

@takluyver A pull request is submitted. Where should I add the test?