Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'coffset' in the corner_pos #59

Closed
JunCEEE opened this issue Apr 1, 2021 · 2 comments · Fixed by #60
Closed

'coffset' in the corner_pos #59

JunCEEE opened this issue Apr 1, 2021 · 2 comments · Fixed by #60

Comments

@JunCEEE
Copy link
Contributor

JunCEEE commented Apr 1, 2021

corner_pos = np.array([d['cnx'], d['cny'], d['coffset']]) / res

According to https://www.desy.de/~twhite/crystfel/manual-crystfel_geometry.html, coffset is already in metres, do we still need to multiply 1/res to it?

@takluyver
Copy link
Member

Yes, I think you're right. I think we've worked with geometry files where coffset is usually 0, so we didn't spot this. Do you want to make a PR to fix it?

@JunCEEE
Copy link
Contributor Author

JunCEEE commented Apr 1, 2021

Yes, just did the PR #60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants