-
-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to new unison images fixes #810 #813
Conversation
Since there are currently no CI engines available to run MacOS on M1, nor any MacOS offering CI that runs docker-for-mac (license issues), i cannot test docker-sync on it's home platform in the CI and thus rely on the community to do that testing - i do no longer own a mac |
@EugenMayer I see the gem version needs to be updated. |
@yoseph1998 you need to compile / run from source, yes |
@EugenMayer Yes, I have this branched cloned locally and I am running ./deploy_locally.sh I updated the version locally to 0.7.3 so that I can validate the installed docker-sync is the one from this branch. I was only able to make this work with the changes proposed above (adding |
change the value in https://github.com/EugenMayer/docker-sync/blob/main/VERSION to 1.0.0 and run deploy locally again. be sure to run gem uninstall docker-sync before that |
@EugenMayer Yes, that's what I am doing (on If I update those files to use |
Really odd i missed that after i actually already worked on those lines .. kind got lost over it. Fixed it, could you try once again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EugenMayer Tested and working locally (M1 MacOS). Thank you!
I don't see the version being updated in this PR, is that happening outside of the MR? |
Yes @yoseph1998 version will be planned when the release is planned. Which will happen very soon |
@EugenMayer Great. All LGTM. Again thank you for all this work! |
Your welcome, you did a fair share of this too. Thank you |
Migrate to new unison images which are build for amd64/arm64 using manifests. This will fix #810