Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Wrong Unison image is pulled on M1 Mac #810

Closed
yosephsa opened this issue Aug 25, 2022 · 4 comments · Fixed by #813
Closed

Bug: Wrong Unison image is pulled on M1 Mac #810

yosephsa opened this issue Aug 25, 2022 · 4 comments · Fixed by #813

Comments

@yosephsa
Copy link
Contributor

yosephsa commented Aug 25, 2022

Error/Feature Requestion/Docs

When starting docker sync on an M1 Mac the wrong image is pulled. The AMD unison image is pulled by default regardless of architecture. Instead the ARM image should be pulled for ARM architecture machines.

Docker Driver

Rancher Desktop with moby and dockerd

Sync strategy

default (on osx)

your docker-sync.yml

version: "2"
syncs:
  app-sync:
    src: './'

OS

OSX Monterey 12.5.1

Reference:

Original issue opened in unison repository EugenMayer/docker-image-unison#28

@yosephsa
Copy link
Contributor Author

yosephsa commented Aug 25, 2022

@EugenMayer Created a PR that fixes this issue -> #811

@yosephsa yosephsa changed the title Wrong Unison image is pulled on M1 Mac Bug: Wrong Unison image is pulled on M1 Mac Aug 25, 2022
@EugenMayer
Copy link
Owner

Started working on the migration the new image on #813

@EugenMayer
Copy link
Owner

@yoseph1998 could you test the branch on your M1?

Since there are currently no CI engines available to run MacOS on M1, nor any MacOS offering CI that runs docker-for-mac (license issues), i cannot test docker-sync on it's home platform in the CI and thus rely on the community to do that testing - i do no longer own a mac.

@yosephsa
Copy link
Contributor Author

yosephsa commented Sep 8, 2022

Sure I can do so, I’ll let you know when I test it, give me a few hours.

FYI only Docker Desktop is license restricted. The CLI and Engine are still open source and don’t carry any restrictions for commercial use. Rancher Desktop is currently the number 1 alternative to set everything up (virtual machine for the Linux daemon on Mac, cli and connecting it all).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants