chore: sync hotfix to main #9448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nts) output when a click is emitted when the component is appended to the DOM (#9423) **Related Issue:** #9321 ## Summary This updates the combobox window-click listener to use an internal state property for its text instead of getting the value of the internal input. The `componentOnReady` util helps normalize waiting for a component to be ready in both output targets (based on [Ionic's helper](https://github.com/ionic-team/ionic-framework/blob/5cdfa1aaf47a6160cd1bd2be434dcfa8390b56e1/core/src/utils/helpers.ts#L60-L79)). This is sufficient for most scenarios, but for this particular case, it was running earlier than `connectedCallback` due to the emitted click as the component is appended and initialized, so the component is not yet rendered by the time the util resolves. **Note**: there are no accompanying tests as this is not reproducible in the test environment, which uses the lazy-loaded output.
…#9443) **Related Issue:** #9397 ## Summary This updates the `FloatingUIComponent` implementation to defer calling `autoUpdate` until the component is open and connected (following `floating-ui` [usage notes](https://floating-ui.com/docs/autoupdate#usage)).
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 2.8.4</summary> [2.8.4](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2024-05-28) * **combobox:** Fix error that occurs in `dist-custom-elements` (`components`) output when a click is emitted when the component is appended to the DOM ([#9423](#9423)) ([ab521c9](ab521c9)) * Defer floating-ui updating until component is connected and open ([#9443](#9443)) ([6e09589](6e09589)) </details> <details><summary>@esri/calcite-components-angular: 2.8.4</summary> [2.8.4](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2024-05-28) * **@esri/calcite-components-angular:** Synchronize components versions * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.8.3 to ^2.8.4 </details> <details><summary>@esri/calcite-components-react: 2.8.4</summary> [2.8.4](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2024-05-28) * **@esri/calcite-components-react:** Synchronize components versions * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.8.3 to ^2.8.4 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
benelan
requested review from
jcfranco,
driskull,
geospatialem and
a team
as code owners
github-actions
bot
added
the
chore
benelan
added
pr ready for visual snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #9438
Summary
Sync changes from the
2.8.4hotfix release tomain.