fix: defer floating-ui updating until component is connected and open #9443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
jcfranco
added
the
pr ready for visual snapshots
jcfranco
added
pr ready for visual snapshots
jcfranco
deleted the
jcfranco/9397-improve-floating-ui-component-performance-hotfix
branch
Merged
jcfranco
pushed a commit
that referenced
this pull request
May 29, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 2.8.4</summary> ## [2.8.4](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2024-05-28) ### Bug Fixes * **combobox:** Fix error that occurs in `dist-custom-elements` (`components`) output when a click is emitted when the component is appended to the DOM ([#9423](#9423)) ([ab521c9](ab521c9)) * Defer floating-ui updating until component is connected and open ([#9443](#9443)) ([6e09589](6e09589)) </details> <details><summary>@esri/calcite-components-angular: 2.8.4</summary> ## [2.8.4](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2024-05-28) ### Miscellaneous Chores * **@esri/calcite-components-angular:** Synchronize components versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.8.3 to ^2.8.4 </details> <details><summary>@esri/calcite-components-react: 2.8.4</summary> ## [2.8.4](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2024-05-28) ### Miscellaneous Chores * **@esri/calcite-components-react:** Synchronize components versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.8.3 to ^2.8.4 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
benelan
pushed a commit
that referenced
this pull request
May 29, 2024
…#9443) **Related Issue:** #9397 ## Summary This updates the `FloatingUIComponent` implementation to defer calling `autoUpdate` until the component is open and connected (following `floating-ui` [usage notes](https://floating-ui.com/docs/autoupdate#usage)).
benelan
pushed a commit
that referenced
this pull request
May 29, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 2.8.4</summary> [2.8.4](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2024-05-28) * **combobox:** Fix error that occurs in `dist-custom-elements` (`components`) output when a click is emitted when the component is appended to the DOM ([#9423](#9423)) ([ab521c9](ab521c9)) * Defer floating-ui updating until component is connected and open ([#9443](#9443)) ([6e09589](6e09589)) </details> <details><summary>@esri/calcite-components-angular: 2.8.4</summary> [2.8.4](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2024-05-28) * **@esri/calcite-components-angular:** Synchronize components versions * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.8.3 to ^2.8.4 </details> <details><summary>@esri/calcite-components-react: 2.8.4</summary> [2.8.4](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2024-05-28) * **@esri/calcite-components-react:** Synchronize components versions * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.8.3 to ^2.8.4 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
benelan
pushed a commit
that referenced
this pull request
May 29, 2024
…#9443) **Related Issue:** #9397 ## Summary This updates the `FloatingUIComponent` implementation to defer calling `autoUpdate` until the component is open and connected (following `floating-ui` [usage notes](https://floating-ui.com/docs/autoupdate#usage)).
benelan
pushed a commit
that referenced
this pull request
May 29, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 2.8.4</summary> [2.8.4](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2024-05-28) * **combobox:** Fix error that occurs in `dist-custom-elements` (`components`) output when a click is emitted when the component is appended to the DOM ([#9423](#9423)) ([ab521c9](ab521c9)) * Defer floating-ui updating until component is connected and open ([#9443](#9443)) ([6e09589](6e09589)) </details> <details><summary>@esri/calcite-components-angular: 2.8.4</summary> [2.8.4](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2024-05-28) * **@esri/calcite-components-angular:** Synchronize components versions * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.8.3 to ^2.8.4 </details> <details><summary>@esri/calcite-components-react: 2.8.4</summary> [2.8.4](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2024-05-28) * **@esri/calcite-components-react:** Synchronize components versions * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.8.3 to ^2.8.4 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
benelan
added a commit
that referenced
this pull request
May 29, 2024
…hes--main * origin/main: chore: release next ci: add repo url to package.json files for provenance (#9449) ci(provenance): add missing options from setup doc (#9433) chore: release hotfix (#9438) fix: defer floating-ui updating until component is connected and open (#9443) fix(combobox): fix error that occurs in dist-custom-elements (components) output when a click is emitted when the component is appended to the DOM (#9423)
6 tasks
jcfranco
added a commit
that referenced
this pull request
May 30, 2024
…tialization logic in components output target (#9470) **Related Issue:** #9468 ## Summary #9443 introduced a regression caused by using the `componentOnLoad` util to consolidate initialization logic shared between `connectedCallback` and `componentDidLoad`. The util appears to resolve at a different time in the `components` output target, which messed up with initialization of certain components. **Note**: there are no accompanying tests as this is not reproducible in the test environment, which uses the lazy-loaded output.
benelan
pushed a commit
that referenced
this pull request
Jun 25, 2024
…tialization logic in components output target (#9470) **Related Issue:** #9468 ## Summary #9443 introduced a regression caused by using the `componentOnLoad` util to consolidate initialization logic shared between `connectedCallback` and `componentDidLoad`. The util appears to resolve at a different time in the `components` output target, which messed up with initialization of certain components. **Note**: there are no accompanying tests as this is not reproducible in the test environment, which uses the lazy-loaded output.
benelan
pushed a commit
that referenced
this pull request
Jun 25, 2024
…tialization logic in components output target (#9470) **Related Issue:** #9468 ## Summary #9443 introduced a regression caused by using the `componentOnLoad` util to consolidate initialization logic shared between `connectedCallback` and `componentDidLoad`. The util appears to resolve at a different time in the `components` output target, which messed up with initialization of certain components. **Note**: there are no accompanying tests as this is not reproducible in the test environment, which uses the lazy-loaded output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #9397
Summary
This updates the
FloatingUIComponentimplementation to defer callingautoUpdateuntil the component is open and connected (followingfloating-uiusage notes).