Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Date picker: year is slightly cut off #6410

Closed
jlias-devtester opened this issue Feb 1, 2023 · 6 comments
Closed

Date picker: year is slightly cut off #6410

jlias-devtester opened this issue Feb 1, 2023 · 6 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Online Issues logged by ArcGIS Online team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. c-datepicker Issues that pertain to the calcite-date-picker component estimate - 3 A day or two of work, likely requires updates to tests. low risk Issues with low risk for consideration in low risk milestones p - low Issue is non core or affecting less that 10% of people using the library
Milestone
2024-10-29 - Oct ...

Comments

@jlias-devtester
Copy link

jlias-devtester commented Feb 1, 2023 •
edited by geospatialem
Loading

Actual Behavior

The year in the date-picker component is slightly cut off on the end:

image

Expected Behavior

The year shouldn't be cut off

Reproduction Sample

https://codepen.io/mac_and_cheese/pen/KKxEMoK

Reproduction Steps

  1. Visit the sample on Mac OS
  2. Observe the year is cut off

Reproduction Version

1.1.0

Relevant Info

Seems to be specific to Mac OS across browsers (Chrome, FF, Safari). Windows browsers appear to be unaffected (tested on Chrome, FF, Edge).

Regression?

No response

Impact

No response

Esri team

ArcGIS Online
@jlias-devtester jlias-devtester added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Feb 1, 2023
@github-actions github-actions bot added the ArcGIS Online Issues logged by ArcGIS Online team members. label Feb 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

It looks like this issue is missing some information:

  • A codepen, codesandbox, or jsbin that reproduces the issue. Alternatively, a documentation sample can be used if the issue is reproducible. If you are experiencing build or Node related errors, please provide a GitHub repo for the sample.

Issues without reproduction samples may not be prioritized. If you were unable to create a sample, please try to answer any questions that arise once development begins. Thanks for your understanding.

@github-actions github-actions bot added the incomplete issue report New issues missing important information, and unless provided, they will be closed after 5 days. label Feb 1, 2023
@benelan
Copy link
Member

benelan commented Feb 1, 2023

Hi @jlias-devtester - did you close the issue because you figured out a solution? I'm not able to reproduce this on my end with this sample https://codepen.io/benesri/pen/qByQYyJ

If you are still experiencing the issue can you provide some additional information, such as browser, operating system, etc? A sample that reproduces the issue would also be very helpful. Thanks!

@macandcheese
Copy link
Contributor

It's reproducible in scale "L" : https://codepen.io/mac_and_cheese/pen/KKxEMoK?editors=1010

@macandcheese macandcheese reopened this Mar 27, 2023
@geospatialem
Copy link
Member

It's reproducible in scale "L" : https://codepen.io/mac_and_cheese/pen/KKxEMoK?editors=1010

Am able to reproduce the scale="l" bug in https://codepen.io/mac_and_cheese/pen/KKxEMoK on Mac OS across browsers (Chrome, FF, Safari), but Windows browsers are unaffected (tested on Chrome, FF, and Edge).

@geospatialem geospatialem removed the incomplete issue report New issues missing important information, and unless provided, they will be closed after 5 days. label Mar 27, 2023
@macandcheese macandcheese added the c-datepicker Issues that pertain to the calcite-date-picker component label Mar 30, 2023
@brittneytewks brittneytewks added p - low Issue is non core or affecting less that 10% of people using the library estimate - 3 A day or two of work, likely requires updates to tests. labels Apr 11, 2023
@brittneytewks brittneytewks added this to the 2023 August Priorities milestone Apr 11, 2023
@brittneytewks brittneytewks removed the needs triage Planning workflow - pending design/dev review. label Apr 11, 2023
@geospatialem geospatialem mentioned this issue Apr 17, 2023
Closed
@brittneytewks brittneytewks added the low risk Issues with low risk for consideration in low risk milestones label Aug 30, 2023
This was referenced Jan 8, 2024
Open
Closed
@geospatialem geospatialem removed this from the Dev Backlog milestone Jan 29, 2024
@geospatialem geospatialem added this to the 2024-08-27 - Aug Release milestone Jan 29, 2024
@anveshmekala anveshmekala mentioned this issue May 22, 2024
Merged
@geospatialem geospatialem added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Jul 29, 2024
anveshmekala added a commit that referenced this issue Oct 23, 2024
@anveshmekala
feat(input-date-picker, date-picker): improve date picking experience (…
24d43ad 
…#8402)

**Related Issue:** #3455, #10113 

## Summary

Update `calcite-date-picker` & `calcite-input-date-picker` UI & UX.



![4D1CFC3C-8FF9-4493-9178-4DEDA0417031](https://github.com/user-attachments/assets/4b1f5a12-85df-4577-b1cd-812c22e41ef7)

### Key changes
- display two calendars for range irrespective of layout.
- No longer switches focus from day to end input when startDate is
selected initially.
- Month selection is possible via select menu
- No longer positions the date-picker component relative to endInput
when endInput is focused in range.
- Dates from previous months are not visible in range calendar.
- Divider indicator icons are removed in horizontal layout for range in
input-date-picker.
- No longer uses chevron icon which indicate the open status of
input-date-picker in startInput field.


Other issues resolved :
#6321
#6410
#10301
#10291
#10113
#10243
#10490

Blocked issues: #9167 

Wiki
https://github.com/Esri/calcite-design-system/wiki/date%E2%80%90picker-enhancement-%238402
@anveshmekala anveshmekala added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Oct 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned anveshmekala Oct 23, 2024
@DitwanP
Copy link
Contributor

DitwanP commented Oct 28, 2024

🍡 Verified on 2.14.0-next.18
https://codepen.io/Ditwan-Price/pen/BaXYEoR

@DitwanP DitwanP closed this as completed Oct 28, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Oct 28, 2024
benelan pushed a commit that referenced this issue Feb 8, 2025
@anveshmekala @benelan
feat(input-date-picker, date-picker): improve date picking experience (…
d03bfa6 
…#8402)

**Related Issue:** #3455, #10113 

## Summary

Update `calcite-date-picker` & `calcite-input-date-picker` UI & UX.



![4D1CFC3C-8FF9-4493-9178-4DEDA0417031](https://github.com/user-attachments/assets/4b1f5a12-85df-4577-b1cd-812c22e41ef7)

### Key changes
- display two calendars for range irrespective of layout.
- No longer switches focus from day to end input when startDate is
selected initially.
- Month selection is possible via select menu
- No longer positions the date-picker component relative to endInput
when endInput is focused in range.
- Dates from previous months are not visible in range calendar.
- Divider indicator icons are removed in horizontal layout for range in
input-date-picker.
- No longer uses chevron icon which indicate the open status of
input-date-picker in startInput field.


Other issues resolved :
#6321
#6410
#10301
#10291
#10113
#10243
#10490

Blocked issues: #9167 

Wiki
https://github.com/Esri/calcite-design-system/wiki/date%E2%80%90picker-enhancement-%238402
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Online Issues logged by ArcGIS Online team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. c-datepicker Issues that pertain to the calcite-date-picker component estimate - 3 A day or two of work, likely requires updates to tests. low risk Issues with low risk for consideration in low risk milestones p - low Issue is non core or affecting less that 10% of people using the library
Projects
None yet
Milestone
2024-10-29 - Oct Milestone
Development

No branches or pull requests
7 participants
@macandcheese @geospatialem @benelan @DitwanP @jlias-devtester @anveshmekala @brittneytewks